[2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT
diff mbox series

Message ID 20190425163846.51730-2-dmitry.torokhov@gmail.com
State Mainlined
Commit bd21d847924845175fed9756d560cd1c4669f2c5
Delegated to: Jiri Kosina
Headers show
Series
  • [1/2] Input: add KEY_KBD_LAYOUT_NEXT
Related show

Commit Message

Dmitry Torokhov April 25, 2019, 4:38 p.m. UTC
HUTRR56 defined a new usage code on consumer page to cycle through
set of keyboard layouts, let's add this mapping.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/hid/hid-input.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Benjamin Tissoires April 26, 2019, 6:38 a.m. UTC | #1
On Thu, Apr 25, 2019 at 6:38 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> HUTRR56 defined a new usage code on consumer page to cycle through
> set of keyboard layouts, let's add this mapping.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

I don't think this will collide with the HID tree, so IMO, you can
take this through yours if you want.

Cheers,
Benjamin

>  drivers/hid/hid-input.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index b607286a0bc8..0579b8d3f912 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1051,6 +1051,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>                 case 0x28b: map_key_clear(KEY_FORWARDMAIL);     break;
>                 case 0x28c: map_key_clear(KEY_SEND);            break;
>
> +               case 0x29d: map_key_clear(KEY_KBD_LAYOUT_NEXT); break;
> +
>                 case 0x2c7: map_key_clear(KEY_KBDINPUTASSIST_PREV);             break;
>                 case 0x2c8: map_key_clear(KEY_KBDINPUTASSIST_NEXT);             break;
>                 case 0x2c9: map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP);                break;
> --
> 2.21.0.593.g511ec345e18-goog
>
Dmitry Torokhov April 26, 2019, 11:33 p.m. UTC | #2
On Fri, Apr 26, 2019 at 08:38:29AM +0200, Benjamin Tissoires wrote:
> On Thu, Apr 25, 2019 at 6:38 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > HUTRR56 defined a new usage code on consumer page to cycle through
> > set of keyboard layouts, let's add this mapping.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> 
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> I don't think this will collide with the HID tree, so IMO, you can
> take this through yours if you want.

OK, I will do that, thanks!

Patch
diff mbox series

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index b607286a0bc8..0579b8d3f912 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1051,6 +1051,8 @@  static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 		case 0x28b: map_key_clear(KEY_FORWARDMAIL);	break;
 		case 0x28c: map_key_clear(KEY_SEND);		break;
 
+		case 0x29d: map_key_clear(KEY_KBD_LAYOUT_NEXT);	break;
+
 		case 0x2c7: map_key_clear(KEY_KBDINPUTASSIST_PREV);		break;
 		case 0x2c8: map_key_clear(KEY_KBDINPUTASSIST_NEXT);		break;
 		case 0x2c9: map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP);		break;