diff mbox series

[v4] clk: qoriq: add support for lx2160a

Message ID 1556261624-20504-1-git-send-email-vabhav.sharma@nxp.com (mailing list archive)
State Accepted, archived
Headers show
Series [v4] clk: qoriq: add support for lx2160a | expand

Commit Message

Vabhav Sharma April 26, 2019, 6:53 a.m. UTC 
Add clockgen support and configuration for NXP SoC lx2160a
with compatible property as "fsl,lx2160a-clockgen".

Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Acked-by: Scott Wood <oss@buserror.net>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Changes for v4:
- Incorporated review comments from Stephen Boyd
 
Changes for v3:
- Incorporated review comments of Rafael J. Wysocki
- Updated commit message

Changes for v2:
- Subject line updated

 drivers/clk/clk-qoriq.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Vabhav Sharma May 21, 2019, 5:43 a.m. UTC | #1 
Hello Stephen, 
I have incorporated review comments from https://patchwork.kernel.org/patch/10917171/

A gentle reminder to apply the patch https://patchwork.kernel.org/patch/10918407/.

Regards,
Vabhav

> -----Original Message-----
> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> Sent: Friday, April 26, 2019 12:24 PM
> To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org
> Cc: sboyd@kernel.org; mturquette@baylibre.com; Vabhav Sharma
> <vabhav.sharma@nxp.com>; Andy Tang <andy.tang@nxp.com>; Yogesh
> Narayan Gaur <yogeshnarayan.gaur@nxp.com>
> Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> 
> Add clockgen support and configuration for NXP SoC lx2160a with
> compatible property as "fsl,lx2160a-clockgen".
> 
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Acked-by: Scott Wood <oss@buserror.net>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Changes for v4:
> - Incorporated review comments from Stephen Boyd
> 
> Changes for v3:
> - Incorporated review comments of Rafael J. Wysocki
> - Updated commit message
> 
> Changes for v2:
> - Subject line updated
> 
>  drivers/clk/clk-qoriq.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> 3d51d7c..1a15201 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
>  		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
>  	},
>  	{
> +		.compat = "fsl,lx2160a-clockgen",
> +		.cmux_groups = {
> +			&clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> +		},
> +		.cmux_to_group = {
> +			0, 0, 0, 0, 1, 1, 1, 1, -1
> +		},
> +		.pll_mask = 0x37,
> +		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
> +	},
> +	{
>  		.compat = "fsl,p2041-clockgen",
>  		.guts_compat = "fsl,qoriq-device-config-1.0",
>  		.init_periph = p2041_init_periph,
> @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> "fsl,ls1043a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-
> clockgen", clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> "fsl,ls2080a-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> +clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
> --
> 2.7.4
Vabhav Sharma May 23, 2019, 2:05 p.m. UTC | #2 
> -----Original Message-----
> From: Vabhav Sharma
> Sent: Tuesday, May 21, 2019 11:14 AM
> To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org;
> sboyd@kernel.org
> Cc: mturquette@baylibre.com; Andy Tang <andy.tang@nxp.com>; Yogesh
> Narayan Gaur <yogeshnarayan.gaur@nxp.com>
> Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
> 
> Hello Stephen,
> I have incorporated review comments from
> https://patchwork.kernel.org/patch/10917171/
Hello Maintainers,
All the comments are addressed, Can you please take the patch?
Please see this is essential for new hardware support.

Regards,
Vabhav
> 
> A gentle reminder to apply the patch
> https://patchwork.kernel.org/patch/10918407/.
> 
> Regards,
> Vabhav
> 
> > -----Original Message-----
> > From: Vabhav Sharma <vabhav.sharma@nxp.com>
> > Sent: Friday, April 26, 2019 12:24 PM
> > To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org
> > Cc: sboyd@kernel.org; mturquette@baylibre.com; Vabhav Sharma
> > <vabhav.sharma@nxp.com>; Andy Tang <andy.tang@nxp.com>; Yogesh
> Narayan
> > Gaur <yogeshnarayan.gaur@nxp.com>
> > Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> >
> > Add clockgen support and configuration for NXP SoC lx2160a with
> > compatible property as "fsl,lx2160a-clockgen".
> >
> > Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > Acked-by: Scott Wood <oss@buserror.net>
> > Acked-by: Stephen Boyd <sboyd@kernel.org>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > Changes for v4:
> > - Incorporated review comments from Stephen Boyd
> >
> > Changes for v3:
> > - Incorporated review comments of Rafael J. Wysocki
> > - Updated commit message
> >
> > Changes for v2:
> > - Subject line updated
> >
> >  drivers/clk/clk-qoriq.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 3d51d7c..1a15201 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> >  		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
> >  	},
> >  	{
> > +		.compat = "fsl,lx2160a-clockgen",
> > +		.cmux_groups = {
> > +			&clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > +		},
> > +		.cmux_to_group = {
> > +			0, 0, 0, 0, 1, 1, 1, 1, -1
> > +		},
> > +		.pll_mask = 0x37,
> > +		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > +	},
> > +	{
> >  		.compat = "fsl,p2041-clockgen",
> >  		.guts_compat = "fsl,qoriq-device-config-1.0",
> >  		.init_periph = p2041_init_periph,
> > @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> > "fsl,ls1043a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-
> > clockgen", clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > +clockgen_init);
> >  CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > "fsl,p3041-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > clockgen_init);
> > --
> > 2.7.4
Andy Tang June 13, 2019, 6:47 a.m. UTC | #3 
Hi Stephen, Mturquette,

Who will apply this patch? https://patchwork.kernel.org/patch/10918407/
All the comments are addressed and got acked by:
Acked-by: Scott Wood <oss@buserror.net>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Could you please apply it?

BR,
Andy


> -----Original Message-----
> From: Vabhav Sharma
> Sent: 2019年5月23日 22:05
> To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org;
> mturquette@baylibre.com; sboyd@kernel.org
> Cc: mturquette@baylibre.com; sboyd@kernel.org; Andy Tang
> <andy.tang@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>
> Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
> 
> > -----Original Message-----
> > From: Vabhav Sharma
> > Sent: Tuesday, May 21, 2019 11:14 AM
> > To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org;
> > sboyd@kernel.org
> > Cc: mturquette@baylibre.com; Andy Tang <andy.tang@nxp.com>; Yogesh
> > Narayan Gaur <yogeshnarayan.gaur@nxp.com>
> > Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
> >
> > Hello Stephen,
> > I have incorporated review comments from
> > https://patchwork.kernel.org/patch/10917171/
> Hello Maintainers,
> All the comments are addressed, Can you please take the patch?
> Please see this is essential for new hardware support.
> 
> Regards,
> Vabhav
> >
> > A gentle reminder to apply the patch
> > https://patchwork.kernel.org/patch/10918407/.
> >
> > Regards,
> > Vabhav
> >
> > > -----Original Message-----
> > > From: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > Sent: Friday, April 26, 2019 12:24 PM
> > > To: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org
> > > Cc: sboyd@kernel.org; mturquette@baylibre.com; Vabhav Sharma
> > > <vabhav.sharma@nxp.com>; Andy Tang <andy.tang@nxp.com>; Yogesh
> > Narayan
> > > Gaur <yogeshnarayan.gaur@nxp.com>
> > > Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> > >
> > > Add clockgen support and configuration for NXP SoC lx2160a with
> > > compatible property as "fsl,lx2160a-clockgen".
> > >
> > > Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > Acked-by: Scott Wood <oss@buserror.net>
> > > Acked-by: Stephen Boyd <sboyd@kernel.org>
> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > ---
> > > Changes for v4:
> > > - Incorporated review comments from Stephen Boyd
> > >
> > > Changes for v3:
> > > - Incorporated review comments of Rafael J. Wysocki
> > > - Updated commit message
> > >
> > > Changes for v2:
> > > - Subject line updated
> > >
> > >  drivers/clk/clk-qoriq.c | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > >
> > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > > 3d51d7c..1a15201 100644
> > > --- a/drivers/clk/clk-qoriq.c
> > > +++ b/drivers/clk/clk-qoriq.c
> > > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] =
> {
> > >  		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > >  	},
> > >  	{
> > > +		.compat = "fsl,lx2160a-clockgen",
> > > +		.cmux_groups = {
> > > +			&clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > > +		},
> > > +		.cmux_to_group = {
> > > +			0, 0, 0, 0, 1, 1, 1, 1, -1
> > > +		},
> > > +		.pll_mask = 0x37,
> > > +		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > > +	},
> > > +	{
> > >  		.compat = "fsl,p2041-clockgen",
> > >  		.guts_compat = "fsl,qoriq-device-config-1.0",
> > >  		.init_periph = p2041_init_periph, @@ -1427,6 +1438,7 @@
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> > > "fsl,ls1043a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> > > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1088a,
> > > "fsl,ls1088a- clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > > "fsl,ls2080a-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > > +clockgen_init);
> > >  CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > > "fsl,p3041-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > > clockgen_init);
> > > --
> > > 2.7.4
Stephen Boyd June 25, 2019, 10:58 p.m. UTC | #4 
Quoting Vabhav Sharma (2019-04-25 23:53:38)
> Add clockgen support and configuration for NXP SoC lx2160a
> with compatible property as "fsl,lx2160a-clockgen".
> 
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Acked-by: Scott Wood <oss@buserror.net>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 3d51d7c..1a15201 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -570,6 +570,17 @@  static const struct clockgen_chipinfo chipinfo[] = {
 		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
 	},
 	{
+		.compat = "fsl,lx2160a-clockgen",
+		.cmux_groups = {
+			&clockgen2_cmux_cga12, &clockgen2_cmux_cgb
+		},
+		.cmux_to_group = {
+			0, 0, 0, 0, 1, 1, 1, 1, -1
+		},
+		.pll_mask = 0x37,
+		.flags = CG_VER3 | CG_LITTLE_ENDIAN,
+	},
+	{
 		.compat = "fsl,p2041-clockgen",
 		.guts_compat = "fsl,qoriq-device-config-1.0",
 		.init_periph = p2041_init_periph,
@@ -1427,6 +1438,7 @@  CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);