diff mbox series

KVM: s390: vsie: Return correct values for Invalid CRYCB format

Message ID 1556269201-22918-1-git-send-email-pmorel@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series KVM: s390: vsie: Return correct values for Invalid CRYCB format | expand

Commit Message

Pierre Morel April 26, 2019, 9 a.m. UTC 
Let's use the correct validity number.

Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"

Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Hildenbrand April 26, 2019, 9:01 a.m. UTC | #1 
On 26.04.19 11:00, Pierre Morel wrote:
> Let's use the correct validity number.
> 
> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"

 LANG=c git show 55ded154b43
fatal: ambiguous argument '55ded154b43': unknown revision or path not in
the working tree.
Use '--' to separate paths from revisions, like this:


> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  arch/s390/kvm/vsie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index ac411e9..076090f 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>  end:
>  	switch (ret) {
>  	case -EINVAL:
> -		return set_validity_icpt(scb_s, 0x0020U);
> +		return set_validity_icpt(scb_s, 0x0022U);
>  	case -EFAULT:
>  		return set_validity_icpt(scb_s, 0x0035U);
>  	case -EACCES:
>
Christian Borntraeger April 26, 2019, 9:03 a.m. UTC | #2 
On 26.04.19 11:01, David Hildenbrand wrote:
> On 26.04.19 11:00, Pierre Morel wrote:
>> Let's use the correct validity number.
>>
>> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
> 
>  LANG=c git show 55ded154b43
> fatal: ambiguous argument '55ded154b43': unknown revision or path not in
> the working tree.
> Use '--' to separate paths from revisions, like this:
> 

I think this should be 
56019f9aca2266edc7f304d91e4e772023b7aa14

> 
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  arch/s390/kvm/vsie.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
>> index ac411e9..076090f 100644
>> --- a/arch/s390/kvm/vsie.c
>> +++ b/arch/s390/kvm/vsie.c
>> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>>  end:
>>  	switch (ret) {
>>  	case -EINVAL:
>> -		return set_validity_icpt(scb_s, 0x0020U);
>> +		return set_validity_icpt(scb_s, 0x0022U);
>>  	case -EFAULT:
>>  		return set_validity_icpt(scb_s, 0x0035U);
>>  	case -EACCES:
>>
> 
>
David Hildenbrand April 26, 2019, 9:07 a.m. UTC | #3 
On 26.04.19 11:00, Pierre Morel wrote:
> Let's use the correct validity number.
> 
> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  arch/s390/kvm/vsie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index ac411e9..076090f 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>  end:
>  	switch (ret) {
>  	case -EINVAL:
> -		return set_validity_icpt(scb_s, 0x0020U);
> +		return set_validity_icpt(scb_s, 0x0022U);
>  	case -EFAULT:
>  		return set_validity_icpt(scb_s, 0x0035U);
>  	case -EACCES:
> 

Can't verify

Acked-by: David Hildenbrand <david@redhat.com>
Pierre Morel April 26, 2019, 10:48 a.m. UTC | #4 
On 26/04/2019 11:03, Christian Borntraeger wrote:
> 
> 
> On 26.04.19 11:01, David Hildenbrand wrote:
>> On 26.04.19 11:00, Pierre Morel wrote:
>>> Let's use the correct validity number.
>>>
>>> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
>>
>>   LANG=c git show 55ded154b43
>> fatal: ambiguous argument '55ded154b43': unknown revision or path not in
>> the working tree.
>> Use '--' to separate paths from revisions, like this:
>>
> 
> I think this should be
> 56019f9aca2266edc7f304d91e4e772023b7aa14

Yes it is, sorry, forgot to adjust the hash

> 
>>
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>>   arch/s390/kvm/vsie.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
>>> index ac411e9..076090f 100644
>>> --- a/arch/s390/kvm/vsie.c
>>> +++ b/arch/s390/kvm/vsie.c
>>> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>>>   end:
>>>   	switch (ret) {
>>>   	case -EINVAL:
>>> -		return set_validity_icpt(scb_s, 0x0020U);
>>> +		return set_validity_icpt(scb_s, 0x0022U);
>>>   	case -EFAULT:
>>>   		return set_validity_icpt(scb_s, 0x0035U);
>>>   	case -EACCES:
>>>
>>
>>
>
Pierre Morel April 26, 2019, 10:54 a.m. UTC | #5 
On 26/04/2019 11:07, David Hildenbrand wrote:
> On 26.04.19 11:00, Pierre Morel wrote:
>> Let's use the correct validity number.
>>
>> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>   arch/s390/kvm/vsie.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
>> index ac411e9..076090f 100644
>> --- a/arch/s390/kvm/vsie.c
>> +++ b/arch/s390/kvm/vsie.c
>> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>>   end:
>>   	switch (ret) {
>>   	case -EINVAL:
>> -		return set_validity_icpt(scb_s, 0x0020U);
>> +		return set_validity_icpt(scb_s, 0x0022U);
>>   	case -EFAULT:
>>   		return set_validity_icpt(scb_s, 0x0035U);
>>   	case -EACCES:
>>
> 
> Can't verify
> 
> Acked-by: David Hildenbrand <david@redhat.com>
> 

Thanks.
Christian Borntraeger April 29, 2019, 7:01 a.m. UTC | #6 
On 26.04.19 11:00, Pierre Morel wrote:
> Let's use the correct validity number.
> 
> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  arch/s390/kvm/vsie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index ac411e9..076090f 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>  end:
>  	switch (ret) {
>  	case -EINVAL:
> -		return set_validity_icpt(scb_s, 0x0020U);
> +		return set_validity_icpt(scb_s, 0x0022U);
>  	case -EFAULT:
>  		return set_validity_icpt(scb_s, 0x0035U);
>  	case -EACCES:
> 

Thanks applied.
diff mbox series

Patch

diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
index ac411e9..076090f 100644
--- a/arch/s390/kvm/vsie.c
+++ b/arch/s390/kvm/vsie.c
@@ -344,7 +344,7 @@  static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES: