| Message ID | 20190426164313.32308-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [-next] crypto: ccree - Make cc_sec_disable static | expand |
On Fri, Apr 26, 2019 at 7:43 PM Yue Haibing <yuehaibing@huawei.com> wrote: > > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/crypto/ccree/cc_driver.c:37:6: warning: > symbol 'cc_sec_disable' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thank you! The kbuit test robot already sent the same fix, which I acked. It's hard competing with the bots... :-) Gilad -- Gilad Ben-Yossef Chief Coffee Drinker values of β will give rise to dom!
On 2019/4/28 15:56, Gilad Ben-Yossef wrote: > On Fri, Apr 26, 2019 at 7:43 PM Yue Haibing <yuehaibing@huawei.com> wrote: >> >> From: YueHaibing <yuehaibing@huawei.com> >> >> Fix sparse warning: >> >> drivers/crypto/ccree/cc_driver.c:37:6: warning: >> symbol 'cc_sec_disable' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thank you! > > The kbuit test robot already sent the same fix, which I acked. > It's hard competing with the bots... :-) Indeed, I did not find a fix before sending this. > > Gilad > > > > -- > Gilad Ben-Yossef > Chief Coffee Drinker > > values of β will give rise to dom! > >
On Sun, Apr 28, 2019 at 10:56:51AM +0300, Gilad Ben-Yossef wrote: > On Fri, Apr 26, 2019 at 7:43 PM Yue Haibing <yuehaibing@huawei.com> wrote: > > > > From: YueHaibing <yuehaibing@huawei.com> > > > > Fix sparse warning: > > > > drivers/crypto/ccree/cc_driver.c:37:6: warning: > > symbol 'cc_sec_disable' was not declared. Should it be static? > > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thank you! > > The kbuit test robot already sent the same fix, which I acked. > It's hard competing with the bots... :-) For some reason the robot's patch didn't make it into patchwork so I'm going to take this one instead. Cheers,
On Sat, Apr 27, 2019 at 12:43:13AM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/crypto/ccree/cc_driver.c:37:6: warning: > symbol 'cc_sec_disable' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/crypto/ccree/cc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index 902f196..4ea8e19 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -34,7 +34,7 @@ bool cc_dump_bytes; module_param_named(dump_bytes, cc_dump_bytes, bool, 0600); MODULE_PARM_DESC(cc_dump_bytes, "Dump buffers to kernel log as debugging aid"); -bool cc_sec_disable; +static bool cc_sec_disable; module_param_named(sec_disable, cc_sec_disable, bool, 0600); MODULE_PARM_DESC(cc_sec_disable, "Disable security functions");