diff mbox series

[-next] counter: 104-quad-8: Make quad8_ops static

Message ID 20190426164816.37032-1-yuehaibing@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] counter: 104-quad-8: Make quad8_ops static | expand

Commit Message

Yue Haibing April 26, 2019, 4:48 p.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/counter/104-quad-8.c:836:26: warning:
 symbol 'quad8_ops' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

William Breathitt Gray April 27, 2019, 12:27 a.m. UTC | #1 
On Sat, Apr 27, 2019 at 12:48:16AM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/counter/104-quad-8.c:836:26: warning:
>  symbol 'quad8_ops' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/counter/104-quad-8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 4fa2931..00b113f 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -833,7 +833,7 @@ static int quad8_action_get(struct counter_device *counter,
>  	return 0;
>  }
>  
> -const struct counter_ops quad8_ops = {
> +static const struct counter_ops quad8_ops = {
>  	.signal_read = quad8_signal_read,
>  	.count_read = quad8_count_read,
>  	.count_write = quad8_count_write,
> -- 
> 2.7.4

Yes, thank you, this should be static.

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
diff mbox series

Patch

diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 4fa2931..00b113f 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -833,7 +833,7 @@  static int quad8_action_get(struct counter_device *counter,
 	return 0;
 }
 
-const struct counter_ops quad8_ops = {
+static const struct counter_ops quad8_ops = {
 	.signal_read = quad8_signal_read,
 	.count_read = quad8_count_read,
 	.count_write = quad8_count_write,