staging: vc04_services: bcm2835-camera: Modify return statement.
diff mbox series

Message ID 20190429073658.32009-1-vatsalanarang@gmail.com
State New
Headers show
Series
  • staging: vc04_services: bcm2835-camera: Modify return statement.
Related show

Commit Message

Vatsala Narang April 29, 2019, 7:36 a.m. UTC
Modify return statement and remove the respective assignment.

Issue found by coccinelle.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
 drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Stefan Wahren April 29, 2019, 8:12 a.m. UTC | #1
Hi Vatsala,

Am 29.04.2019 um 09:36 schrieb Vatsala Narang:
> Modify return statement and remove the respective assignment.
>
> Issue found by coccinelle.
>
i didn't check other occurences of the same issue since your last patch 
(27.04.2019).

Could you please verify this is the last one of this type in bcm2835-camera?

Otherwise please send a patch to fixed them all.

Thanks Stefan
Greg Kroah-Hartman April 30, 2019, 1 p.m. UTC | #2
On Mon, Apr 29, 2019 at 01:06:58PM +0530, Vatsala Narang wrote:
> Modify return statement and remove the respective assignment.
> 
> Issue found by coccinelle.
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

You sent two different patches that did different things with the same
exact subject: line :(

Please make them more unique.

thanks,

greg k-h

Patch
diff mbox series

diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
index c9b6346111a5..cef6d5b758e8 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
@@ -1507,10 +1507,9 @@  static int set_camera_parameters(struct vchiq_mmal_instance *instance,
 		.use_stc_timestamp = MMAL_PARAM_TIMESTAMP_MODE_RAW_STC
 	};
 
-	ret = vchiq_mmal_port_parameter_set(instance, &camera->control,
+	return vchiq_mmal_port_parameter_set(instance, &camera->control,
 					    MMAL_PARAMETER_CAMERA_CONFIG,
 					    &cam_config, sizeof(cam_config));
-	return ret;
 }
 
 #define MAX_SUPPORTED_ENCODINGS 20