| Message ID | 20190429142253.15882-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/csr: alpha_support doesn't depend on csr or vice versa | expand |
On Mon, Apr 29, 2019 at 05:22:53PM +0300, Jani Nikula wrote: > Debug logging should not be dependent on alpha support flag. > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> I agree... this is not the right way to track dependencies. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_csr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c > index f43c2a2563a5..4527b9662330 100644 > --- a/drivers/gpu/drm/i915/intel_csr.c > +++ b/drivers/gpu/drm/i915/intel_csr.c > @@ -529,8 +529,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) > > if (csr->fw_path == NULL) { > DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n"); > - WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv))); > - > return; > } > > -- > 2.20.1 >
On Mon, 29 Apr 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > On Mon, Apr 29, 2019 at 05:22:53PM +0300, Jani Nikula wrote: >> Debug logging should not be dependent on alpha support flag. >> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > I agree... this is not the right way to track dependencies. > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Pushed, thanks. BR, Jani. > >> --- >> drivers/gpu/drm/i915/intel_csr.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c >> index f43c2a2563a5..4527b9662330 100644 >> --- a/drivers/gpu/drm/i915/intel_csr.c >> +++ b/drivers/gpu/drm/i915/intel_csr.c >> @@ -529,8 +529,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) >> >> if (csr->fw_path == NULL) { >> DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n"); >> - WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv))); >> - >> return; >> } >> >> -- >> 2.20.1 >>
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index f43c2a2563a5..4527b9662330 100644 --- a/drivers/gpu/drm/i915/intel_csr.c +++ b/drivers/gpu/drm/i915/intel_csr.c @@ -529,8 +529,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) if (csr->fw_path == NULL) { DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n"); - WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv))); - return; }
Debug logging should not be dependent on alpha support flag. Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/intel_csr.c | 2 -- 1 file changed, 2 deletions(-)