[v9] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

Commit Message

Aditya Swarup April 29, 2019, 11:08 p.m. UTC

From: Clinton Taylor <[e-mail]>

v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.

Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.

v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.

Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.

v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.

v6: Fix comment formatting (Ville)

v7: Add reviewed by Ville

v8: Set GCP_COLOR_INDICATION based on spec:
For Gen 7.5 or later platforms, indicate color depth only for deep
color modes. Bspec: 8135,7751,50524

Pre DDI platforms, indicate color depth if deep color is supported
by sink. Bspec: 7854

Exception: CHERRYVIEW behaves like Pre DDI platforms.
Bspec: 15975

Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
to not set 12 bit deep color for every modeset. This fixes the issue
where 12 bit color was selected even when user selected 10 bit.(Ville)

v9: Maintain a consistent behavior for all platforms and support
GCP_COLOR_INDICATION only when we are in deep color mode. Remove
hdmi_sink_is_deep_color() - no longer needed as checking pipe_bpp > 24
takes care of the deep color mode scenario.

Separate patch for fixing switch from 12 bit to 10 bit deep color
mode.

Co-developed-by: Aditya Swarup <[e-mail]>
Signed-off-by: Clinton Taylor <[e-mail]>
Signed-off-by: Aditya Swarup <[e-mail]>
Cc: Ville Syrjälä <[e-mail]>
Cc: Jani Nikula <[e-mail]>
Cc: Manasi Navare <[e-mail]>
Reviewed-by: Ville Syrjälä <[e-mail]>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

Comments

Aditya Swarup May 3, 2019, 11:04 p.m. UTC | #1

On Tue, Apr 30, 2019 at 01:46:15PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev8)
> URL   : https://patchwork.freedesktop.org/series/58912/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12900_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_12900_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_12900_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_12900_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_caching@read-writes:
>     - shard-skl:          [PASS][1] -> [INCOMPLETE][2] +6 similar issues
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl9/igt@[e-mail]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl9/igt@[e-mail]
> 
>   * igt@gem_mmap_gtt@forked-big-copy-odd:
>     - shard-skl:          NOTRUN -> [INCOMPLETE][3] +1 similar issue
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl2/igt@[e-mail]
Hi Martin,

These failures shouldn't be due to my patch. Is there a separate bug
filed for gem_caching and gem_mmap_gtt failures?

Regards,
Aditya Swarup
> 
>   
> #### Warnings ####
> 
>   * igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
>     - shard-skl:          [SKIP][4] ([fdo#109271]) -> [INCOMPLETE][5] +1 similar issue
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl6/igt@[e-mail]
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl8/igt@[e-mail]
> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_12900_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_cpu_reloc@forked:
>     - shard-iclb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#107713] / [fdo#109100])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb4/igt@[e-mail]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb3/igt@[e-mail]
> 
>   * igt@i915_pm_rpm@pm-tiling:
>     - shard-skl:          [PASS][8] -> [INCOMPLETE][9] ([fdo#107807])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl10/igt@[e-mail]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl9/igt@[e-mail]
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
>     - shard-snb:          [PASS][10] -> [SKIP][11] ([fdo#109271] / [fdo#109278]) +1 similar issue
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-snb1/igt@[e-mail]
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb6/igt@[e-mail]
> 
>   * igt@kms_cursor_crc@cursor-64x21-offscreen:
>     - shard-skl:          [PASS][12] -> [FAIL][13] ([fdo#103232])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl2/igt@[e-mail]
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl3/igt@[e-mail]
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible:
>     - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] / [k.org#198133]) +2 similar issues
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk5/igt@[e-mail]
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk7/igt@[e-mail]
>     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +1 similar issue
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl8/igt@[e-mail]
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-apl8/igt@[e-mail]
>     - shard-snb:          [PASS][18] -> [INCOMPLETE][19] ([fdo#105411])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-snb5/igt@[e-mail]
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb1/igt@[e-mail]
> 
>   * igt@kms_flip@nonexisting-fb-interruptible:
>     - shard-iclb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#107713])
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb3/igt@[e-mail]
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb4/igt@[e-mail]
> 
>   * igt@kms_flip@plain-flip-ts-check-interruptible:
>     - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#100368])
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl2/igt@[e-mail]
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl1/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [PASS][24] -> [FAIL][25] ([fdo#103167]) +4 similar issues
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb6/igt@[e-mail]
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
>     - shard-skl:          [PASS][26] -> [INCOMPLETE][27] ([fdo#106978])
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl5/igt@[e-mail]
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl7/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>     - shard-skl:          [PASS][28] -> [FAIL][29] ([fdo#108145])
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl5/igt@[e-mail]
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl7/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [PASS][30] -> [FAIL][31] ([fdo#108145] / [fdo#110403])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl2/igt@[e-mail]
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl3/igt@[e-mail]
> 
>   * igt@kms_plane_cursor@pipe-b-overlay-size-256:
>     - shard-snb:          [PASS][32] -> [SKIP][33] ([fdo#109271]) +5 similar issues
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-snb1/igt@[e-mail]
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb6/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_cursor_mmap_cpu:
>     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441]) +2 similar issues
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
> 
>   * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
>     - shard-kbl:          [PASS][36] -> [FAIL][37] ([fdo#109016])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-kbl7/igt@[e-mail]
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-kbl4/igt@[e-mail]
> 
>   * igt@kms_rotation_crc@sprite-rotation-180:
>     - shard-skl:          [PASS][38] -> [INCOMPLETE][39] ([fdo#108972]) +1 similar issue
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl1/igt@[e-mail]
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl4/igt@[e-mail]
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          [PASS][40] -> [FAIL][41] ([fdo#99912])
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-kbl5/igt@[e-mail]
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-kbl4/igt@[e-mail]
> 
>   * igt@kms_sysfs_edid_timing:
>     - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#100047])
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb6/igt@kms_sysfs_edid_timing.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb3/igt@kms_sysfs_edid_timing.html
> 
>   * igt@perf_pmu@busy-idle-rcs0:
>     - shard-hsw:          [PASS][44] -> [INCOMPLETE][45] ([fdo#103540]) +2 similar issues
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-hsw5/igt@[e-mail]
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-hsw6/igt@[e-mail]
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_suspend@fence-restore-untiled:
>     - shard-apl:          [DMESG-WARN][46] ([fdo#108566]) -> [PASS][47] +3 similar issues
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl2/igt@[e-mail]
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-apl3/igt@[e-mail]
> 
>   * igt@kms_cursor_crc@cursor-64x64-suspend:
>     - shard-skl:          [INCOMPLETE][48] ([fdo#104108]) -> [PASS][49]
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl3/igt@[e-mail]
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl10/igt@[e-mail]
> 
>   * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
>     - shard-glk:          [FAIL][50] ([fdo#106509] / [fdo#107409]) -> [PASS][51]
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk2/igt@[e-mail]
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk1/igt@[e-mail]
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-skl:          [FAIL][52] ([fdo#105363]) -> [PASS][53]
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl3/igt@[e-mail]
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl6/igt@[e-mail]
> 
>   * igt@kms_flip@modeset-vs-vblank-race:
>     - shard-glk:          [FAIL][54] ([fdo#103060]) -> [PASS][55]
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk8/igt@[e-mail]
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk1/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
>     - shard-iclb:         [FAIL][56] ([fdo#103167]) -> [PASS][57] +3 similar issues
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb1/igt@[e-mail]
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb5/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
>     - shard-skl:          [INCOMPLETE][58] ([fdo#104108] / [fdo#106978]) -> [PASS][59]
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl7/igt@[e-mail]
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl3/igt@[e-mail]
>     - shard-iclb:         [INCOMPLETE][60] ([fdo#106978] / [fdo#107713]) -> [PASS][61]
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb4/igt@[e-mail]
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/igt@[e-mail]
> 
>   * igt@kms_plane@pixel-format-pipe-c-planes:
>     - shard-glk:          [SKIP][62] ([fdo#109271]) -> [PASS][63]
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk4/igt@[e-mail]
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk9/igt@[e-mail]
> 
>   * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
>     - shard-glk:          [SKIP][64] ([fdo#109271] / [fdo#109278]) -> [PASS][65]
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-glk7/igt@[e-mail]
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk9/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_cursor_plane_onoff:
>     - shard-iclb:         [SKIP][66] ([fdo#109441]) -> [PASS][67] +3 similar issues
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [FAIL][68] ([fdo#99912]) -> [PASS][69]
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-apl5/igt@[e-mail]
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-apl4/igt@[e-mail]
> 
>   * igt@tools_test@tools_test:
>     - shard-iclb:         [SKIP][70] ([fdo#109352]) -> [PASS][71]
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-iclb8/igt@tools_test@tools_test.html
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb6/igt@tools_test@tools_test.html
> 
>   
> #### Warnings ####
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
>     - shard-skl:          [FAIL][72] ([fdo#108040]) -> [FAIL][73] ([fdo#103167])
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-skl8/igt@[e-mail]
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl5/igt@[e-mail]
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>   [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
>   [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
>   [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
>   [fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
>   [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#108972]: https://bugs.freedesktop.org/show_bug.cgi?id=108972
>   [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
>   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_6012 -> Patchwork_12900
> 
>   CI_DRM_6012: e4882f199157e3fb73d1791352931096f6ecfcfd @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_12900: 1707feeade4b0b06b27845ac8177c942984f1c35 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/

Saarinen, Jani May 4, 2019, 5:55 a.m. UTC | #2

Hi,
> -----Original Message-----
> From: Intel-gfx [mailto:[e-mail]] On Behalf Of
> Aditya Swarup
> Sent: lauantai 4. toukokuuta 2019 2.04
> To: [e-mail]
> Cc: Peres, Martin <[e-mail]>
> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl: Set
> GCP_COLOR_INDICATION only for 10/12 bit deep color (rev8)
> 
> On Tue, Apr 30, 2019 at 01:46:15PM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
> (rev8)
> > URL   : https://patchwork.freedesktop.org/series/58912/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12900_full
> > ====================================================
> >
> > Summary
> > -------
> >
> >   **FAILURE**
> >
> >   Serious unknown changes coming with Patchwork_12900_full absolutely need to
> be
> >   verified manually.
> >
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_12900_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> >
> >
> >
> > Possible new issues
> > -------------------
> >
> >   Here are the unknown changes that may have been introduced in
> Patchwork_12900_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> >   * igt@gem_caching@read-writes:
> >     - shard-skl:          [PASS][1] -> [INCOMPLETE][2] +6 similar issues
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl9/igt@[e-mail]
> >    [2]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl9/ig
> > t@[e-mail]
> >
> >   * igt@gem_mmap_gtt@forked-big-copy-odd:
> >     - shard-skl:          NOTRUN -> [INCOMPLETE][3] +1 similar issue
> >    [3]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl2/ig
> > t@[e-mail]
> Hi Martin,
> 
> These failures shouldn't be due to my patch. Is there a separate bug filed for
> gem_caching and gem_mmap_gtt failures?
Yes, this still I guess due to : https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl2/run25.log 
=> Tomi, still happening: https://bugs.freedesktop.org/show_bug.cgi?id=110581

Br,
Jani
> 
> Regards,
> Aditya Swarup
> >
> >
> > #### Warnings ####
> >
> >   * igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
> >     - shard-skl:          [SKIP][4] ([fdo#109271]) -> [INCOMPLETE][5] +1 similar issue
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl6/igt@[e-mail]
> >    [5]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl8/ig
> > t@[e-mail]
> >
> >
> > Known issues
> > ------------
> >
> >   Here are the changes found in Patchwork_12900_full that come from known
> issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> >   * igt@gem_cpu_reloc@forked:
> >     - shard-iclb:         [PASS][6] -> [INCOMPLETE][7] ([fdo#107713] / [fdo#109100])
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb4/igt@[e-mail]
> >    [7]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb3/i
> > gt@[e-mail]
> >
> >   * igt@i915_pm_rpm@pm-tiling:
> >     - shard-skl:          [PASS][8] -> [INCOMPLETE][9] ([fdo#107807])
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl10/igt@[e-mail]
> >    [9]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl9/ig
> > t@[e-mail]
> >
> >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> >     - shard-snb:          [PASS][10] -> [SKIP][11] ([fdo#109271] / [fdo#109278]) +1
> similar issue
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> snb1/igt@[e-mail]
> >    [11]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb6/ig
> > t@[e-mail]
> >
> >   * igt@kms_cursor_crc@cursor-64x21-offscreen:
> >     - shard-skl:          [PASS][12] -> [FAIL][13] ([fdo#103232])
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl2/igt@[e-mail]
> >    [13]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl3/ig
> > t@[e-mail]
> >
> >   * igt@kms_flip@flip-vs-suspend-interruptible:
> >     - shard-glk:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103359] /
> [k.org#198133]) +2 similar issues
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> glk5/igt@[e-mail]
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-
> glk7/igt@[e-mail]
> >     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +1 similar
> issue
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> apl8/igt@[e-mail]
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-
> apl8/igt@[e-mail]
> >     - shard-snb:          [PASS][18] -> [INCOMPLETE][19] ([fdo#105411])
> >    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> snb5/igt@[e-mail]
> >    [19]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb1/ig
> > t@[e-mail]
> >
> >   * igt@kms_flip@nonexisting-fb-interruptible:
> >     - shard-iclb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#107713])
> >    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb3/igt@[e-mail]
> >    [21]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb4/i
> > gt@[e-mail]
> >
> >   * igt@kms_flip@plain-flip-ts-check-interruptible:
> >     - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#100368])
> >    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl2/igt@[e-mail]
> >    [23]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl1/ig
> > t@[e-mail]
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> >     - shard-iclb:         [PASS][24] -> [FAIL][25] ([fdo#103167]) +4 similar issues
> >    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-
> render.html
> >    [25]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/i
> > gt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.h
> > tml
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
> >     - shard-skl:          [PASS][26] -> [INCOMPLETE][27] ([fdo#106978])
> >    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl5/igt@[e-mail]
> >    [27]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl7/ig
> > t@[e-mail]
> > ml
> >
> >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> >     - shard-skl:          [PASS][28] -> [FAIL][29] ([fdo#108145])
> >    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl5/igt@[e-mail]
> >    [29]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl7/ig
> > t@[e-mail]
> >
> >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> >     - shard-skl:          [PASS][30] -> [FAIL][31] ([fdo#108145] / [fdo#110403])
> >    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl2/igt@[e-mail]
> >    [31]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl3/ig
> > t@[e-mail]
> >
> >   * igt@kms_plane_cursor@pipe-b-overlay-size-256:
> >     - shard-snb:          [PASS][32] -> [SKIP][33] ([fdo#109271]) +5 similar issues
> >    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> snb1/igt@[e-mail]
> >    [33]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-snb6/ig
> > t@[e-mail]
> >
> >   * igt@kms_psr@psr2_cursor_mmap_cpu:
> >     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441]) +2 similar issues
> >    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >    [35]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb6/i
> > gt@kms_psr@psr2_cursor_mmap_cpu.html
> >
> >   * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
> >     - shard-kbl:          [PASS][36] -> [FAIL][37] ([fdo#109016])
> >    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> kbl7/igt@[e-mail]
> >    [37]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-kbl4/ig
> > t@[e-mail]
> >
> >   * igt@kms_rotation_crc@sprite-rotation-180:
> >     - shard-skl:          [PASS][38] -> [INCOMPLETE][39] ([fdo#108972]) +1 similar issue
> >    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl1/igt@[e-mail]
> >    [39]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl4/ig
> > t@[e-mail]
> >
> >   * igt@kms_setmode@basic:
> >     - shard-kbl:          [PASS][40] -> [FAIL][41] ([fdo#99912])
> >    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> kbl5/igt@[e-mail]
> >    [41]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-kbl4/ig
> > t@[e-mail]
> >
> >   * igt@kms_sysfs_edid_timing:
> >     - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#100047])
> >    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb6/igt@kms_sysfs_edid_timing.html
> >    [43]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb3/i
> > gt@kms_sysfs_edid_timing.html
> >
> >   * igt@perf_pmu@busy-idle-rcs0:
> >     - shard-hsw:          [PASS][44] -> [INCOMPLETE][45] ([fdo#103540]) +2 similar
> issues
> >    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> hsw5/igt@[e-mail]
> >    [45]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-hsw6/ig
> > t@[e-mail]
> >
> >
> > #### Possible fixes ####
> >
> >   * igt@i915_suspend@fence-restore-untiled:
> >     - shard-apl:          [DMESG-WARN][46] ([fdo#108566]) -> [PASS][47] +3 similar
> issues
> >    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> apl2/igt@[e-mail]
> >    [47]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-apl3/ig
> > t@[e-mail]
> >
> >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> >     - shard-skl:          [INCOMPLETE][48] ([fdo#104108]) -> [PASS][49]
> >    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl3/igt@[e-mail]
> >    [49]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl10/i
> > gt@[e-mail]
> >
> >   * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
> >     - shard-glk:          [FAIL][50] ([fdo#106509] / [fdo#107409]) -> [PASS][51]
> >    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> glk2/igt@[e-mail]
> >    [51]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk1/ig
> > t@[e-mail]
> >
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-skl:          [FAIL][52] ([fdo#105363]) -> [PASS][53]
> >    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl3/igt@[e-mail]
> >    [53]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl6/ig
> > t@[e-mail]
> >
> >   * igt@kms_flip@modeset-vs-vblank-race:
> >     - shard-glk:          [FAIL][54] ([fdo#103060]) -> [PASS][55]
> >    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> glk8/igt@[e-mail]
> >    [55]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk1/ig
> > t@[e-mail]
> >
> >   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
> >     - shard-iclb:         [FAIL][56] ([fdo#103167]) -> [PASS][57] +3 similar issues
> >    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb1/igt@[e-mail]
> >    [57]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb5/i
> > gt@[e-mail]
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
> >     - shard-skl:          [INCOMPLETE][58] ([fdo#104108] / [fdo#106978]) -> [PASS][59]
> >    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl7/igt@[e-mail]
> >    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-
> skl3/igt@[e-mail]
> >     - shard-iclb:         [INCOMPLETE][60] ([fdo#106978] / [fdo#107713]) ->
> [PASS][61]
> >    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb4/igt@[e-mail]
> >    [61]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/i
> > gt@[e-mail]
> >
> >   * igt@kms_plane@pixel-format-pipe-c-planes:
> >     - shard-glk:          [SKIP][62] ([fdo#109271]) -> [PASS][63]
> >    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> glk4/igt@[e-mail]
> >    [63]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk9/ig
> > t@[e-mail]
> >
> >   * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
> >     - shard-glk:          [SKIP][64] ([fdo#109271] / [fdo#109278]) -> [PASS][65]
> >    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> glk7/igt@[e-mail]
> >    [65]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-glk9/ig
> > t@[e-mail]
> >
> >   * igt@kms_psr@psr2_cursor_plane_onoff:
> >     - shard-iclb:         [SKIP][66] ([fdo#109441]) -> [PASS][67] +3 similar issues
> >    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
> >    [67]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb2/i
> > gt@kms_psr@psr2_cursor_plane_onoff.html
> >
> >   * igt@kms_setmode@basic:
> >     - shard-apl:          [FAIL][68] ([fdo#99912]) -> [PASS][69]
> >    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> apl5/igt@[e-mail]
> >    [69]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-apl4/ig
> > t@[e-mail]
> >
> >   * igt@tools_test@tools_test:
> >     - shard-iclb:         [SKIP][70] ([fdo#109352]) -> [PASS][71]
> >    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> iclb8/igt@tools_test@tools_test.html
> >    [71]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-iclb6/i
> > gt@tools_test@tools_test.html
> >
> >
> > #### Warnings ####
> >
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
> >     - shard-skl:          [FAIL][72] ([fdo#108040]) -> [FAIL][73] ([fdo#103167])
> >    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
> skl8/igt@[e-mail]
> >    [73]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl5/ig
> > t@[e-mail]
> >
> >
> >   {name}: This element is suppressed. This means it is ignored when computing
> >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> >   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> >   [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
> >   [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
> >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> >   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> >   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> >   [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
> >   [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
> >   [fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
> >   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> >   [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
> >   [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
> >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> >   [fdo#108972]: https://bugs.freedesktop.org/show_bug.cgi?id=108972
> >   [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
> >   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> >   [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
> >   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> >   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
> >   [fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519
> >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> >
> >
> > Participating hosts (10 -> 10)
> > ------------------------------
> >
> >   No changes in participating hosts
> >
> >
> > Build changes
> > -------------
> >
> >   * Linux: CI_DRM_6012 -> Patchwork_12900
> >
> >   CI_DRM_6012: e4882f199157e3fb73d1791352931096f6ecfcfd @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_4968: caed251990f35bfe45368f803980071a73e36315 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_12900: 1707feeade4b0b06b27845ac8177c942984f1c35 @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Sarvela, Tomi P May 6, 2019, 6:59 a.m. UTC | #3

On 5/4/19 8:55 AM, Saarinen, Jani wrote:
> Hi,
>> -----Original Message-----
>> From: Intel-gfx [mailto:[e-mail]] On Behalf Of
>> Aditya Swarup
>> Sent: lauantai 4. toukokuuta 2019 2.04
>> To: [e-mail]
>> Cc: Peres, Martin <[e-mail]>
>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl: Set
>> GCP_COLOR_INDICATION only for 10/12 bit deep color (rev8)
>>
>> On Tue, Apr 30, 2019 at 01:46:15PM +0000, Patchwork wrote:
>>> == Series Details ==
>>>
>>> Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
>> (rev8)
>>> URL   : https://patchwork.freedesktop.org/series/58912/
>>> State : failure
>>>
>>> == Summary ==
>>>
>>> CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12900_full
>>> ====================================================
>>>
>>> Summary
>>> -------
>>>
>>>    **FAILURE**
>>>
>>>    Serious unknown changes coming with Patchwork_12900_full absolutely need to
>> be
>>>    verified manually.
>>>
>>>    If you think the reported changes have nothing to do with the changes
>>>    introduced in Patchwork_12900_full, please notify your bug team to allow them
>>>    to document this new failure mode, which will reduce false positives in CI.
>>>
>>>
>>>
>>> Possible new issues
>>> -------------------
>>>
>>>    Here are the unknown changes that may have been introduced in
>> Patchwork_12900_full:
>>>
>>> ### IGT changes ###
>>>
>>> #### Possible regressions ####
>>>
>>>    * igt@gem_caching@read-writes:
>>>      - shard-skl:          [PASS][1] -> [INCOMPLETE][2] +6 similar issues
>>>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6012/shard-
>> skl9/igt@[e-mail]
>>>     [2]:
>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl9/ig
>>> t@[e-mail]
>>>
>>>    * igt@gem_mmap_gtt@forked-big-copy-odd:
>>>      - shard-skl:          NOTRUN -> [INCOMPLETE][3] +1 similar issue
>>>     [3]:
>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl2/ig
>>> t@[e-mail]
>> Hi Martin,
>>
>> These failures shouldn't be due to my patch. Is there a separate bug filed for
>> gem_caching and gem_mmap_gtt failures?
> Yes, this still I guess due to : https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12900/shard-skl2/run25.log
> => Tomi, still happening: https://bugs.freedesktop.org/show_bug.cgi?id=110581
> 
> Br,
> Jani

This was fixed around IGT_4972 / CI_DRM_6026. We're looking at results 
from around CI_DRM_6012, so yes, 10min timeouts were still happening.

Tomi


>>> Build changes
>>> -------------
>>>
>>>    * Linux: CI_DRM_6012 -> Patchwork_12900


Tomi

Jani Nikula May 7, 2019, 6:42 a.m. UTC | #4

On Mon, 29 Apr 2019, Aditya Swarup <[e-mail]> wrote:
> From: Clinton Taylor <[e-mail]>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> v7: Add reviewed by Ville
>
> v8: Set GCP_COLOR_INDICATION based on spec:
> For Gen 7.5 or later platforms, indicate color depth only for deep
> color modes. Bspec: 8135,7751,50524
>
> Pre DDI platforms, indicate color depth if deep color is supported
> by sink. Bspec: 7854
>
> Exception: CHERRYVIEW behaves like Pre DDI platforms.
> Bspec: 15975
>
> Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> to not set 12 bit deep color for every modeset. This fixes the issue
> where 12 bit color was selected even when user selected 10 bit.(Ville)
>
> v9: Maintain a consistent behavior for all platforms and support
> GCP_COLOR_INDICATION only when we are in deep color mode. Remove
> hdmi_sink_is_deep_color() - no longer needed as checking pipe_bpp > 24
> takes care of the deep color mode scenario.
>
> Separate patch for fixing switch from 12 bit to 10 bit deep color
> mode.
>
> Co-developed-by: Aditya Swarup <[e-mail]>
> Signed-off-by: Clinton Taylor <[e-mail]>
> Signed-off-by: Aditya Swarup <[e-mail]>
> Cc: Ville Syrjälä <[e-mail]>
> Cc: Jani Nikula <[e-mail]>
> Cc: Manasi Navare <[e-mail]>
> Reviewed-by: Ville Syrjälä <[e-mail]>

Ville, does this apply to this version of the patch?

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 17 ++---------------
>  1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index e1005d7b75fd..991eb362ef4f 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -856,19 +856,6 @@ static void g4x_set_infoframes(struct intel_encoder *encoder,
>  			      &crtc_state->infoframes.hdmi);
>  }
>  
> -static bool hdmi_sink_is_deep_color(const struct drm_connector_state *conn_state)
> -{
> -	struct drm_connector *connector = conn_state->connector;
> -
> -	/*
> -	 * HDMI cloning is only supported on g4x which doesn't
> -	 * support deep color or GCP infoframes anyway so no
> -	 * need to worry about multiple HDMI sinks here.
> -	 */
> -
> -	return connector->display_info.bpc > 8;
> -}
> -
>  /*
>   * Determine if default_phase=1 can be indicated in the GCP infoframe.
>   *
> @@ -973,8 +960,8 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
>  	crtc_state->infoframes.enable |=
>  		intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>  
> -	/* Indicate color depth whenever the sink supports deep color */
> -	if (hdmi_sink_is_deep_color(conn_state))
> +	/* Indicate color indication for deep color mode */
> +	if (crtc_state->pipe_bpp > 24)
>  		crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>  
>  	/* Enable default_phase whenever the display mode is suitably aligned */

Ville Syrjälä May 7, 2019, 10:34 a.m. UTC | #5

On Tue, May 07, 2019 at 09:42:48AM +0300, Jani Nikula wrote:
> On Mon, 29 Apr 2019, Aditya Swarup <[e-mail]> wrote:
> > From: Clinton Taylor <[e-mail]>
> >
> > v2: Fix commit msg to reflect why issue occurs(Jani)
> > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> >
> > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > doesn't work correctly using xrandr max bpc property. When we
> > connect a monitor which supports deep color, the highest deep color
> > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > doesn't allow the switch back to 8 bit color.
> >
> > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> >
> > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > is needed to change values for pipe_bpp based on bw_constrained flag.
> >
> > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> >
> > v6: Fix comment formatting (Ville)
> >
> > v7: Add reviewed by Ville
> >
> > v8: Set GCP_COLOR_INDICATION based on spec:
> > For Gen 7.5 or later platforms, indicate color depth only for deep
> > color modes. Bspec: 8135,7751,50524
> >
> > Pre DDI platforms, indicate color depth if deep color is supported
> > by sink. Bspec: 7854
> >
> > Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > Bspec: 15975
> >
> > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> > to not set 12 bit deep color for every modeset. This fixes the issue
> > where 12 bit color was selected even when user selected 10 bit.(Ville)
> >
> > v9: Maintain a consistent behavior for all platforms and support
> > GCP_COLOR_INDICATION only when we are in deep color mode. Remove
> > hdmi_sink_is_deep_color() - no longer needed as checking pipe_bpp > 24
> > takes care of the deep color mode scenario.
> >
> > Separate patch for fixing switch from 12 bit to 10 bit deep color
> > mode.
> >
> > Co-developed-by: Aditya Swarup <[e-mail]>
> > Signed-off-by: Clinton Taylor <[e-mail]>
> > Signed-off-by: Aditya Swarup <[e-mail]>
> > Cc: Ville Syrjälä <[e-mail]>
> > Cc: Jani Nikula <[e-mail]>
> > Cc: Manasi Navare <[e-mail]>
> > Reviewed-by: Ville Syrjälä <[e-mail]>
> 
> Ville, does this apply to this version of the patch?

Aye. lgtm

> 
> BR,
> Jani.
> 
> 
> > ---
> >  drivers/gpu/drm/i915/intel_hdmi.c | 17 ++---------------
> >  1 file changed, 2 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index e1005d7b75fd..991eb362ef4f 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -856,19 +856,6 @@ static void g4x_set_infoframes(struct intel_encoder *encoder,
> >  			      &crtc_state->infoframes.hdmi);
> >  }
> >  
> > -static bool hdmi_sink_is_deep_color(const struct drm_connector_state *conn_state)
> > -{
> > -	struct drm_connector *connector = conn_state->connector;
> > -
> > -	/*
> > -	 * HDMI cloning is only supported on g4x which doesn't
> > -	 * support deep color or GCP infoframes anyway so no
> > -	 * need to worry about multiple HDMI sinks here.
> > -	 */
> > -
> > -	return connector->display_info.bpc > 8;
> > -}
> > -
> >  /*
> >   * Determine if default_phase=1 can be indicated in the GCP infoframe.
> >   *
> > @@ -973,8 +960,8 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> >  	crtc_state->infoframes.enable |=
> >  		intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> >  
> > -	/* Indicate color depth whenever the sink supports deep color */
> > -	if (hdmi_sink_is_deep_color(conn_state))
> > +	/* Indicate color indication for deep color mode */
> > +	if (crtc_state->pipe_bpp > 24)
> >  		crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> >  
> >  	/* Enable default_phase whenever the display mode is suitably aligned */
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center

Jani Nikula May 7, 2019, 11:19 a.m. UTC | #6

On Tue, 07 May 2019, Ville Syrjälä <[e-mail]> wrote:
> On Tue, May 07, 2019 at 09:42:48AM +0300, Jani Nikula wrote:
>> On Mon, 29 Apr 2019, Aditya Swarup <[e-mail]> wrote:
>> > From: Clinton Taylor <[e-mail]>
>> >
>> > v2: Fix commit msg to reflect why issue occurs(Jani)
>> > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>> >
>> > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
>> > doesn't work correctly using xrandr max bpc property. When we
>> > connect a monitor which supports deep color, the highest deep color
>> > setting is selected; which sets GCP_COLOR_INDICATION. When we change
>> > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
>> > doesn't allow the switch back to 8 bit color.
>> >
>> > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
>> > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>> >
>> > Drop the changes in intel_hdmi_compute_config as desired_bpp
>> > is needed to change values for pipe_bpp based on bw_constrained flag.
>> >
>> > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>> >
>> > v6: Fix comment formatting (Ville)
>> >
>> > v7: Add reviewed by Ville
>> >
>> > v8: Set GCP_COLOR_INDICATION based on spec:
>> > For Gen 7.5 or later platforms, indicate color depth only for deep
>> > color modes. Bspec: 8135,7751,50524
>> >
>> > Pre DDI platforms, indicate color depth if deep color is supported
>> > by sink. Bspec: 7854
>> >
>> > Exception: CHERRYVIEW behaves like Pre DDI platforms.
>> > Bspec: 15975
>> >
>> > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
>> > to not set 12 bit deep color for every modeset. This fixes the issue
>> > where 12 bit color was selected even when user selected 10 bit.(Ville)
>> >
>> > v9: Maintain a consistent behavior for all platforms and support
>> > GCP_COLOR_INDICATION only when we are in deep color mode. Remove
>> > hdmi_sink_is_deep_color() - no longer needed as checking pipe_bpp > 24
>> > takes care of the deep color mode scenario.
>> >
>> > Separate patch for fixing switch from 12 bit to 10 bit deep color
>> > mode.
>> >
>> > Co-developed-by: Aditya Swarup <[e-mail]>
>> > Signed-off-by: Clinton Taylor <[e-mail]>
>> > Signed-off-by: Aditya Swarup <[e-mail]>
>> > Cc: Ville Syrjälä <[e-mail]>
>> > Cc: Jani Nikula <[e-mail]>
>> > Cc: Manasi Navare <[e-mail]>
>> > Reviewed-by: Ville Syrjälä <[e-mail]>
>> 
>> Ville, does this apply to this version of the patch?
>
> Aye. lgtm

Thanks for the patch and review, pushed to dinq.

BR,
Jani.


>
>> 
>> BR,
>> Jani.
>> 
>> 
>> > ---
>> >  drivers/gpu/drm/i915/intel_hdmi.c | 17 ++---------------
>> >  1 file changed, 2 insertions(+), 15 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>> > index e1005d7b75fd..991eb362ef4f 100644
>> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> > @@ -856,19 +856,6 @@ static void g4x_set_infoframes(struct intel_encoder *encoder,
>> >  			      &crtc_state->infoframes.hdmi);
>> >  }
>> >  
>> > -static bool hdmi_sink_is_deep_color(const struct drm_connector_state *conn_state)
>> > -{
>> > -	struct drm_connector *connector = conn_state->connector;
>> > -
>> > -	/*
>> > -	 * HDMI cloning is only supported on g4x which doesn't
>> > -	 * support deep color or GCP infoframes anyway so no
>> > -	 * need to worry about multiple HDMI sinks here.
>> > -	 */
>> > -
>> > -	return connector->display_info.bpc > 8;
>> > -}
>> > -
>> >  /*
>> >   * Determine if default_phase=1 can be indicated in the GCP infoframe.
>> >   *
>> > @@ -973,8 +960,8 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
>> >  	crtc_state->infoframes.enable |=
>> >  		intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>> >  
>> > -	/* Indicate color depth whenever the sink supports deep color */
>> > -	if (hdmi_sink_is_deep_color(conn_state))
>> > +	/* Indicate color indication for deep color mode */
>> > +	if (crtc_state->pipe_bpp > 24)
>> >  		crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>> >  
>> >  	/* Enable default_phase whenever the display mode is suitably aligned */
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center

Patch

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index e1005d7b75fd..991eb362ef4f 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -856,19 +856,6 @@  static void g4x_set_infoframes(struct intel_encoder *encoder,
 			      &crtc_state->infoframes.hdmi);
 }
 
-static bool hdmi_sink_is_deep_color(const struct drm_connector_state *conn_state)
-{
-	struct drm_connector *connector = conn_state->connector;
-
-	/*
-	 * HDMI cloning is only supported on g4x which doesn't
-	 * support deep color or GCP infoframes anyway so no
-	 * need to worry about multiple HDMI sinks here.
-	 */
-
-	return connector->display_info.bpc > 8;
-}
-
 /*
  * Determine if default_phase=1 can be indicated in the GCP infoframe.
  *
@@ -973,8 +960,8 @@  static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
 	crtc_state->infoframes.enable |=
 		intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
 
-	/* Indicate color depth whenever the sink supports deep color */
-	if (hdmi_sink_is_deep_color(conn_state))
+	/* Indicate color indication for deep color mode */
+	if (crtc_state->pipe_bpp > 24)
 		crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
 
 	/* Enable default_phase whenever the display mode is suitably aligned */