drivers: thermal: processor_thermal: Downgrade error message
diff mbox series

Message ID 20190430034213.40028-1-srinivas.pandruvada@linux.intel.com
State Superseded
Delegated to: Zhang Rui
Headers show
Series
  • drivers: thermal: processor_thermal: Downgrade error message
Related show

Commit Message

Srinivas Pandruvada April 30, 2019, 3:42 a.m. UTC
Downgrade "Unsupported event" message from dev_err to dev_dbg. Otherwise it
floods with this message one some platforms.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 .../thermal/intel/int340x_thermal/processor_thermal_device.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang Rui May 6, 2019, 12:50 p.m. UTC | #1
On 一, 2019-04-29 at 20:42 -0700, Srinivas Pandruvada wrote:
> Downgrade "Unsupported event" message from dev_err to dev_dbg.
> Otherwise it
> floods with this message one some platforms.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.c
> om>
> ---
>  .../thermal/intel/int340x_thermal/processor_thermal_device.c    | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> index 4b206b594825..436c256f111d 100644
> ---
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> +++
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> @@ -275,7 +275,7 @@ static void proc_thermal_notify(acpi_handle
> handle, u32 event, void *data)
>  				THERMAL_DEVICE_POWER_CAPABILITY_CHAN
> GED);
>  		break;
>  	default:
> -		dev_err(proc_priv->dev, "Unsupported event
> [0x%x]\n", event);
> +		dev_dbg(proc_priv->dev, "Unsupported event
> [0x%x]\n", event);
>  		break;
>  	}
>  }

a similar patch has been applied, the only difference is that I'm using
dev_notice instead.
https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git/commit
/?h=next&id=3c7110fab805766450c5d2eac1c994d4c8c230d3

thanks,
rui
Srinivas Pandruvada May 6, 2019, 3:09 p.m. UTC | #2
On Mon, 2019-05-06 at 20:50 +0800, Zhang Rui wrote:
> On 一, 2019-04-29 at 20:42 -0700, Srinivas Pandruvada wrote:
> > Downgrade "Unsupported event" message from dev_err to dev_dbg.
> > Otherwise it
> > floods with this message one some platforms.
> > 
> > Signed-off-by: Srinivas Pandruvada <
> > srinivas.pandruvada@linux.intel.c
> > om>
> > ---
> >  .../thermal/intel/int340x_thermal/processor_thermal_device.c    |
> > 2
> > +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > index 4b206b594825..436c256f111d 100644
> > ---
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > +++
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > @@ -275,7 +275,7 @@ static void proc_thermal_notify(acpi_handle
> > handle, u32 event, void *data)
> >  				THERMAL_DEVICE_POWER_CAPABILITY_CHAN
> > GED);
> >  		break;
> >  	default:
> > -		dev_err(proc_priv->dev, "Unsupported event
> > [0x%x]\n", event);
> > +		dev_dbg(proc_priv->dev, "Unsupported event
> > [0x%x]\n", event);
> >  		break;
> >  	}
> >  }
> 
> a similar patch has been applied, the only difference is that I'm
> using
> dev_notice instead.
> 
https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git/commit
> /?h=next&id=3c7110fab805766450c5d2eac1c994d4c8c230d3

I think dev_notice still appear with non debug log level (!=7), so
dmesg from most distro will still have this print, which will concern
some users unnecessarily, which we can't do anything.

Thanks,
Srinivas

> 
> thanks,
> rui

Patch
diff mbox series

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
index 4b206b594825..436c256f111d 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
@@ -275,7 +275,7 @@  static void proc_thermal_notify(acpi_handle handle, u32 event, void *data)
 				THERMAL_DEVICE_POWER_CAPABILITY_CHANGED);
 		break;
 	default:
-		dev_err(proc_priv->dev, "Unsupported event [0x%x]\n", event);
+		dev_dbg(proc_priv->dev, "Unsupported event [0x%x]\n", event);
 		break;
 	}
 }