| Message ID | 20190501155745.21806-3-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: code cleanup | expand |
On Wed, May 01, 2019 at 10:57:25AM -0500, Pierre-Louis Bossart wrote: > No C++ comments in .h files That's not really the issue here. > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/soundwire/bus.h | 4 ++-- > drivers/soundwire/cadence_master.h | 4 ++-- > drivers/soundwire/intel.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > index c77de05b8100..2f8436584e7f 100644 > --- a/drivers/soundwire/bus.h > +++ b/drivers/soundwire/bus.h > @@ -1,5 +1,5 @@ > -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > -// Copyright(c) 2015-17 Intel Corporation. > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* Copyright(c) 2015-17 Intel Corporation. */ The first line is fine to change, as that was the requirement (although I think it has now been fixed), the second line is just taste, whatever you want, it's not a requirement. But I really don't care, it's not my code :) thanks, greg k-h
On 01-05-19, 10:57, Pierre-Louis Bossart wrote: > No C++ comments in .h files > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/soundwire/bus.h | 4 ++-- > drivers/soundwire/cadence_master.h | 4 ++-- > drivers/soundwire/intel.h | 4 ++-- As I said previously this touches subsystem header as well as driver headers which is not ideal. Also I agree with Greg, SPDX line format is a requirement but not the copyright one but that is not a deal breaker here. > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > index c77de05b8100..2f8436584e7f 100644 > --- a/drivers/soundwire/bus.h > +++ b/drivers/soundwire/bus.h > @@ -1,5 +1,5 @@ > -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > -// Copyright(c) 2015-17 Intel Corporation. > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* Copyright(c) 2015-17 Intel Corporation. */ > > #ifndef __SDW_BUS_H > #define __SDW_BUS_H > diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h > index eb902b19c5a4..75f7412cfbbd 100644 > --- a/drivers/soundwire/cadence_master.h > +++ b/drivers/soundwire/cadence_master.h > @@ -1,5 +1,5 @@ > -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > -// Copyright(c) 2015-17 Intel Corporation. > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* Copyright(c) 2015-17 Intel Corporation. */ > #include <sound/soc.h> > > #ifndef __SDW_CADENCE_H > diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h > index c1a5bac6212e..71050e5f643d 100644 > --- a/drivers/soundwire/intel.h > +++ b/drivers/soundwire/intel.h > @@ -1,5 +1,5 @@ > -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > -// Copyright(c) 2015-17 Intel Corporation. > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* Copyright(c) 2015-17 Intel Corporation. */ > > #ifndef __SDW_INTEL_LOCAL_H > #define __SDW_INTEL_LOCAL_H > -- > 2.17.1
On Thu, May 02, 2019 at 10:46:49AM +0530, Vinod Koul wrote: > On 01-05-19, 10:57, Pierre-Louis Bossart wrote: > > No C++ comments in .h files > > > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > --- > > drivers/soundwire/bus.h | 4 ++-- > > drivers/soundwire/cadence_master.h | 4 ++-- > > drivers/soundwire/intel.h | 4 ++-- > > As I said previously this touches subsystem header as well as driver > headers which is not ideal. What? Who knows that? Who cares? This is doing "one logical thing" to all of the needed files. Your split of "this is a driver" vs. "this is a subsystem" split is _VERY_ arbritary. That's just too picky and assumes a subsystem-internal-knowledge much deeper than anyone submitting a normal cleanup patch would ever know. I think you have swung too far to the "too picky" side, you might want to dial it back. thanks, greg k-h
On 02-05-19, 08:31, Greg KH wrote: > On Thu, May 02, 2019 at 10:46:49AM +0530, Vinod Koul wrote: > > On 01-05-19, 10:57, Pierre-Louis Bossart wrote: > > > No C++ comments in .h files > > > > > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > > --- > > > drivers/soundwire/bus.h | 4 ++-- > > > drivers/soundwire/cadence_master.h | 4 ++-- > > > drivers/soundwire/intel.h | 4 ++-- > > > > As I said previously this touches subsystem header as well as driver > > headers which is not ideal. > > What? Who knows that? Who cares? Well at least Pierre knows that very well :) He is designate Reviewer of this subsystem. > This is doing "one logical thing" to all of the needed files. Your > split of "this is a driver" vs. "this is a subsystem" split is _VERY_ > arbritary. > > That's just too picky and assumes a subsystem-internal-knowledge much > deeper than anyone submitting a normal cleanup patch would ever know. Sure I do agree that this assumes internal knowledge but the contributor knows the subsystem extremely well and he knows the different parts. For drive by contributor I agree things would be not that picky :) Even considering the patch series, some split was even file based and in this case not done. All I ask is for consistency in the series proposed. > I think you have swung too far to the "too picky" side, you might want > to dial it back. Sure given that this is code cleanup I will split them up and push. Shouldn't take much of my time. Thanks for the advise.
diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h index c77de05b8100..2f8436584e7f 100644 --- a/drivers/soundwire/bus.h +++ b/drivers/soundwire/bus.h @@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #ifndef __SDW_BUS_H #define __SDW_BUS_H diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h index eb902b19c5a4..75f7412cfbbd 100644 --- a/drivers/soundwire/cadence_master.h +++ b/drivers/soundwire/cadence_master.h @@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #include <sound/soc.h> #ifndef __SDW_CADENCE_H diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h index c1a5bac6212e..71050e5f643d 100644 --- a/drivers/soundwire/intel.h +++ b/drivers/soundwire/intel.h @@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */ #ifndef __SDW_INTEL_LOCAL_H #define __SDW_INTEL_LOCAL_H