| Message ID | 1556808723-226478-2-git-send-email-imammedo@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests: acpi: add UEFI (ARM) testing support | expand |
On Sun, 12 May 2019 14:19:08 -0400 "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Thu, May 02, 2019 at 04:51:49PM +0200, Igor Mammedov wrote: > > so name would reflect what the function does > > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> > > --- > > v4: > > * make it as the first patch in series > > --- > > > FYI this trips up git am. > Don't do two --- please: just one is enough, > second is not needed. strange, git am works for me just fine. I've always formated par patch comments this way and I think it's rather common approach on the list. What version of git do you use? Anyways, shall I rebase and resend series? (it doesn't apply to master anymore) > [...]
On Mon, 13 May 2019 11:04:40 +0200 Igor Mammedov <imammedo@redhat.com> wrote: > On Sun, 12 May 2019 14:19:08 -0400 > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Thu, May 02, 2019 at 04:51:49PM +0200, Igor Mammedov wrote: > > > so name would reflect what the function does > > > > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > > Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> > > > --- > > > v4: > > > * make it as the first patch in series > > > --- > > > > > > FYI this trips up git am. > > Don't do two --- please: just one is enough, > > second is not needed. > > strange, git am works for me just fine. > I've always formated par patch comments this way and I think it's rather > common approach on the list. > > What version of git do you use? > [...] > (it doesn't apply to master anymore) never mind, it applies just fine (I've missed one patch when applying) > > > > [...] > >
On Thu, 16 May 2019 08:20:15 -0400 "Michael S. Tsirkin" <mst@redhat.com> wrote: > From: Igor Mammedov <imammedo@redhat.com> > > so name would reflect what the function does > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> > Message-Id: <1556808723-226478-2-git-send-email-imammedo@redhat.com> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Michael, My mail client doesn't do proper threading since something wrong with Message-Ids in this pull req, for example this patch in V4 I've posted has message id Message-Id: <1556808723-226478-2-git-send-email-imammedo@redhat.com> and the same patch (modified with your SoB) here also has the same Message-Id Message-ID: <1556808723-226478-2-git-send-email-imammedo@redhat.com> which to me look broken > --- > tests/acpi-utils.h | 2 +- > tests/acpi-utils.c | 2 +- > tests/bios-tables-test.c | 2 +- > tests/vmgenid-test.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h > index ef388bbf12..4cd5553586 100644 > --- a/tests/acpi-utils.h > +++ b/tests/acpi-utils.h > @@ -47,7 +47,7 @@ typedef struct { > uint8_t acpi_calc_checksum(const uint8_t *data, int len); > uint32_t acpi_find_rsdp_address(QTestState *qts); > uint64_t acpi_get_xsdt_address(uint8_t *rsdp_table); > -void acpi_parse_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table); > +void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table); > void acpi_fetch_table(QTestState *qts, uint8_t **aml, uint32_t *aml_len, > const uint8_t *addr_ptr, const char *sig, > bool verify_checksum); > diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c > index cc33b460ab..633d8f513d 100644 > --- a/tests/acpi-utils.c > +++ b/tests/acpi-utils.c > @@ -63,7 +63,7 @@ uint64_t acpi_get_xsdt_address(uint8_t *rsdp_table) > return le64_to_cpu(xsdt_physical_address); > } > > -void acpi_parse_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table) > +void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table) > { > uint8_t revision; > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index a506dcbb29..6a678bf761 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -89,7 +89,7 @@ static void test_acpi_rsdp_table(test_data *data) > uint8_t *rsdp_table = data->rsdp_table, revision; > uint32_t addr = data->rsdp_addr; > > - acpi_parse_rsdp_table(data->qts, addr, rsdp_table); > + acpi_fetch_rsdp_table(data->qts, addr, rsdp_table); > revision = rsdp_table[15 /* Revision offset */]; > > switch (revision) { > diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c > index ae38ee5ac0..f400184268 100644 > --- a/tests/vmgenid-test.c > +++ b/tests/vmgenid-test.c > @@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(QTestState *qts) > g_assert_cmphex(rsdp_offset, <, RSDP_ADDR_INVALID); > > > - acpi_parse_rsdp_table(qts, rsdp_offset, rsdp_table); > + acpi_fetch_rsdp_table(qts, rsdp_offset, rsdp_table); > acpi_fetch_table(qts, &rsdt, &rsdt_len, &rsdp_table[16 /* RsdtAddress */], > "RSDT", true); >
On 5/17/19 9:55 AM, Igor Mammedov wrote: > On Thu, 16 May 2019 08:20:15 -0400 > "Michael S. Tsirkin" <mst@redhat.com> wrote: > >> From: Igor Mammedov <imammedo@redhat.com> >> >> so name would reflect what the function does >> >> Signed-off-by: Igor Mammedov <imammedo@redhat.com> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> >> Message-Id: <1556808723-226478-2-git-send-email-imammedo@redhat.com> >> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > Michael, > My mail client doesn't do proper threading since something wrong with Message-Ids in this pull req, > > for example this patch in V4 I've posted has message id > Message-Id: <1556808723-226478-2-git-send-email-imammedo@redhat.com> > and the same patch (modified with your SoB) here also has the same Message-Id > Message-ID: <1556808723-226478-2-git-send-email-imammedo@redhat.com> > which to me look broken Same happens to me (Thunderbird).
diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h index ef388bb..4cd5553 100644 --- a/tests/acpi-utils.h +++ b/tests/acpi-utils.h @@ -47,7 +47,7 @@ typedef struct { uint8_t acpi_calc_checksum(const uint8_t *data, int len); uint32_t acpi_find_rsdp_address(QTestState *qts); uint64_t acpi_get_xsdt_address(uint8_t *rsdp_table); -void acpi_parse_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table); +void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table); void acpi_fetch_table(QTestState *qts, uint8_t **aml, uint32_t *aml_len, const uint8_t *addr_ptr, const char *sig, bool verify_checksum); diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c index cc33b46..633d8f5 100644 --- a/tests/acpi-utils.c +++ b/tests/acpi-utils.c @@ -63,7 +63,7 @@ uint64_t acpi_get_xsdt_address(uint8_t *rsdp_table) return le64_to_cpu(xsdt_physical_address); } -void acpi_parse_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table) +void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table) { uint8_t revision; diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index a506dcb..6a678bf 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -89,7 +89,7 @@ static void test_acpi_rsdp_table(test_data *data) uint8_t *rsdp_table = data->rsdp_table, revision; uint32_t addr = data->rsdp_addr; - acpi_parse_rsdp_table(data->qts, addr, rsdp_table); + acpi_fetch_rsdp_table(data->qts, addr, rsdp_table); revision = rsdp_table[15 /* Revision offset */]; switch (revision) { diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c index ae38ee5..f400184 100644 --- a/tests/vmgenid-test.c +++ b/tests/vmgenid-test.c @@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(QTestState *qts) g_assert_cmphex(rsdp_offset, <, RSDP_ADDR_INVALID); - acpi_parse_rsdp_table(qts, rsdp_offset, rsdp_table); + acpi_fetch_rsdp_table(qts, rsdp_offset, rsdp_table); acpi_fetch_table(qts, &rsdt, &rsdt_len, &rsdp_table[16 /* RsdtAddress */], "RSDT", true);