[18/19] rev-parseopt: convert --skip

Message ID	20190508111249.15262-19-pclouds@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> To: git@vger.kernel.org Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> Subject: [PATCH 18/19] rev-parseopt: convert --skip Date: Wed, 8 May 2019 18:12:48 +0700 Message-Id: <20190508111249.15262-19-pclouds@gmail.com> In-Reply-To: <20190508111249.15262-1-pclouds@gmail.com> References: <20190508111249.15262-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Convert revision.c to parseopt part 1/4 \| expand [00/19] Convert revision.c to parseopt part 1/4 [01/19] revision.h: avoid bit fields in struct rev_info [02/19] revision.h: move repo field down [03/19] revision.c: prepare to convert handle_revision_pseudo_opt() [04/19] rev-parseopt: convert --all [05/19] rev-parseopt: convert --branches [06/19] rev-parseopt: convert --bisect [07/19] rev-parseopt: convert --tags [08/19] rev-parseopt: convert --remotes [09/19] rev-parseopt: convert --glob [10/19] rev-parseopt: convert --exclude [11/19] rev-parseopt: convert --reflog [12/19] rev-parseopt: convert --indexed-objects [13/19] rev-parseopt: convert --not [14/19] rev-parseopt: convert --no-walk and --do-walk [15/19] rev-parseopt: convert --single-worktree [16/19] rev-parseopt: prepare to convert handle_revision_opt() [17/19] rev-parseopt: convert --max-count [18/19] rev-parseopt: convert --skip [19/19] rev-parseopt: convert --min-age and --max-age

Message ID

20190508111249.15262-19-pclouds@gmail.com (mailing list archive)

State

New, archived

Headers

From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
Subject: [PATCH 18/19] rev-parseopt: convert --skip
Date: Wed,  8 May 2019 18:12:48 +0700
Message-Id: <20190508111249.15262-19-pclouds@gmail.com>
In-Reply-To: <20190508111249.15262-1-pclouds@gmail.com>
References: <20190508111249.15262-1-pclouds@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Convert revision.c to parseopt part 1/4 | expand

Commit Message

Duy Nguyen May 8, 2019, 11:12 a.m. UTC

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 revision.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/revision.c b/revision.c
index c53347d362..42d466cd08 100644
--- a/revision.c
+++ b/revision.c
@@ -1996,6 +1996,9 @@  static void make_rev_options(struct rev_info *revs)
 		OPT_REV('n', "max-count", N_("<n>"),
 			N_("limit the number of commis to stdout"),
 			rev_opt_max_count),
+		OPT_INTEGER_F(0, "skip", &revs->skip_count,
+			      N_("skip a number of commits before starting to show"),
+			      PARSE_OPT_NONEG),
 		OPT_END(),
 	};
 	revs->options = parse_options_concat(options, revs->diffopt.parseopts);
@@ -2036,10 +2039,7 @@  static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
 	if (argc)
 		return argc;
 
-	if ((argcount = parse_long_opt("skip", argv, &optarg))) {
-		revs->skip_count = atoi(optarg);
-		return argcount;
-	} else if ((*arg == '-') && isdigit(arg[1])) {
+	if ((*arg == '-') && isdigit(arg[1])) {
 		/* accept -<digit>, like traditional "head" */
 		if (strtol_i(arg + 1, 10, &revs->max_count) < 0 ||
 		    revs->max_count < 0)

[18/19] rev-parseopt: convert --skip

Commit Message

Patch