[Bug,109345] drm-next-2018-12-14 -Linux PPC
diff mbox series

Message ID bug-109345-502-WH9XspBdzk@http.bugs.freedesktop.org/
State New
Headers show
Series
  • [Bug,109345] drm-next-2018-12-14 -Linux PPC
Related show

Commit Message

bugzilla-daemon@freedesktop.org May 9, 2019, 11:52 a.m. UTC
https://bugs.freedesktop.org/show_bug.cgi?id=109345

--- Comment #39 from Christian Zigotzky <chzigotzky@xenosoft.de> ---
Hi All,

Allan has successfully tested the eleventh test kernel.

He wrote:

Christian
DRM11 boots to Firepro.

ace

------

We have a result!

git bisect good

The following commit is responsible for the issue:

3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa is the first bad commit
commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa
Author: Aaron Ma <aaron.ma@canonical.com>
Date:   Sat Sep 1 02:20:00 2018 +0800

    vgaarb: Keep adding VGA device in queue

    If failed to find the deivice owning the boot framebuffer,
    try to use the first VGA device instead of the last one.

    Usually the 1st device is integrated GPU who owns the boot framebuffer.

    Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link:
https://patchwork.freedesktop.org/patch/msgid/1535739600-8842-2-git-send-email-aaron.ma@canonical.com

:040000 040000 2d69570b87946ba42095609c945f04de9ad24ef7
3d86752f71500726f20d7d503128119f9b249175 M   drivers

------

I undid these changes in the file 'drivers/gpu/vga/vgaarb.c' and created
another test kernel today.

Download: http://www.xenosoft.de/linux-image-5.2-alpha2-X1000_X5000.tar.gz

You can undo the commit with the following patch:


------

@Allan (acefnq/ace)
Please test it.

Thanks,
Christian

Patch
diff mbox series

diff -rupN a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
--- a/drivers/gpu/vga/vgaarb.c    2019-05-09 07:56:27.595746473 +0200
+++ b/drivers/gpu/vga/vgaarb.c    2019-05-09 08:00:06.352660688 +0200
@@ -725,7 +725,7 @@  static bool vga_arbiter_add_pci_device(s
     vga_arbiter_check_bridge_sharing(vgadev);

     /* Add to the list */
-    list_add_tail(&vgadev->list, &vga_list);
+    list_add(&vgadev->list, &vga_list);
     vga_count++;
     vgaarb_info(&pdev->dev, "VGA device added: decodes=%s,owns=%s,locks=%s\n",
         vga_iostate_to_str(vgadev->decodes),