| Message ID | 1557827010-24239-2-git-send-email-swati2.sharma@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: adding state checker for gamma lut values | expand |
On Tue, May 14, 2019 at 03:13:19PM +0530, Swati Sharma wrote: > In this patch, a vfunc read_luts() is introduced to create a hw lut > i.e. lut having values read from gamma/degamma registers which will > later be used to compare with sw lut to validate gamma/degamma lut values. > > v3: -Rebase > v4: -Renamed intel_get_color_config to intel_color_get_config [Jani] > -Wrapped get_color_config() [Jani] > v5: -Renamed intel_color_get_config() to intel_color_read_luts() > -Renamed get_color_config to read_luts > v6: -Renamed intel_color_read_luts() back to intel_color_get_config() > [Jani and Ville] > > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/intel_color.c | 8 ++++++++ > drivers/gpu/drm/i915/intel_color.h | 1 + > 3 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index d025780..6343e70 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -343,6 +343,7 @@ struct drm_i915_display_funcs { > * involved with the same commit. > */ > void (*load_luts)(const struct intel_crtc_state *crtc_state); > + void (*read_luts)(struct intel_crtc_state *crtc_state); I think Jani wanted the entire vfunc renamed back. > }; > > struct intel_csr { > diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c > index 962db12..50b98ee 100644 > --- a/drivers/gpu/drm/i915/intel_color.c > +++ b/drivers/gpu/drm/i915/intel_color.c > @@ -879,6 +879,14 @@ int intel_color_check(struct intel_crtc_state *crtc_state) > return dev_priv->display.color_check(crtc_state); > } > > +void intel_color_get_config(struct intel_crtc_state *crtc_state) > +{ > + struct drm_i915_private *dev_priv = to_i915(crtc_state->base.crtc->dev); > + > + if (dev_priv->display.read_luts) > + dev_priv->display.read_luts(crtc_state); > +} > + > static bool need_plane_update(struct intel_plane *plane, > const struct intel_crtc_state *crtc_state) > { > diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h > index b8a3ce6..057e8ac 100644 > --- a/drivers/gpu/drm/i915/intel_color.h > +++ b/drivers/gpu/drm/i915/intel_color.h > @@ -13,5 +13,6 @@ > int intel_color_check(struct intel_crtc_state *crtc_state); > void intel_color_commit(const struct intel_crtc_state *crtc_state); > void intel_color_load_luts(const struct intel_crtc_state *crtc_state); > +void intel_color_get_config(struct intel_crtc_state *crtc_state); > > #endif /* __INTEL_COLOR_H__ */ > -- > 1.9.1
On Tue, 14 May 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Tue, May 14, 2019 at 03:13:19PM +0530, Swati Sharma wrote: >> In this patch, a vfunc read_luts() is introduced to create a hw lut >> i.e. lut having values read from gamma/degamma registers which will >> later be used to compare with sw lut to validate gamma/degamma lut values. >> >> v3: -Rebase >> v4: -Renamed intel_get_color_config to intel_color_get_config [Jani] >> -Wrapped get_color_config() [Jani] >> v5: -Renamed intel_color_get_config() to intel_color_read_luts() >> -Renamed get_color_config to read_luts >> v6: -Renamed intel_color_read_luts() back to intel_color_get_config() >> [Jani and Ville] >> >> Signed-off-by: Swati Sharma <swati2.sharma@intel.com> >> --- >> drivers/gpu/drm/i915/i915_drv.h | 1 + >> drivers/gpu/drm/i915/intel_color.c | 8 ++++++++ >> drivers/gpu/drm/i915/intel_color.h | 1 + >> 3 files changed, 10 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >> index d025780..6343e70 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -343,6 +343,7 @@ struct drm_i915_display_funcs { >> * involved with the same commit. >> */ >> void (*load_luts)(const struct intel_crtc_state *crtc_state); >> + void (*read_luts)(struct intel_crtc_state *crtc_state); > > I think Jani wanted the entire vfunc renamed back. *shrug* not so important as the main entry point below. BR, Jani, > >> }; >> >> struct intel_csr { >> diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c >> index 962db12..50b98ee 100644 >> --- a/drivers/gpu/drm/i915/intel_color.c >> +++ b/drivers/gpu/drm/i915/intel_color.c >> @@ -879,6 +879,14 @@ int intel_color_check(struct intel_crtc_state *crtc_state) >> return dev_priv->display.color_check(crtc_state); >> } >> >> +void intel_color_get_config(struct intel_crtc_state *crtc_state) >> +{ >> + struct drm_i915_private *dev_priv = to_i915(crtc_state->base.crtc->dev); >> + >> + if (dev_priv->display.read_luts) >> + dev_priv->display.read_luts(crtc_state); >> +} >> + >> static bool need_plane_update(struct intel_plane *plane, >> const struct intel_crtc_state *crtc_state) >> { >> diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h >> index b8a3ce6..057e8ac 100644 >> --- a/drivers/gpu/drm/i915/intel_color.h >> +++ b/drivers/gpu/drm/i915/intel_color.h >> @@ -13,5 +13,6 @@ >> int intel_color_check(struct intel_crtc_state *crtc_state); >> void intel_color_commit(const struct intel_crtc_state *crtc_state); >> void intel_color_load_luts(const struct intel_crtc_state *crtc_state); >> +void intel_color_get_config(struct intel_crtc_state *crtc_state); >> >> #endif /* __INTEL_COLOR_H__ */ >> -- >> 1.9.1
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index d025780..6343e70 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -343,6 +343,7 @@ struct drm_i915_display_funcs { * involved with the same commit. */ void (*load_luts)(const struct intel_crtc_state *crtc_state); + void (*read_luts)(struct intel_crtc_state *crtc_state); }; struct intel_csr { diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 962db12..50b98ee 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++ b/drivers/gpu/drm/i915/intel_color.c @@ -879,6 +879,14 @@ int intel_color_check(struct intel_crtc_state *crtc_state) return dev_priv->display.color_check(crtc_state); } +void intel_color_get_config(struct intel_crtc_state *crtc_state) +{ + struct drm_i915_private *dev_priv = to_i915(crtc_state->base.crtc->dev); + + if (dev_priv->display.read_luts) + dev_priv->display.read_luts(crtc_state); +} + static bool need_plane_update(struct intel_plane *plane, const struct intel_crtc_state *crtc_state) { diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h index b8a3ce6..057e8ac 100644 --- a/drivers/gpu/drm/i915/intel_color.h +++ b/drivers/gpu/drm/i915/intel_color.h @@ -13,5 +13,6 @@ int intel_color_check(struct intel_crtc_state *crtc_state); void intel_color_commit(const struct intel_crtc_state *crtc_state); void intel_color_load_luts(const struct intel_crtc_state *crtc_state); +void intel_color_get_config(struct intel_crtc_state *crtc_state); #endif /* __INTEL_COLOR_H__ */
In this patch, a vfunc read_luts() is introduced to create a hw lut i.e. lut having values read from gamma/degamma registers which will later be used to compare with sw lut to validate gamma/degamma lut values. v3: -Rebase v4: -Renamed intel_get_color_config to intel_color_get_config [Jani] -Wrapped get_color_config() [Jani] v5: -Renamed intel_color_get_config() to intel_color_read_luts() -Renamed get_color_config to read_luts v6: -Renamed intel_color_read_luts() back to intel_color_get_config() [Jani and Ville] Signed-off-by: Swati Sharma <swati2.sharma@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_color.c | 8 ++++++++ drivers/gpu/drm/i915/intel_color.h | 1 + 3 files changed, 10 insertions(+)