CI: Revert "net/sch_generic: Shut up noise"

Commit Message

Daniel Vetter May 16, 2019, 6:45 a.m. UTC

This reverts commit a9f840bdd2fd4cb07a669f1c3112b804218b4aba.

But instead tune it down to an error, hopefully that way we can
perhaps capture something ...

Cc: Martin Peres <[e-mail]>
---
 net/sched/sch_generic.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Daniel Vetter May 17, 2019, 6:47 a.m. UTC | #1

On Thu, May 16, 2019 at 08:48:53AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: CI: Revert "net/sch_generic: Shut up noise"
> URL   : https://patchwork.freedesktop.org/series/60699/
> State : success

Hm no boom at all, I'll try the full revert and see what happens. Maybe we
hit a few more igt@aborted ...
-Daniel

> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6089_full -> Patchwork_13024_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_13024_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_isolation@vcs1-s3:
>     - shard-kbl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-kbl3/igt@[e-mail]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-kbl7/igt@[e-mail]
> 
>   * igt@gem_tiled_swapping@non-threaded:
>     - shard-hsw:          [PASS][3] -> [FAIL][4] ([fdo#108686])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-hsw7/igt@[e-mail]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-hsw5/igt@[e-mail]
> 
>   * igt@gem_workarounds@suspend-resume-context:
>     - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +4 similar issues
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-apl7/igt@[e-mail]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-apl7/igt@[e-mail]
> 
>   * igt@i915_pm_rpm@dpms-lpsp:
>     - shard-skl:          [PASS][7] -> [INCOMPLETE][8] ([fdo#107807])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl10/igt@[e-mail]
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-skl10/igt@[e-mail]
> 
>   * igt@kms_flip_tiling@flip-x-tiled:
>     - shard-iclb:         [PASS][9] -> [FAIL][10] ([fdo#108303])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb7/igt@[e-mail]
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb4/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>     - shard-iclb:         [PASS][11] -> [FAIL][12] ([fdo#103167]) +5 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb2/igt@[e-mail]
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb6/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_sprite_plane_move:
>     - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#109441]) +3 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          [PASS][15] -> [FAIL][16] ([fdo#99912])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-kbl2/igt@[e-mail]
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-kbl2/igt@[e-mail]
> 
>   * igt@perf_pmu@rc6:
>     - shard-kbl:          [PASS][17] -> [SKIP][18] ([fdo#109271])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-kbl6/igt@[e-mail]
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-kbl7/igt@[e-mail]
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_isolation@bcs0-s3:
>     - shard-kbl:          [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20]
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-kbl7/igt@[e-mail]
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-kbl3/igt@[e-mail]
> 
>   * igt@gem_tiled_swapping@non-threaded:
>     - shard-iclb:         [FAIL][21] ([fdo#108686]) -> [PASS][22]
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb5/igt@[e-mail]
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb8/igt@[e-mail]
> 
>   * igt@i915_pm_rpm@basic-rte:
>     - shard-skl:          [INCOMPLETE][23] ([fdo#107807]) -> [PASS][24] +1 similar issue
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl3/igt@[e-mail]
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-skl10/igt@[e-mail]
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] +4 similar issues
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-apl6/igt@[e-mail]
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-apl8/igt@[e-mail]
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
>     - shard-iclb:         [FAIL][27] ([fdo#103167]) -> [PASS][28] +4 similar issues
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb2/igt@[e-mail]
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb4/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
>     - shard-skl:          [FAIL][29] ([fdo#108145]) -> [PASS][30]
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl6/igt@[e-mail]
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-skl2/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          [FAIL][31] ([fdo#108145] / [fdo#110403]) -> [PASS][32]
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl5/igt@[e-mail]
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-skl7/igt@[e-mail]
> 
>   * igt@kms_plane_lowres@pipe-a-tiling-y:
>     - shard-iclb:         [FAIL][33] ([fdo#103166]) -> [PASS][34]
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb7/igt@[e-mail]
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb4/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_suspend:
>     - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +1 similar issue
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb8/igt@kms_psr@psr2_suspend.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb2/igt@kms_psr@psr2_suspend.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_mmap_gtt@forked-big-copy-odd:
>     - shard-iclb:         [INCOMPLETE][37] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][38] ([fdo#109673])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb1/igt@[e-mail]
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/shard-iclb5/igt@[e-mail]
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
>   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_6089 -> Patchwork_13024
> 
>   CI_DRM_6089: c7a46913f77868d15ade90846526d7e4cb910637 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4991: 61dd8eec659062eac67823ccd9f2189c3aa36201 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_13024: 8fbf6ed5c78a4698353e85b9084616feacd6bea2 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13024/

Patch

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index cf96149d7b5e..5b42dad94665 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -456,13 +456,8 @@  static void dev_watchdog(struct timer_list *t)
 				}
 			}
 
-			/* The noise is pissing off our CI and upstream doesn't
-			 * move on the bug report:
-			 *
-			 * https://bugzilla.kernel.org/show_bug.cgi?id=196399
-			 */
-			if (some_queue_timedout && 0) {
-				WARN_ONCE(1, KERN_INFO "NETDEV WATCHDOG: %s (%s): transmit queue %u timed out\n",
+			if (some_queue_timedout) {
+				pr_err("NETDEV WATCHDOG: %s (%s): transmit queue %u timed out\n",
 				       dev->name, netdev_drivername(dev), i);
 				dev->netdev_ops->ndo_tx_timeout(dev);
 			}