staging: iio: ad9832: Add device tree support
diff mbox series

Message ID 20190518204825.4kh5qkqo2e5q2se6@smtp.gmail.com
State New
Headers show
Series
  • staging: iio: ad9832: Add device tree support
Related show

Commit Message

João Seckler May 18, 2019, 8:48 p.m. UTC
Add a of_device_id struct variable and subsequent call to
MODULE_DEVICE_TABLE macro to support device tree.

Signed-off-by: João Seckler <joaoseckler@gmail.com>
Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
Co-developed-by: Anderson Reis  <andersonreisrosa@gmail.com>
Signed-off-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
Co-developed-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
---
 drivers/staging/iio/frequency/ad9832.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jonathan Cameron May 19, 2019, 11:19 a.m. UTC | #1
On Sat, 18 May 2019 17:48:25 -0300
João Seckler <joaoseckler@gmail.com> wrote:

> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
> 
> Signed-off-by: João Seckler <joaoseckler@gmail.com>
> Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
> Co-developed-by: Anderson Reis  <andersonreisrosa@gmail.com>
> Signed-off-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
> Co-developed-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
Hi All,

Missing the setting of the relevant entry in the spi_driver structure.
Otherwise looks fine,

Thanks,

Jonathan
> ---
>  drivers/staging/iio/frequency/ad9832.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index 74308a2e72db..51e97c74c6b2 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -451,6 +451,13 @@ static int ad9832_remove(struct spi_device *spi)
>  	return 0;
>  }
>  
> +static const struct of_device_id ad9832_of_match[] = {
> +	{ .compatible = "adi,ad9832", },
> +	{ .compatible = "adi,ad9835", },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, ad9832_of_match);
> +
>  static const struct spi_device_id ad9832_id[] = {
>  	{"ad9832", 0},
>  	{"ad9835", 0},
Alexandru Ardelean May 20, 2019, 8:49 a.m. UTC | #2
On Sun, May 19, 2019 at 8:17 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 17:48:25 -0300
> João Seckler <joaoseckler@gmail.com> wrote:
>
> > Add a of_device_id struct variable and subsequent call to
> > MODULE_DEVICE_TABLE macro to support device tree.
> >
> > Signed-off-by: João Seckler <joaoseckler@gmail.com>
> > Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
> > Co-developed-by: Anderson Reis  <andersonreisrosa@gmail.com>
> > Signed-off-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
> > Co-developed-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
> Hi All,
>
> Missing the setting of the relevant entry in the spi_driver structure.
> Otherwise looks fine,
>
> Thanks,
>
> Jonathan
> > ---
> >  drivers/staging/iio/frequency/ad9832.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index 74308a2e72db..51e97c74c6b2 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -451,6 +451,13 @@ static int ad9832_remove(struct spi_device *spi)
> >       return 0;
> >  }
> >
> > +static const struct of_device_id ad9832_of_match[] = {
> > +     { .compatible = "adi,ad9832", },
> > +     { .compatible = "adi,ad9835", },
> > +     { /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, ad9832_of_match);
> > +


Yep.
To clarify what Jonathan said (see line below with plus + ) :

static struct spi_driver ad9832_driver = {
        .driver = {
                .name   = "ad9832",
+              .of_match_table = ad9832_of_match,
        },
        .probe          = ad9832_probe,
        .remove         = ad9832_remove,
        .id_table       = ad9832_id,
};



> >  static const struct spi_device_id ad9832_id[] = {
> >       {"ad9832", 0},
> >       {"ad9835", 0},
>

Patch
diff mbox series

diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index 74308a2e72db..51e97c74c6b2 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -451,6 +451,13 @@  static int ad9832_remove(struct spi_device *spi)
 	return 0;
 }
 
+static const struct of_device_id ad9832_of_match[] = {
+	{ .compatible = "adi,ad9832", },
+	{ .compatible = "adi,ad9835", },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, ad9832_of_match);
+
 static const struct spi_device_id ad9832_id[] = {
 	{"ad9832", 0},
 	{"ad9835", 0},