diff mbox series

[32/46] watchdog: pnx4008_wdt: drop warning after registering device

Message ID 20190518212801.31010-33-wsa+renesas@sang-engineering.com (mailing list archive)
State Accepted
Headers show
Series watchdog: move 'registration failed' messages into core | expand

Commit Message

Wolfram Sang May 18, 2019, 9:27 p.m. UTC
The core will print out details now.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/pnx4008_wdt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Sylvain Lemieux May 22, 2019, 4:04 p.m. UTC | #1
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>

On Sat, May 18, 2019 at 5:28 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> The core will print out details now.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/watchdog/pnx4008_wdt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
> index d9e03544aeae..124b1c66dc29 100644
> --- a/drivers/watchdog/pnx4008_wdt.c
> +++ b/drivers/watchdog/pnx4008_wdt.c
> @@ -221,10 +221,8 @@ static int pnx4008_wdt_probe(struct platform_device *pdev)
>                 set_bit(WDOG_HW_RUNNING, &pnx4008_wdd.status);
>
>         ret = devm_watchdog_register_device(dev, &pnx4008_wdd);
> -       if (ret < 0) {
> -               dev_err(dev, "cannot register watchdog device\n");
> +       if (ret < 0)
>                 return ret;
> -       }
>
>         dev_info(dev, "heartbeat %d sec\n", pnx4008_wdd.timeout);
>
> --
> 2.19.1
>
diff mbox series

Patch

diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
index d9e03544aeae..124b1c66dc29 100644
--- a/drivers/watchdog/pnx4008_wdt.c
+++ b/drivers/watchdog/pnx4008_wdt.c
@@ -221,10 +221,8 @@  static int pnx4008_wdt_probe(struct platform_device *pdev)
 		set_bit(WDOG_HW_RUNNING, &pnx4008_wdd.status);
 
 	ret = devm_watchdog_register_device(dev, &pnx4008_wdd);
-	if (ret < 0) {
-		dev_err(dev, "cannot register watchdog device\n");
+	if (ret < 0)
 		return ret;
-	}
 
 	dev_info(dev, "heartbeat %d sec\n", pnx4008_wdd.timeout);