[RESEND] staging: iio: adt7316: create of_device_id array
diff mbox series

Message ID 20190518224333.18067-1-barbara.fernandes@usp.br
State New
Headers show
Series
  • [RESEND] staging: iio: adt7316: create of_device_id array
Related show

Commit Message

Bárbara Fernandes May 18, 2019, 10:43 p.m. UTC
Create structure of type of_device_id in order to register all devices
the driver is able to manage.

Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Wilson Sales <spoonm@spoonm.org>
Co-developed-by: Wilson Sales <spoonm@spoonm.org>
---
 drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Jonathan Cameron May 19, 2019, 10:44 a.m. UTC | #1
On Sat, 18 May 2019 19:43:33 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:

> Create structure of type of_device_id in order to register all devices
> the driver is able to manage.
> 
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed-by: Wilson Sales <spoonm@spoonm.org>
Looks good to me.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
> index 8294b9c1e3c2..9968775f1d23 100644
> --- a/drivers/staging/iio/addac/adt7316-spi.c
> +++ b/drivers/staging/iio/addac/adt7316-spi.c
> @@ -127,9 +127,22 @@ static const struct spi_device_id adt7316_spi_id[] = {
>  
>  MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
>  
> +static const struct of_device_id adt7316_of_spi_match[] = {
> +	{ .compatible = "adi,adt7316" },
> +	{ .compatible = "adi,adt7317" },
> +	{ .compatible = "adi,adt7318" },
> +	{ .compatible = "adi,adt7516" },
> +	{ .compatible = "adi,adt7517" },
> +	{ .compatible = "adi,adt7519" },
> +	{ }
> +};
> +
> +MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
> +
>  static struct spi_driver adt7316_driver = {
>  	.driver = {
>  		.name = "adt7316",
> +		.of_match_table = adt7316_of_spi_match,
>  		.pm = ADT7316_PM_OPS,
>  	},
>  	.probe = adt7316_spi_probe,
Alexandru Ardelean May 20, 2019, 9:36 a.m. UTC | #2
On Sun, May 19, 2019 at 8:54 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 19:43:33 -0300
> Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
>
> > Create structure of type of_device_id in order to register all devices
> > the driver is able to manage.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed-by: Wilson Sales <spoonm@spoonm.org>
> Looks good to me.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> Thanks,

Also,

Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.


>
> Jonathan
>
> > ---
> >  drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
> > index 8294b9c1e3c2..9968775f1d23 100644
> > --- a/drivers/staging/iio/addac/adt7316-spi.c
> > +++ b/drivers/staging/iio/addac/adt7316-spi.c
> > @@ -127,9 +127,22 @@ static const struct spi_device_id adt7316_spi_id[] = {
> >
> >  MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
> >
> > +static const struct of_device_id adt7316_of_spi_match[] = {
> > +     { .compatible = "adi,adt7316" },
> > +     { .compatible = "adi,adt7317" },
> > +     { .compatible = "adi,adt7318" },
> > +     { .compatible = "adi,adt7516" },
> > +     { .compatible = "adi,adt7517" },
> > +     { .compatible = "adi,adt7519" },
> > +     { }
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
> > +
> >  static struct spi_driver adt7316_driver = {
> >       .driver = {
> >               .name = "adt7316",
> > +             .of_match_table = adt7316_of_spi_match,
> >               .pm = ADT7316_PM_OPS,
> >       },
> >       .probe = adt7316_spi_probe,
>

Patch
diff mbox series

diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
index 8294b9c1e3c2..9968775f1d23 100644
--- a/drivers/staging/iio/addac/adt7316-spi.c
+++ b/drivers/staging/iio/addac/adt7316-spi.c
@@ -127,9 +127,22 @@  static const struct spi_device_id adt7316_spi_id[] = {
 
 MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
 
+static const struct of_device_id adt7316_of_spi_match[] = {
+	{ .compatible = "adi,adt7316" },
+	{ .compatible = "adi,adt7317" },
+	{ .compatible = "adi,adt7318" },
+	{ .compatible = "adi,adt7516" },
+	{ .compatible = "adi,adt7517" },
+	{ .compatible = "adi,adt7519" },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
+
 static struct spi_driver adt7316_driver = {
 	.driver = {
 		.name = "adt7316",
+		.of_match_table = adt7316_of_spi_match,
 		.pm = ADT7316_PM_OPS,
 	},
 	.probe = adt7316_spi_probe,