[RESEND] staging: iio: ad7192: create of_device_id array
diff mbox series

Message ID 20190518224435.18266-1-barbara.fernandes@usp.br
State New
Headers show
Series
  • [RESEND] staging: iio: ad7192: create of_device_id array
Related show

Commit Message

Bárbara Fernandes May 18, 2019, 10:44 p.m. UTC
Create list of compatible device ids to be matched with those stated in
the device tree.

Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Wilson Sales <spoonm@spoonm.org>
Co-developed by: Wilson Sales <spoonm@spoonm.org>
---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Jonathan Cameron May 19, 2019, 10:46 a.m. UTC | #1
On Sat, 18 May 2019 19:44:35 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:

> Create list of compatible device ids to be matched with those stated in
> the device tree.
> 
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed by: Wilson Sales <spoonm@spoonm.org>
Hi Bárbara, Wilson,

One minor issue inline about code ordering.
Actual content is fine.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..cc886f944dbf 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
>  	{"ad7195", ID_AD7195},
>  	{}
>  };
> +
> +static const struct of_device_id ad7192_of_spi_match[] = {
> +	{ .compatible = "adi,ad7190" },
> +	{ .compatible = "adi,ad7192" },
> +	{ .compatible = "adi,ad7193" },
> +	{ .compatible = "adi,ad7195" },
> +	{}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> +
Please keep the declaration of the table alongside the relevant
MODULE_DEVICE_TABLE.

In short, better to have your additions after this next line.
>  MODULE_DEVICE_TABLE(spi, ad7192_id);
>  
>  static struct spi_driver ad7192_driver = {
>  	.driver = {
>  		.name	= "ad7192",
> +		.of_match_table = ad7192_of_spi_match,
>  	},
>  	.probe		= ad7192_probe,
>  	.remove		= ad7192_remove,
Alexandru Ardelean May 20, 2019, 10:22 a.m. UTC | #2
On Sun, May 19, 2019 at 8:53 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 19:44:35 -0300
> Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
>

I don't have anything else on top of what Jonathan added.

Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.

> > Create list of compatible device ids to be matched with those stated in
> > the device tree.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed by: Wilson Sales <spoonm@spoonm.org>
> Hi Bárbara, Wilson,
>
> One minor issue inline about code ordering.
> Actual content is fine.
>
> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index 3d74da9d37e7..cc886f944dbf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> >       {"ad7195", ID_AD7195},
> >       {}
> >  };
> > +
> > +static const struct of_device_id ad7192_of_spi_match[] = {
> > +     { .compatible = "adi,ad7190" },
> > +     { .compatible = "adi,ad7192" },
> > +     { .compatible = "adi,ad7193" },
> > +     { .compatible = "adi,ad7195" },
> > +     {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> > +
> Please keep the declaration of the table alongside the relevant
> MODULE_DEVICE_TABLE.
>
> In short, better to have your additions after this next line.
> >  MODULE_DEVICE_TABLE(spi, ad7192_id);
> >
> >  static struct spi_driver ad7192_driver = {
> >       .driver = {
> >               .name   = "ad7192",
> > +             .of_match_table = ad7192_of_spi_match,
> >       },
> >       .probe          = ad7192_probe,
> >       .remove         = ad7192_remove,
>

Patch
diff mbox series

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 3d74da9d37e7..cc886f944dbf 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -810,11 +810,23 @@  static const struct spi_device_id ad7192_id[] = {
 	{"ad7195", ID_AD7195},
 	{}
 };
+
+static const struct of_device_id ad7192_of_spi_match[] = {
+	{ .compatible = "adi,ad7190" },
+	{ .compatible = "adi,ad7192" },
+	{ .compatible = "adi,ad7193" },
+	{ .compatible = "adi,ad7195" },
+	{}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
+
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
 static struct spi_driver ad7192_driver = {
 	.driver = {
 		.name	= "ad7192",
+		.of_match_table = ad7192_of_spi_match,
 	},
 	.probe		= ad7192_probe,
 	.remove		= ad7192_remove,