From patchwork Mon May 20 08:21:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10950423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 58BC776 for ; Mon, 20 May 2019 08:23:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49F4528609 for ; Mon, 20 May 2019 08:23:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 486E128748; Mon, 20 May 2019 08:23:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F3638286AE for ; Mon, 20 May 2019 08:23:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1B98892A6; Mon, 20 May 2019 08:22:44 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2765E892A0 for ; Mon, 20 May 2019 08:22:42 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id n17so22608399edb.0 for ; Mon, 20 May 2019 01:22:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=brzEwqzIIXnydSs/RGKR5pFbo4J3hD4vcbto6AdqxGk=; b=sF37PnFf9zw7MJsypcYqvwzEezDjztiE8+8vmGTYRwgpVQEfd3aNZIeK8hxV4i5+jG GnAVdBAsrMtbVhIJ5efPMVCmh8OTT9iUDGtEtle0nNbmJtNJGcGY//qSGUxs6qRnODhL 9ZrLXjK2XxJP4Wurqz2kozqwrNxRq9gjmCJEexDfluA6Wo/d4pQslaRhWASLUm2tdgPb E6o9dRAGlb038CFksS4ZObhGUJ7vR7sYaMK0zrHYhID23qXjywOGczD4Ty12lUhNk9ZO Tg2c3GHNXQwy2sMHC0d+Dq3jkrLD2wXO2TVKt2tRcMp+n2TcUrOSZmlL1aa9I5XCVXwI dYkw== X-Gm-Message-State: APjAAAWw+iP1qp0dVgfJT7BVp2PqiZb2yvTRaYZW4+5/tV8/ZrxupA27 kiuRKXPPyPivPLz0+Br8MENflFYLs04= X-Google-Smtp-Source: APXvYqwcYQ/FNu9mKgR5y78+1RNm9YWWN/rbv1Dyk1fxTiJfn1IMT8JiRGTvl3E3oG9ZgSkImRa3bQ== X-Received: by 2002:a17:906:4911:: with SMTP id b17mr50845503ejq.3.1558340560091; Mon, 20 May 2019 01:22:40 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id t25sm3021263ejx.8.2019.05.20.01.22.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 01:22:39 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 15/33] fbdev/atyfb: lock_fb_info can't fail Date: Mon, 20 May 2019 10:21:58 +0200 Message-Id: <20190520082216.26273-16-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190520082216.26273-1-daniel.vetter@ffwll.ch> References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=brzEwqzIIXnydSs/RGKR5pFbo4J3hD4vcbto6AdqxGk=; b=k225G4BySl1X7q+UlZP4Nituk6duwxPLxugM6XbySvaJv68rXCwZLb3vHIHnpUiVtt RMs142ozoZpwli8WRmc7BaQJrVmTQEAYyzOd8QwAVlCuFVjST21Uh742TKY/EU7jI4tn FvVS9T4MOsKO5Bio5SHMWrXZSZUxfL3BAeT14= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , Daniel Vetter , Intel Graphics Development , LKML , "David S. Miller" , Mikulas Patocka , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's properly protected by reboot_lock. Signed-off-by: Daniel Vetter Cc: Mikulas Patocka Cc: "David S. Miller" Cc: "Ville Syrjälä" Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter --- drivers/video/fbdev/aty/atyfb_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b6fe103df145..eebb62d82a23 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -3916,8 +3916,7 @@ static int atyfb_reboot_notify(struct notifier_block *nb, if (!reboot_info) goto out; - if (!lock_fb_info(reboot_info)) - goto out; + lock_fb_info(reboot_info); par = reboot_info->par;