| Message ID | 20190520180712.32405-3-angus@akkea.ca (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Allow VINDPM to be set in the device tree | expand |
On Mon, May 20, 2019 at 11:07:12AM -0700, Angus Ainslie (Purism) wrote: > Add documentation on how to control VINDPM from the devicetree. > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt > index dc0568933359..fe8b709dd666 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt > +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt > @@ -26,9 +26,15 @@ Optional properties: > - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the > input current will be the lower between the resistor setting and the IINLIM > register setting; > +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set > + and the input voltage limit will be configured based on "ti,vinmin-threshold" Isn't presence of ti,vinmin-threshold enough to determine whether to set FORCE_VINDPM or not? Just get rid of the default being 4.4V. > - ti,thermal-regulation-threshold: integer, temperature above which the charge > current is lowered, to avoid overheating (in degrees Celsius). If omitted, > the default setting will be used (120 degrees); > +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the > + voltage falls below this threshold the charge current is reduced until the > + input voltage rises above the input voltage limit. If omitted, the default > + setting will be used (4.4V); > > Example: > > @@ -46,4 +52,6 @@ bq25890 { > > ti,use-ilim-pin; > ti,thermal-regulation-threshold = <120>; > + ti,use-vinmin-threshold; > + ti,vinmin-threshold = <3900000>; > }; > -- > 2.17.1 >
Hi, On Thu, Jun 13, 2019 at 05:09:06PM -0600, Rob Herring wrote: > On Mon, May 20, 2019 at 11:07:12AM -0700, Angus Ainslie (Purism) wrote: > > Add documentation on how to control VINDPM from the devicetree. > > > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > > --- > > .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt > > index dc0568933359..fe8b709dd666 100644 > > --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt > > +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt > > @@ -26,9 +26,15 @@ Optional properties: > > - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the > > input current will be the lower between the resistor setting and the IINLIM > > register setting; > > +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set > > + and the input voltage limit will be configured based on "ti,vinmin-threshold" > > Isn't presence of ti,vinmin-threshold enough to determine whether to set > FORCE_VINDPM or not? Just get rid of the default being 4.4V. > > > - ti,thermal-regulation-threshold: integer, temperature above which the charge > > current is lowered, to avoid overheating (in degrees Celsius). If omitted, > > the default setting will be used (120 degrees); > > +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the > > + voltage falls below this threshold the charge current is reduced until the > > + input voltage rises above the input voltage limit. If omitted, the default > > + setting will be used (4.4V); We already have a "input-voltage-min-microvolt" property used by Maxim chargers, please resuse that for the bq25890 instead of creating a new property name. -- Sebastian > > > > Example: > > > > @@ -46,4 +52,6 @@ bq25890 { > > > > ti,use-ilim-pin; > > ti,thermal-regulation-threshold = <120>; > > + ti,use-vinmin-threshold; > > + ti,vinmin-threshold = <3900000>; > > }; > > -- > > 2.17.1 > >
diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt index dc0568933359..fe8b709dd666 100644 --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt @@ -26,9 +26,15 @@ Optional properties: - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the input current will be the lower between the resistor setting and the IINLIM register setting; +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set + and the input voltage limit will be configured based on "ti,vinmin-threshold" - ti,thermal-regulation-threshold: integer, temperature above which the charge current is lowered, to avoid overheating (in degrees Celsius). If omitted, the default setting will be used (120 degrees); +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the + voltage falls below this threshold the charge current is reduced until the + input voltage rises above the input voltage limit. If omitted, the default + setting will be used (4.4V); Example: @@ -46,4 +52,6 @@ bq25890 { ti,use-ilim-pin; ti,thermal-regulation-threshold = <120>; + ti,use-vinmin-threshold; + ti,vinmin-threshold = <3900000>; };
Add documentation on how to control VINDPM from the devicetree. Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ 1 file changed, 8 insertions(+)