diff mbox series

[kvm-unit-tests] vmx_tests: use enter_guest if guest state is valid

Message ID 1558521229-8770-1-git-send-email-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] vmx_tests: use enter_guest if guest state is valid | expand

Commit Message

Paolo Bonzini May 22, 2019, 10:33 a.m. UTC
Change one remaining call site where the guest state is valid as far as
PAT is concerned; we should abort on both an early vmentry failure
as well as an invalid guest state.

Suggested-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 x86/vmx_tests.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krish Sadhukhan May 22, 2019, 6:04 p.m. UTC | #1
On 5/22/19 3:33 AM, Paolo Bonzini wrote:
> Change one remaining call site where the guest state is valid as far as
> PAT is concerned; we should abort on both an early vmentry failure
> as well as an invalid guest state.
>
> Suggested-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   x86/vmx_tests.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index a0b3639..b9bb169 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -6735,7 +6735,7 @@ static void test_pat(u32 field, const char * field_name, u32 ctrl_field,
>   				report_prefix_pop();
>   
>   			} else {	// GUEST_PAT
> -				enter_guest_with_invalid_guest_state();
> +				enter_guest();
>   				report_guest_pat_test("ENT_LOAD_PAT enabled",
>   						       VMX_VMCALL, val);
>   			}


Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
diff mbox series

Patch

diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index a0b3639..b9bb169 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -6735,7 +6735,7 @@  static void test_pat(u32 field, const char * field_name, u32 ctrl_field,
 				report_prefix_pop();
 
 			} else {	// GUEST_PAT
-				enter_guest_with_invalid_guest_state();
+				enter_guest();
 				report_guest_pat_test("ENT_LOAD_PAT enabled",
 						       VMX_VMCALL, val);
 			}