| Message ID | 20190522150717.1748-1-vicencb@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: rockchip: dts: sapphire: Fix USB3 Type-C. | expand |
Hi Vicente, Am Mittwoch, 22. Mai 2019, 17:07:17 CEST schrieb Vicente Bergas: > Before this patch, the Type-C port on the Sapphire board is dead. > > Applying only the power supply part of this patch, makes the port work > for about 4 seconds at start-up. This is a sample trace with a memory > stick plugged in: > 1.- The memory stick LED lights on and kernel reports: > [ 4.782999] scsi 0:0:0:0: Direct-Access USB DISK PMAP PQ: 0 ANSI: 4 > [ 5.904580] sd 0:0:0:0: [sdb] 3913344 512-byte logical blocks: (2.00 GB/1.87 GiB) > [ 5.906860] sd 0:0:0:0: [sdb] Write Protect is off > [ 5.908973] sd 0:0:0:0: [sdb] Mode Sense: 23 00 00 00 > [ 5.909122] sd 0:0:0:0: [sdb] No Caching mode page found > [ 5.911214] sd 0:0:0:0: [sdb] Assuming drive cache: write through > [ 5.951585] sdb: sdb1 > [ 5.954816] sd 0:0:0:0: [sdb] Attached SCSI removable disk > 2.- 4 seconds later the memory stick LED lights off and kernel reports: > [ 9.082822] phy phy-ff770000.syscon:usb2-phy@e450.2: charger = USB_DCP_CHARGER > 3.- After a minute the kernel reports: > [ 71.666761] usb 5-1: USB disconnect, device number 2 > It has been checked that, although the LED is off, VBUS is present. > > Applying the full patch makes it work. > It has only been tested in host mode. > > Signed-off-by: Vicente Bergas <vicencb@gmail.com> having to set the regulator to always-on indicates more an issue with the phy? Because in theory the phy-driver should just enable the supplying regulator on power-on. Like would it work to just add the regulator to the host-port of the phy without enabling it all the time? Thanks Heiko > --- > arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > index 04623e52ac5d..72000a7b666f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > @@ -112,6 +112,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&vcc5v0_typec0_en>; > regulator-name = "vcc5v0_typec0"; > + regulator-always-on; > vin-supply = <&vcc_sys>; > }; > > @@ -565,12 +566,11 @@ > status = "okay"; > > u2phy0_otg: otg-port { > - phy-supply = <&vcc5v0_typec0>; > status = "okay"; > }; > > u2phy0_host: host-port { > - phy-supply = <&vcc5v0_host>; > + phy-supply = <&vcc5v0_typec0>; > status = "okay"; > }; > }; > @@ -620,7 +620,7 @@ > > &usbdrd_dwc3_0 { > status = "okay"; > - dr_mode = "otg"; > + dr_mode = "host"; > }; > > &usbdrd3_1 { >
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi index 04623e52ac5d..72000a7b666f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi @@ -112,6 +112,7 @@ pinctrl-names = "default"; pinctrl-0 = <&vcc5v0_typec0_en>; regulator-name = "vcc5v0_typec0"; + regulator-always-on; vin-supply = <&vcc_sys>; }; @@ -565,12 +566,11 @@ status = "okay"; u2phy0_otg: otg-port { - phy-supply = <&vcc5v0_typec0>; status = "okay"; }; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec0>; status = "okay"; }; }; @@ -620,7 +620,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {
Before this patch, the Type-C port on the Sapphire board is dead. Applying only the power supply part of this patch, makes the port work for about 4 seconds at start-up. This is a sample trace with a memory stick plugged in: 1.- The memory stick LED lights on and kernel reports: [ 4.782999] scsi 0:0:0:0: Direct-Access USB DISK PMAP PQ: 0 ANSI: 4 [ 5.904580] sd 0:0:0:0: [sdb] 3913344 512-byte logical blocks: (2.00 GB/1.87 GiB) [ 5.906860] sd 0:0:0:0: [sdb] Write Protect is off [ 5.908973] sd 0:0:0:0: [sdb] Mode Sense: 23 00 00 00 [ 5.909122] sd 0:0:0:0: [sdb] No Caching mode page found [ 5.911214] sd 0:0:0:0: [sdb] Assuming drive cache: write through [ 5.951585] sdb: sdb1 [ 5.954816] sd 0:0:0:0: [sdb] Attached SCSI removable disk 2.- 4 seconds later the memory stick LED lights off and kernel reports: [ 9.082822] phy phy-ff770000.syscon:usb2-phy@e450.2: charger = USB_DCP_CHARGER 3.- After a minute the kernel reports: [ 71.666761] usb 5-1: USB disconnect, device number 2 It has been checked that, although the LED is off, VBUS is present. Applying the full patch makes it work. It has only been tested in host mode. Signed-off-by: Vicente Bergas <vicencb@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)