| Message ID | 20190523140059.18548-1-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190523140059.18548-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190523140059.18548-1-richard.henderson@linaro.org
Type: series
Subject: [Qemu-devel] [PULL 00/13] Add RX architecture
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190523140059.18548-1-richard.henderson@linaro.org -> patchew/20190523140059.18548-1-richard.henderson@linaro.org
Switched to a new branch 'test'
e6345697e9 MAINTAINERS: Add RX
c1e4418120 Add rx-softmmu
940b7f49bd target/rx: Convert to CPUClass::tlb_fill
47f3797ced hw/registerfields.h: Add 8bit and 16bit register macros
04cd122dd5 qemu/bitops.h: Add extract8 and extract16
4017188b54 hw/rx: RX Target hardware definition
3795fc80d1 hw/char: RX62N serial communication interface (SCI)
325f1589d7 hw/timer: RX62N internal timer modules
c06f2e7abe hw/intc: RX62N interrupt controller (ICUa)
eae1254986 target/rx: RX disassembler
db39b054cd target/rx: CPU definition
6138a23b1a target/rx: TCG helper
5b7f4e8f48 target/rx: TCG translation
=== OUTPUT BEGIN ===
1/13 Checking commit 5b7f4e8f4860 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 1/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/13 Checking commit 6138a23b1ae8 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 660 lines checked
Patch 2/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/13 Checking commit db39b054cd7e (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
ERROR: code indent should never use tabs
#383: FILE: target/rx/cpu.h:137:
+ qemu_irq ack;^I^I/* Interrupt acknowledge */$
total: 1 errors, 1 warnings, 599 lines checked
Patch 3/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit eae125498605 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 4/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/13 Checking commit c06f2e7abea6 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
ERROR: code indent should never use tabs
#434: FILE: include/hw/intc/rx_icu.h:9:
+ TRG_NEDGE = 1,^I/* Falling */$
ERROR: code indent should never use tabs
#435: FILE: include/hw/intc/rx_icu.h:10:
+ TRG_PEDGE = 2,^I/* Raising */$
ERROR: code indent should never use tabs
#436: FILE: include/hw/intc/rx_icu.h:11:
+ TRG_BEDGE = 3,^I/* Both */$
total: 3 errors, 1 warnings, 442 lines checked
Patch 5/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/13 Checking commit 325f1589d719 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
total: 0 errors, 1 warnings, 839 lines checked
Patch 6/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/13 Checking commit 3795fc80d185 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42:
new file mode 100644
total: 0 errors, 1 warnings, 398 lines checked
Patch 7/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/13 Checking commit 4017188b5476 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 460 lines checked
Patch 8/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/13 Checking commit 04cd122dd562 (qemu/bitops.h: Add extract8 and extract16)
10/13 Checking commit 47f3797ced17 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2466.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#25: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#29: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 10/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/13 Checking commit 940b7f49bd48 (target/rx: Convert to CPUClass::tlb_fill)
12/13 Checking commit c1e4418120ab (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644
total: 0 errors, 1 warnings, 45 lines checked
Patch 12/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/13 Checking commit e6345697e93f (MAINTAINERS: Add RX)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190523140059.18548-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, 23 May 2019 at 16:30, <no-reply@patchew.org> wrote: > > 3/13 Checking commit db39b054cd7e (target/rx: CPU definition) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #14: > new file mode 100644 > > ERROR: code indent should never use tabs > #383: FILE: target/rx/cpu.h:137: > + qemu_irq ack;^I^I/* Interrupt acknowledge */$ > > total: 1 errors, 1 warnings, 599 lines checked > > Patch 3/13 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 5/13 Checking commit c06f2e7abea6 (hw/intc: RX62N interrupt controller (ICUa)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #39: > new file mode 100644 > > ERROR: code indent should never use tabs > #434: FILE: include/hw/intc/rx_icu.h:9: > + TRG_NEDGE = 1,^I/* Falling */$ > > ERROR: code indent should never use tabs > #435: FILE: include/hw/intc/rx_icu.h:10: > + TRG_PEDGE = 2,^I/* Raising */$ > > ERROR: code indent should never use tabs > #436: FILE: include/hw/intc/rx_icu.h:11: > + TRG_BEDGE = 3,^I/* Both */$ > > total: 3 errors, 1 warnings, 442 lines checked I'm not going to block the pull request just for a code style issue, but it would be nice if you could send a followup patch once this has landed that fixes the hard-coded tabs. thanks -- PMM
On Thu, 23 May 2019 at 15:01, Richard Henderson <richard.henderson@linaro.org> wrote: > > Thanks to Sato-san for persevering through 14 iterations. > > > r~ > > > The following changes since commit d418238dca7b4e0b124135827ead3076233052b1: > > Merge remote-tracking branch 'remotes/rth/tags/pull-rng-20190522' into staging (2019-05-23 12:57:17 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-rx-20190523 > > for you to fetch changes up to fe7ddbc2dade3daf767c9ac07b8569791b5376a8: > > MAINTAINERS: Add RX (2019-05-23 09:38:27 -0400) > > ---------------------------------------------------------------- > Initial commit for the RX cpu. > Hi -- I'm afraid this fails to pass "make check": [...] PASS 29 qmp-cmd-test /rx/qmp/query-name PASS 30 qmp-cmd-test /rx/qmp/query-kvm PASS 31 qmp-cmd-test /rx/qmp/query-uuid PASS 32 qmp-cmd-test /rx/qmp/query-events PASS 33 qmp-cmd-test /rx/qmp/query-cpus Unexpected error in qapi_enum_parse() at /home/petmay01/linaro/qemu-for-merges/qapi/qapi-util.c:39: invalid parameter value: rx Broken pipe /home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:143: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) Aborted (core dumped) ERROR - too few tests run (expected 51, got 33) /home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:884: recipe for target 'check-qtest-rx' failed thanks - PMM
Thanks to Sato-san for persevering through 14 iterations. r~ The following changes since commit d418238dca7b4e0b124135827ead3076233052b1: Merge remote-tracking branch 'remotes/rth/tags/pull-rng-20190522' into staging (2019-05-23 12:57:17 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-rx-20190523 for you to fetch changes up to fe7ddbc2dade3daf767c9ac07b8569791b5376a8: MAINTAINERS: Add RX (2019-05-23 09:38:27 -0400) ---------------------------------------------------------------- Initial commit for the RX cpu. ---------------------------------------------------------------- Richard Henderson (1): target/rx: Convert to CPUClass::tlb_fill Yoshinori Sato (12): target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition qemu/bitops.h: Add extract8 and extract16 hw/registerfields.h: Add 8bit and 16bit register macros Add rx-softmmu MAINTAINERS: Add RX include/disas/dis-asm.h | 5 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 94 ++ include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu.h | 227 ++++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 340 ++++++ hw/intc/rx_icu.c | 376 +++++++ hw/rx/rx-virt.c | 105 ++ hw/rx/rx62n.c | 238 ++++ hw/timer/renesas_cmt.c | 275 +++++ hw/timer/renesas_tmr.c | 455 ++++++++ target/rx/cpu.c | 236 ++++ target/rx/disas.c | 1480 ++++++++++++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 +++ target/rx/monitor.c | 38 + target/rx/op_helper.c | 470 ++++++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++++++++++++++++++ MAINTAINERS | 19 + configure | 8 + default-configs/rx-softmmu.mak | 3 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 12 + target/rx/insns.decode | 621 ++++++++++ 40 files changed, 8030 insertions(+), 1 deletion(-) create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/monitor.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 default-configs/rx-softmmu.mak create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode