From patchwork Fri May 24 08:53:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10959423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE650112C for ; Fri, 24 May 2019 08:55:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC521287A8 for ; Fri, 24 May 2019 08:55:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9DD0F2884E; Fri, 24 May 2019 08:55:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 59477287A8 for ; Fri, 24 May 2019 08:55:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA5406E0CA; Fri, 24 May 2019 08:54:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 041FA6E0BD for ; Fri, 24 May 2019 08:54:24 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id p27so13376655eda.1 for ; Fri, 24 May 2019 01:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=brzEwqzIIXnydSs/RGKR5pFbo4J3hD4vcbto6AdqxGk=; b=tSGwfjlHhd6uBysTV+ERgiq38ytyneL2qnmia49JAbPKTtQQbaaoYS1JuhKdzf0xGF GCGBkEVx8LHgwSeU0m4ULhgKA1Yv+4m18MExETmaGlOMnUoY4VJM9Tji+F5KCWZ6BItv BY4DDQnj1EdXgE5ZIBt81VR1IMd/o1t5DOlcW52yvxL1au1v2XMXkqV49VuUlMoSS6Gk 0NnOPqcOnYCgY2EKmo0zsYW1fZOwsX/NlJEVi6m3N/zx1UzLANvDCC3cpTcGknn7Hpsy RUwhzlSEzuoWZFMCZhi1KO6kLteGXyRdfScpPf9saXmy3c723YXRlYm9FkJ4WzY4ukX6 TjGg== X-Gm-Message-State: APjAAAUBUDWcqzpNZLzANm/NwCeAfdBL6BMlkw1aeCzasd/fQMqNnjAf oX6zDiupZRPXPkiYA2Jj8ZAxiw== X-Google-Smtp-Source: APXvYqyWxvUGXtbZ3ghrLc8v+hKyKnYCdQVb8oPo8l7h4OBwvxyDc3SSjNPuRkrd519zrYDMbCVOGA== X-Received: by 2002:a50:9858:: with SMTP id h24mr55620849edb.147.1558688061759; Fri, 24 May 2019 01:54:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id 96sm567082edq.68.2019.05.24.01.54.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 01:54:21 -0700 (PDT) From: Daniel Vetter To: LKML Subject: [PATCH 15/33] fbdev/atyfb: lock_fb_info can't fail Date: Fri, 24 May 2019 10:53:36 +0200 Message-Id: <20190524085354.27411-16-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190524085354.27411-1-daniel.vetter@ffwll.ch> References: <20190524085354.27411-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=brzEwqzIIXnydSs/RGKR5pFbo4J3hD4vcbto6AdqxGk=; b=Xeo0NgYq2zY1qZPEankOx3NnBKnR25IXVXKxHkt4Y0761hcMWTCBOBv7E29ft9gKMK UuKrb+d5LMYjosukYAmOB+0jLjO/Y+J6bSeJt3HuAbXJzhngH6TYBnlErxYlaaJpzn03 9plmnzfTUhDWJle88EbXJyyIodmCNhuCQStxs= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , Daniel Vetter , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , DRI Development , "David S. Miller" , Mikulas Patocka , Intel Graphics Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's properly protected by reboot_lock. Signed-off-by: Daniel Vetter Cc: Mikulas Patocka Cc: "David S. Miller" Cc: "Ville Syrjälä" Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter --- drivers/video/fbdev/aty/atyfb_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b6fe103df145..eebb62d82a23 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -3916,8 +3916,7 @@ static int atyfb_reboot_notify(struct notifier_block *nb, if (!reboot_info) goto out; - if (!lock_fb_info(reboot_info)) - goto out; + lock_fb_info(reboot_info); par = reboot_info->par;