| Message ID | 20190525115542.107929-1-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | clk: samsung: exynos5433: Use of_clk_get_parent_count() | expand |
On 25.05.2019 13:55, Kefeng Wang wrote: > Use of_clk_get_parent_count() instead of open coding. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index dae1c96de933..14e253915ca4 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev) > data->nr_clk_save = info->nr_clk_regs; > data->clk_suspend = info->suspend_regs; > data->nr_clk_suspend = info->nr_suspend_regs; > - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks", > - "#clock-cells"); > + data->nr_pclks = of_clk_get_parent_count(dev->of_node); > + > if (data->nr_pclks > 0) { > data->pclks = devm_kcalloc(dev, sizeof(struct clk *), > data->nr_pclks, GFP_KERNEL); Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej
Hi, On 19. 5. 25. 오후 8:55, Kefeng Wang wrote: > Use of_clk_get_parent_count() instead of open coding. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index dae1c96de933..14e253915ca4 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev) > data->nr_clk_save = info->nr_clk_regs; > data->clk_suspend = info->suspend_regs; > data->nr_clk_suspend = info->nr_suspend_regs; > - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks", > - "#clock-cells"); > + data->nr_pclks = of_clk_get_parent_count(dev->of_node); > + > if (data->nr_pclks > 0) { > data->pclks = devm_kcalloc(dev, sizeof(struct clk *), > data->nr_pclks, GFP_KERNEL); > It uses the helper function from CCF. Looks good to me. Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
On 5/25/19 13:55, Kefeng Wang wrote: > Use of_clk_get_parent_count() instead of open coding. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Patch applied, thank you. In future please make sure to also Cc linux-clk@vger.kernel.org mailing list and the clk maintainers (Stephen, Michael) when sending clk patches. > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index dae1c96de933..14e253915ca4 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev) > data->nr_clk_save = info->nr_clk_regs; > data->clk_suspend = info->suspend_regs; > data->nr_clk_suspend = info->nr_suspend_regs; > - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks", > - "#clock-cells"); > + data->nr_pclks = of_clk_get_parent_count(dev->of_node); > + > if (data->nr_pclks > 0) { > data->pclks = devm_kcalloc(dev, sizeof(struct clk *), > data->nr_pclks, GFP_KERNEL); >
On 2019/5/30 19:13, Sylwester Nawrocki wrote: > On 5/25/19 13:55, Kefeng Wang wrote: >> Use of_clk_get_parent_count() instead of open coding. >> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > Patch applied, thank you. > > In future please make sure to also Cc linux-clk@vger.kernel.org mailing list > and the clk maintainers (Stephen, Michael) when sending clk patches. OK, thanks for the tip. > >> --- >> drivers/clk/samsung/clk-exynos5433.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c >> index dae1c96de933..14e253915ca4 100644 >> --- a/drivers/clk/samsung/clk-exynos5433.c >> +++ b/drivers/clk/samsung/clk-exynos5433.c >> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev) >> data->nr_clk_save = info->nr_clk_regs; >> data->clk_suspend = info->suspend_regs; >> data->nr_clk_suspend = info->nr_suspend_regs; >> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks", >> - "#clock-cells"); >> + data->nr_pclks = of_clk_get_parent_count(dev->of_node); >> + >> if (data->nr_pclks > 0) { >> data->pclks = devm_kcalloc(dev, sizeof(struct clk *), >> data->nr_pclks, GFP_KERNEL); >>
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index dae1c96de933..14e253915ca4 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev) data->nr_clk_save = info->nr_clk_regs; data->clk_suspend = info->suspend_regs; data->nr_clk_suspend = info->nr_suspend_regs; - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks", - "#clock-cells"); + data->nr_pclks = of_clk_get_parent_count(dev->of_node); + if (data->nr_pclks > 0) { data->pclks = devm_kcalloc(dev, sizeof(struct clk *), data->nr_pclks, GFP_KERNEL);
Use of_clk_get_parent_count() instead of open coding. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/clk/samsung/clk-exynos5433.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)