[-next] ASoC: cx2072x: remove set but not used variable 'is_right_j '
diff mbox series

Message ID 20190525123204.16148-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] ASoC: cx2072x: remove set but not used variable 'is_right_j '
Related show

Commit Message

YueHaibing May 25, 2019, 12:32 p.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm:
sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable]

It's never used and can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 sound/soc/codecs/cx2072x.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Takashi Iwai May 27, 2019, 7:38 a.m. UTC | #1
On Sat, 25 May 2019 14:32:04 +0200,
YueHaibing wrote:
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm:
> sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable]
> 
> It's never used and can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi


> ---
>  sound/soc/codecs/cx2072x.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c
> index 23d2b25fe04c..a066ef83de1a 100644
> --- a/sound/soc/codecs/cx2072x.c
> +++ b/sound/soc/codecs/cx2072x.c
> @@ -676,7 +676,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
>  	unsigned int bclk_rate = 0;
>  	int is_i2s = 0;
>  	int has_one_bit_delay = 0;
> -	int is_right_j = 0;
>  	int is_frame_inv = 0;
>  	int is_bclk_inv = 0;
>  	int pulse_len = 1;
> @@ -740,7 +739,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
>  
>  	case SND_SOC_DAIFMT_RIGHT_J:
>  		is_i2s = 1;
> -		is_right_j = 1;
>  		pulse_len = frame_len / 2;
>  		break;
>  
> -- 
> 2.17.1
> 
> 
>

Patch
diff mbox series

diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c
index 23d2b25fe04c..a066ef83de1a 100644
--- a/sound/soc/codecs/cx2072x.c
+++ b/sound/soc/codecs/cx2072x.c
@@ -676,7 +676,6 @@  static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
 	unsigned int bclk_rate = 0;
 	int is_i2s = 0;
 	int has_one_bit_delay = 0;
-	int is_right_j = 0;
 	int is_frame_inv = 0;
 	int is_bclk_inv = 0;
 	int pulse_len = 1;
@@ -740,7 +739,6 @@  static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
 
 	case SND_SOC_DAIFMT_RIGHT_J:
 		is_i2s = 1;
-		is_right_j = 1;
 		pulse_len = frame_len / 2;
 		break;