| Message ID | 1558929734-20051-1-git-send-email-anshuman.khandual@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64/mm: Drop BUG_ON() from [pmd|pud]_set_huge() | expand |
On Mon, 27 May 2019 at 06:02, Anshuman Khandual <anshuman.khandual@arm.com> wrote: > > There are no callers for the functions which will pass unaligned physical > addresses. Hence just drop these BUG_ON() checks which are not required. > This might change in the future, right? Should we perhaps switch to VM_BUG_ON() instead so they get compiled out unless CONFIG_VM_DEBUG is enabled? > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > --- > arch/arm64/mm/mmu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 22c2e4f0768f..629011c6238d 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -978,7 +978,6 @@ int pud_set_huge(pud_t *pudp, phys_addr_t phys, pgprot_t prot) > pud_val(new_pud))) > return 0; > > - BUG_ON(phys & ~PUD_MASK); > set_pud(pudp, new_pud); > return 1; > } > @@ -992,7 +991,6 @@ int pmd_set_huge(pmd_t *pmdp, phys_addr_t phys, pgprot_t prot) > pmd_val(new_pmd))) > return 0; > > - BUG_ON(phys & ~PMD_MASK); > set_pmd(pmdp, new_pmd); > return 1; > } > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 05/27/2019 12:07 PM, Ard Biesheuvel wrote: > On Mon, 27 May 2019 at 06:02, Anshuman Khandual > <anshuman.khandual@arm.com> wrote: >> There are no callers for the functions which will pass unaligned physical >> addresses. Hence just drop these BUG_ON() checks which are not required. >> > This might change in the future, right? Should we perhaps switch to > VM_BUG_ON() instead so they get compiled out unless CONFIG_VM_DEBUG is > enabled? Sure we can do that. Will re-send.
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 22c2e4f0768f..629011c6238d 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -978,7 +978,6 @@ int pud_set_huge(pud_t *pudp, phys_addr_t phys, pgprot_t prot) pud_val(new_pud))) return 0; - BUG_ON(phys & ~PUD_MASK); set_pud(pudp, new_pud); return 1; } @@ -992,7 +991,6 @@ int pmd_set_huge(pmd_t *pmdp, phys_addr_t phys, pgprot_t prot) pmd_val(new_pmd))) return 0; - BUG_ON(phys & ~PMD_MASK); set_pmd(pmdp, new_pmd); return 1; }
There are no callers for the functions which will pass unaligned physical addresses. Hence just drop these BUG_ON() checks which are not required. Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> --- arch/arm64/mm/mmu.c | 2 -- 1 file changed, 2 deletions(-)