| Message ID | 20190527091323.4582-5-sr@denx.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/8,v2] MIPS: ralink: mt7628a.dtsi: Add SPDX GPL-2.0 license identifier | expand |
Hi Stefan, On Mon, May 27, 2019 at 11:13:20AM +0200, Stefan Roese wrote: > diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi > index 0c2983c9c47c..64a425c7d639 100644 > --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi > +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi > @@ -170,6 +170,22 @@ > interrupts = <6>; > }; > > + i2c: i2c@900 { > + compatible = "mediatek,mt7621-i2c"; > + reg = <0x900 0x100>; I don't see this compatible string listed under Documentation/devicetree/bindings, nor in drivers/i2c/busses/i2c-mt65xx.c which I presume is the driver that would handle it. I guess this needs driver changes to be applied before it'll actually do anything? I'd prefer that at least the DT binding documentation goes in before we add the nodes to the DT. If those changes are already queued up somewhere else could you point me at them? Thanks, Paul
Hi Paul, On 28.05.19 22:41, Paul Burton wrote: > Hi Stefan, > > On Mon, May 27, 2019 at 11:13:20AM +0200, Stefan Roese wrote: >> diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi >> index 0c2983c9c47c..64a425c7d639 100644 >> --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi >> +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi >> @@ -170,6 +170,22 @@ >> interrupts = <6>; >> }; >> >> + i2c: i2c@900 { >> + compatible = "mediatek,mt7621-i2c"; >> + reg = <0x900 0x100>; > > I don't see this compatible string listed under > Documentation/devicetree/bindings, nor in > drivers/i2c/busses/i2c-mt65xx.c which I presume is the driver that would > handle it. No, these is a different driver queued for this (old) SoC. I've submitted it on the I2C list and am pretty hopeful, that it will hit next shortly: https://patchwork.ozlabs.org/patch/1095794/ The bindings are included in this patch. > I guess this needs driver changes to be applied before it'll actually do > anything? Correct. > I'd prefer that at least the DT binding documentation goes in before we > add the nodes to the DT. I understand. I've added Wolfram to Cc to perhaps comment on this. > If those changes are already queued up somewhere else could you point me > at them? Please see above. Thanks, Stefan
Hi Stefan, On Wed, May 29, 2019 at 07:19:31AM +0200, Stefan Roese wrote: > On 28.05.19 22:41, Paul Burton wrote: > > On Mon, May 27, 2019 at 11:13:20AM +0200, Stefan Roese wrote: > > > diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi > > > index 0c2983c9c47c..64a425c7d639 100644 > > > --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi > > > +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi > > > @@ -170,6 +170,22 @@ > > > interrupts = <6>; > > > }; > > > + i2c: i2c@900 { > > > + compatible = "mediatek,mt7621-i2c"; > > > + reg = <0x900 0x100>; > > > > I don't see this compatible string listed under > > Documentation/devicetree/bindings, nor in > > drivers/i2c/busses/i2c-mt65xx.c which I presume is the driver that would > > handle it. > > No, these is a different driver queued for this (old) SoC. I've submitted > it on the I2C list and am pretty hopeful, that it will hit next shortly: > > https://patchwork.ozlabs.org/patch/1095794/ > > The bindings are included in this patch. > > I guess this needs driver changes to be applied before it'll actually do > > anything? > > Correct. > > I'd prefer that at least the DT binding documentation goes in before we > > add the nodes to the DT. > > I understand. I've added Wolfram to Cc to perhaps comment on this. > > If those changes are already queued up somewhere else could you point me > > at them? > > Please see above. OK, I don't see the driver queued up yet so in the meantime I've applied patches 1-4 & 6-7. If you could ping me or resend this one once the I2C binding is in-tree, that would be wonderful. Thanks, Paul
> OK, I don't see the driver queued up yet so in the meantime I've applied > patches 1-4 & 6-7. If you could ping me or resend this one once the I2C > binding is in-tree, that would be wonderful. I was waiting for Rob's ack for the driver, but with the merge window coming, I will apply it tomorrow. The bindings are simple enough.
Hi Paul, On 25.06.19 00:07, Wolfram Sang wrote: > >> OK, I don't see the driver queued up yet so in the meantime I've applied >> patches 1-4 & 6-7. If you could ping me or resend this one once the I2C >> binding is in-tree, that would be wonderful. > > I was waiting for Rob's ack for the driver, but with the merge window > coming, I will apply it tomorrow. The bindings are simple enough. The I2C driver is now available in linux-next. Could you please push this patch too? Thanks, Stefan
diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi index 0c2983c9c47c..64a425c7d639 100644 --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi @@ -170,6 +170,22 @@ interrupts = <6>; }; + i2c: i2c@900 { + compatible = "mediatek,mt7621-i2c"; + reg = <0x900 0x100>; + + pinctrl-names = "default"; + pinctrl-0 = <&pinmux_i2c_i2c>; + + resets = <&resetc 16>; + reset-names = "i2c"; + + #address-cells = <1>; + #size-cells = <0>; + + status = "disabled"; + }; + uart0: uartlite@c00 { compatible = "ns16550a"; reg = <0xc00 0x100>;
This patch adds the I2C controller description to the MT7628A dtsi file. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Paul Burton <paul.burton@mips.com> Cc: Harvey Hunt <harveyhuntnexus@gmail.com> Cc: John Crispin <john@phrozen.org> --- v2: - Use Harvey's new email address (not at imgtec) - Use correct linux-mips list address arch/mips/boot/dts/ralink/mt7628a.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)