fstests: fix _repair_scratch_fs error reporting
diff mbox series

Message ID 20190528120847.31003-1-amir73il@gmail.com
State New
Headers show
Series
  • fstests: fix _repair_scratch_fs error reporting
Related show

Commit Message

Amir Goldstein May 28, 2019, 12:08 p.m. UTC
_dump_err2() helper was introduced over two years ago and it broke
the error reporting from _repair_scratch_fs.

Every test that runs:
_repair_scratch_fs >> $seqres.full

and expect to fail if anything is written to stderr is not working
as intended.

Spotted-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Eryu,

This bug was found by zhangyi while working on fsck.overlay patches,
but it affects all filesystems. I just re-found zhangyi's fix while
going through some old notes.

Amir.

 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

zhangyi (F) May 29, 2019, 1:37 p.m. UTC | #1
On 2019/5/28 20:08, Amir Goldstein Wrote:
> _dump_err2() helper was introduced over two years ago and it broke
> the error reporting from _repair_scratch_fs.
> 
> Every test that runs:
> _repair_scratch_fs >> $seqres.full
> 
> and expect to fail if anything is written to stderr is not working
> as intended.
> 
> Spotted-by: zhangyi (F) <yi.zhang@huawei.com>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

Thanks for re-post it.
Reviewed-by: zhangyi (F) <yi.zhang@huawei.com>

Thanks
Yi.

> ---
> 
> Eryu,
> 
> This bug was found by zhangyi while working on fsck.overlay patches,
> but it affects all filesystems. I just re-found zhangyi's fix while
> going through some old notes.
> 
> Amir.
> 
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 17b89d5d..e78e0920 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -98,7 +98,7 @@ _dump_err_cont()
>  _dump_err2()
>  {
>      _err_msg="$*"
> -    >2& echo "$_err_msg"
> +    >&2 echo "$_err_msg"
>  }
>  
>  _log_err()
>

Patch
diff mbox series

diff --git a/common/rc b/common/rc
index 17b89d5d..e78e0920 100644
--- a/common/rc
+++ b/common/rc
@@ -98,7 +98,7 @@  _dump_err_cont()
 _dump_err2()
 {
     _err_msg="$*"
-    >2& echo "$_err_msg"
+    >&2 echo "$_err_msg"
 }
 
 _log_err()