mbox series

[GIT,PULL,FOR,v5.3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

Message ID 4d45c05b-8b24-6f35-a891-4646c8e1e1f5@xs4all.nl (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v5.3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3f

Message

Hans Verkuil May 28, 2019, 6:10 p.m. UTC 
The following changes since commit 9bec226d8c79fcbc95817b082557f72a79d182f5:

  media: v4l2-pci-skeleton.c: fix doc warning (2019-05-28 13:14:28 -0400)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3f

for you to fetch changes up to 75e52767fa3d58a783dd6862a7fb686e5de67fc6:

  allegro: add SPS/PPS nal unit writer (2019-05-28 20:00:26 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (1):
      videobuf2-v4l2: set last_buffer_dequeued in dqbuf

Michael Tretter (4):
      media: dt-bindings: media: document allegro-dvt bindings
      media: dt-bindings: media: Add vendor prefix for allegro
      allegro: add Allegro DVT video IP core driver
      allegro: add SPS/PPS nal unit writer

 Documentation/devicetree/bindings/media/allegro.txt    |   43 +
 Documentation/devicetree/bindings/vendor-prefixes.yaml |    2 +
 MAINTAINERS                                            |    7 +
 drivers/media/common/videobuf2/videobuf2-v4l2.c        |   10 +-
 drivers/staging/media/Kconfig                          |    2 +
 drivers/staging/media/Makefile                         |    1 +
 drivers/staging/media/allegro-dvt/Kconfig              |   16 +
 drivers/staging/media/allegro-dvt/Makefile             |    6 +
 drivers/staging/media/allegro-dvt/TODO                 |    4 +
 drivers/staging/media/allegro-dvt/allegro-core.c       | 3032 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/staging/media/allegro-dvt/nal-h264.c           | 1001 +++++++++++++++++++++
 drivers/staging/media/allegro-dvt/nal-h264.h           |  208 +++++
 12 files changed, 4327 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allegro.txt
 create mode 100644 drivers/staging/media/allegro-dvt/Kconfig
 create mode 100644 drivers/staging/media/allegro-dvt/Makefile
 create mode 100644 drivers/staging/media/allegro-dvt/TODO
 create mode 100644 drivers/staging/media/allegro-dvt/allegro-core.c
 create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.c
 create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.h

Comments

Mauro Carvalho Chehab May 29, 2019, 11:07 a.m. UTC | #1 
Em Tue, 28 May 2019 20:10:27 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> The following changes since commit 9bec226d8c79fcbc95817b082557f72a79d182f5:
> 
>   media: v4l2-pci-skeleton.c: fix doc warning (2019-05-28 13:14:28 -0400)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3f
> 
> for you to fetch changes up to 75e52767fa3d58a783dd6862a7fb686e5de67fc6:
> 
>   allegro: add SPS/PPS nal unit writer (2019-05-28 20:00:26 +0200)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Hans Verkuil (1):
>       videobuf2-v4l2: set last_buffer_dequeued in dqbuf
> 
> Michael Tretter (4):
>       media: dt-bindings: media: document allegro-dvt bindings
>       media: dt-bindings: media: Add vendor prefix for allegro
>       allegro: add Allegro DVT video IP core driver
>       allegro: add SPS/PPS nal unit writer

As this is staging, merged, but there's something wrong with DT here:

WARNING: DT compatible string vendor "allegro" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
#3013: FILE: drivers/staging/media/allegro-dvt/allegro-core.c:3013:
+	{ .compatible = "allegro,al5e-1.1" },

Please send a followup patch addressing it.

Thanks,
Mauro
Hans Verkuil May 29, 2019, 11:29 a.m. UTC | #2 
On 5/29/19 1:07 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 28 May 2019 20:10:27 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
>> The following changes since commit 9bec226d8c79fcbc95817b082557f72a79d182f5:
>>
>>   media: v4l2-pci-skeleton.c: fix doc warning (2019-05-28 13:14:28 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3f
>>
>> for you to fetch changes up to 75e52767fa3d58a783dd6862a7fb686e5de67fc6:
>>
>>   allegro: add SPS/PPS nal unit writer (2019-05-28 20:00:26 +0200)
>>
>> ----------------------------------------------------------------
>> Tag branch
>>
>> ----------------------------------------------------------------
>> Hans Verkuil (1):
>>       videobuf2-v4l2: set last_buffer_dequeued in dqbuf
>>
>> Michael Tretter (4):
>>       media: dt-bindings: media: document allegro-dvt bindings
>>       media: dt-bindings: media: Add vendor prefix for allegro
>>       allegro: add Allegro DVT video IP core driver
>>       allegro: add SPS/PPS nal unit writer
> 
> As this is staging, merged, but there's something wrong with DT here:
> 
> WARNING: DT compatible string vendor "allegro" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
> #3013: FILE: drivers/staging/media/allegro-dvt/allegro-core.c:3013:
> +	{ .compatible = "allegro,al5e-1.1" },
> 
> Please send a followup patch addressing it.

Huh? Something went wrong: this is the patch that is in my for-v5.3f branch:

https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.3f&id=ae4e36dd1945380ccd97090d2099f67be9a976d8

That's not what you tried to merge.

Regards,

	Hans
Hans Verkuil May 29, 2019, 11:32 a.m. UTC | #3 
On 5/29/19 1:29 PM, Hans Verkuil wrote:
> On 5/29/19 1:07 PM, Mauro Carvalho Chehab wrote:
>> Em Tue, 28 May 2019 20:10:27 +0200
>> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>>
>>> The following changes since commit 9bec226d8c79fcbc95817b082557f72a79d182f5:
>>>
>>>   media: v4l2-pci-skeleton.c: fix doc warning (2019-05-28 13:14:28 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3f
>>>
>>> for you to fetch changes up to 75e52767fa3d58a783dd6862a7fb686e5de67fc6:
>>>
>>>   allegro: add SPS/PPS nal unit writer (2019-05-28 20:00:26 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Tag branch
>>>
>>> ----------------------------------------------------------------
>>> Hans Verkuil (1):
>>>       videobuf2-v4l2: set last_buffer_dequeued in dqbuf
>>>
>>> Michael Tretter (4):
>>>       media: dt-bindings: media: document allegro-dvt bindings
>>>       media: dt-bindings: media: Add vendor prefix for allegro
>>>       allegro: add Allegro DVT video IP core driver
>>>       allegro: add SPS/PPS nal unit writer
>>
>> As this is staging, merged, but there's something wrong with DT here:
>>
>> WARNING: DT compatible string vendor "allegro" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
>> #3013: FILE: drivers/staging/media/allegro-dvt/allegro-core.c:3013:
>> +	{ .compatible = "allegro,al5e-1.1" },
>>
>> Please send a followup patch addressing it.
> 
> Huh? Something went wrong: this is the patch that is in my for-v5.3f branch:
> 
> https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.3f&id=ae4e36dd1945380ccd97090d2099f67be9a976d8
> 
> That's not what you tried to merge.

Never mind.

The cause is that the change to vendor-prefixes.yaml was done after the change
to allegro.txt. Those two patches should have been swapped.

So nothing is wrong.

Regards,

	Hans