[PULL] gvt-fixes
mbox series

Message ID 20190529090608.GB3211@zhen-hp.sh.intel.com
State New
Headers show
Series
  • [PULL] gvt-fixes
Related show

Pull-request

https://github.com/intel/gvt-linux tags/gvt-fixes-2019-05-29

Message

Zhenyu Wang May 29, 2019, 9:06 a.m. UTC
Hi,

Here's more gvt fixes for 5.2. This includes fixes for recently
seen arbitrary DMA map fault with sane gtt entry initialization,
and several enforcement fixes for e.g ggtt range validation, some
mode register handler and one cmd length fix for parser.

Thanks
--
The following changes since commit 591c39ffac4ab1ddf2ea6d49331cb614e0682b28:

  drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry() (2019-05-21 10:58:16 +0800)

are available in the Git repository at:

  https://github.com/intel/gvt-linux tags/gvt-fixes-2019-05-29

for you to fetch changes up to 66b5cfa043e44eb15bcfd6488db7664ce7b3ac80:

  drm/i915/gvt: Fix cmd length of VEB_DI_IECP (2019-05-28 17:53:45 +0800)

----------------------------------------------------------------
gvt-fixes-2019-05-29

- Fix gtt entry update with sane initialization (Tina)
- Fix missed RING_HEAD/RING_TAIL update for vgpu state (Xiaolin)
- Fix force-to-nonpriv warning from recent guest (Colin)
- Fix GFX_MODE and CSFE_CHICKEN1_REG handler for host only control (Colin)
- GGTT range validation enforced (Xiong)
- Fix cmd length for VEB_DI_IECP (Fred)

----------------------------------------------------------------
Colin Xu (3):
      drm/i915/gvt: Update force-to-nonpriv register whitelist
      drm/i915/gvt: Fix GFX_MODE handling
      drm/i915/gvt: Fix vGPU CSFE_CHICKEN1_REG mmio handler

Gao, Fred (1):
      drm/i915/gvt: Fix cmd length of VEB_DI_IECP

Tina Zhang (1):
      drm/i915/gvt: Initialize intel_gvt_gtt_entry in stack

Xiaolin Zhang (1):
      drm/i915/gvt: save RING_HEAD into vreg when vgpu switched out

Xiong Zhang (1):
      drm/i915/gvt: refine ggtt range validation

 drivers/gpu/drm/i915/gvt/cmd_parser.c |  2 +-
 drivers/gpu/drm/i915/gvt/gtt.c        | 26 ++++++++++++++++---------
 drivers/gpu/drm/i915/gvt/handlers.c   | 36 ++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/gvt/scheduler.c  |  4 ++++
 4 files changed, 57 insertions(+), 11 deletions(-)

Comments

Joonas Lahtinen May 29, 2019, 12:07 p.m. UTC | #1
Quoting Zhenyu Wang (2019-05-29 12:06:08)
> 
> Hi,
> 
> Here's more gvt fixes for 5.2. This includes fixes for recently
> seen arbitrary DMA map fault with sane gtt entry initialization,
> and several enforcement fixes for e.g ggtt range validation, some
> mode register handler and one cmd length fix for parser.

Applying the pull reveals that there is a patch with space missing from
the Fixes: line. Could you fix it and re-generate?

"
From https://github.com/intel/gvt-linux
 * tag                         gvt-fixes-2019-05-29 -> FETCH_HEAD
dim: 5d43bc76ad97 ("drm/i915/gvt: Initialize intel_gvt_gtt_entry in stack"): Subject in fixes line doesn't match referenced commit:
dim:     7598e8700e9a(drm/i915/gvt: Missed to cancel dma map for ggtt entries)
dim: ERROR: issues in commits detected, aborting
"

Regards, Joonas
Zhenyu Wang May 30, 2019, 3:41 a.m. UTC | #2
On 2019.05.29 15:07:09 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2019-05-29 12:06:08)
> > 
> > Hi,
> > 
> > Here's more gvt fixes for 5.2. This includes fixes for recently
> > seen arbitrary DMA map fault with sane gtt entry initialization,
> > and several enforcement fixes for e.g ggtt range validation, some
> > mode register handler and one cmd length fix for parser.
> 
> Applying the pull reveals that there is a patch with space missing from
> the Fixes: line. Could you fix it and re-generate?
> 
> "
> From https://github.com/intel/gvt-linux
>  * tag                         gvt-fixes-2019-05-29 -> FETCH_HEAD
> dim: 5d43bc76ad97 ("drm/i915/gvt: Initialize intel_gvt_gtt_entry in stack"): Subject in fixes line doesn't match referenced commit:
> dim:     7598e8700e9a(drm/i915/gvt: Missed to cancel dma map for ggtt entries)
> dim: ERROR: issues in commits detected, aborting
> "
> 

Sorry about that! Missed that.. Please check regenerated one below.
And I've dropped one commit for guest ring state update which had got
more thought that should be reworked.

Thanks
--
The following changes since commit 591c39ffac4ab1ddf2ea6d49331cb614e0682b28:

  drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry() (2019-05-21 10:58:16 +0800)

are available in the Git repository at:

  https://github.com/intel/gvt-linux tags/gvt-fixes-2019-05-30

for you to fetch changes up to 3035e8cd6c316cb633b45bc9b38052ba2dfd299b:

  drm/i915/gvt: Fix cmd length of VEB_DI_IECP (2019-05-30 11:31:43 +0800)

----------------------------------------------------------------
gvt-fixes-2019-05-30

- Fix gtt entry update with sane initialization (Tina)
- Fix force-to-nonpriv warning from recent guest (Colin)
- Fix GFX_MODE and CSFE_CHICKEN1_REG handler for host only control (Colin)
- GGTT range validation enforced (Xiong)
- Fix cmd length for VEB_DI_IECP (Fred)

----------------------------------------------------------------
Colin Xu (3):
      drm/i915/gvt: Update force-to-nonpriv register whitelist
      drm/i915/gvt: Fix GFX_MODE handling
      drm/i915/gvt: Fix vGPU CSFE_CHICKEN1_REG mmio handler

Gao, Fred (1):
      drm/i915/gvt: Fix cmd length of VEB_DI_IECP

Tina Zhang (1):
      drm/i915/gvt: Initialize intel_gvt_gtt_entry in stack

Xiong Zhang (1):
      drm/i915/gvt: refine ggtt range validation

 drivers/gpu/drm/i915/gvt/cmd_parser.c |  2 +-
 drivers/gpu/drm/i915/gvt/gtt.c        | 26 ++++++++++++++++---------
 drivers/gpu/drm/i915/gvt/handlers.c   | 36 ++++++++++++++++++++++++++++++++++-
 3 files changed, 53 insertions(+), 11 deletions(-)
Joonas Lahtinen May 31, 2019, 8:16 a.m. UTC | #3
Quoting Zhenyu Wang (2019-05-30 06:41:37)
> Sorry about that! Missed that.. Please check regenerated one below.
> And I've dropped one commit for guest ring state update which had got
> more thought that should be reworked.

Pulled now. Thanks for the PR.

Regards, Joonas