[1/4] drm: Drop a redundant unused variable
diff mbox series

Message ID 1559159944-21103-2-git-send-email-uma.shankar@intel.com
State New
Headers show
Series
  • Document fixes for DRM UAPI and HDR
Related show

Commit Message

Shankar, Uma May 29, 2019, 7:59 p.m. UTC
Drop a redundant and unused variable "hdr_output_metadata" from
drm_connector.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 include/drm/drm_connector.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Daniel Vetter June 3, 2019, 8:12 a.m. UTC | #1
On Thu, May 30, 2019 at 01:29:01AM +0530, Uma Shankar wrote:
> Drop a redundant and unused variable "hdr_output_metadata" from
> drm_connector.
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>

For next time around: Please add Fixes: lines to indicate which already
merged commit you're improving.

Patch merged, thanks.
-Daniel

> ---
>  include/drm/drm_connector.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index f8f4003..5476561 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1244,8 +1244,6 @@ struct drm_connector {
>  	 */
>  	struct llist_node free_node;
>  
> -	/* HDR metdata */
> -	struct hdr_output_metadata hdr_output_metadata;
>  	struct hdr_sink_metadata hdr_sink_metadata;
>  };
>  
> -- 
> 1.9.1
>
Shankar, Uma June 3, 2019, 11:52 a.m. UTC | #2
>-----Original Message-----
>From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
>Sent: Monday, June 3, 2019 1:42 PM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
>maarten.lankhorst@linux.intel.com; ville.syrjala@linux.intel.com; Sharma, Shashank
><shashank.sharma@intel.com>; emil.l.velikov@gmail.com; brian.starkey@arm.com;
>dcastagna@chromium.org; seanpaul@chromium.org; Roper, Matthew D
><matthew.d.roper@intel.com>; jonas@kwiboo.se; daniel@ffwll.ch
>Subject: Re: [PATCH 1/4] drm: Drop a redundant unused variable
>
>On Thu, May 30, 2019 at 01:29:01AM +0530, Uma Shankar wrote:
>> Drop a redundant and unused variable "hdr_output_metadata" from
>> drm_connector.
>>
>> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
>> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>
>For next time around: Please add Fixes: lines to indicate which already merged
>commit you're improving.

Thanks Daniel. Sure, will take care of that in future.

Regards,
Uma Shankar

>Patch merged, thanks.
>-Daniel
>
>> ---
>>  include/drm/drm_connector.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>> index f8f4003..5476561 100644
>> --- a/include/drm/drm_connector.h
>> +++ b/include/drm/drm_connector.h
>> @@ -1244,8 +1244,6 @@ struct drm_connector {
>>  	 */
>>  	struct llist_node free_node;
>>
>> -	/* HDR metdata */
>> -	struct hdr_output_metadata hdr_output_metadata;
>>  	struct hdr_sink_metadata hdr_sink_metadata;  };
>>
>> --
>> 1.9.1
>>
>
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch

Patch
diff mbox series

diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index f8f4003..5476561 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -1244,8 +1244,6 @@  struct drm_connector {
 	 */
 	struct llist_node free_node;
 
-	/* HDR metdata */
-	struct hdr_output_metadata hdr_output_metadata;
 	struct hdr_sink_metadata hdr_sink_metadata;
 };