| Message ID | 1559229194-3036-3-git-send-email-Dave.Martin@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Pointer Authentication and SVE support | expand |
On Thu, 30 May 2019 16:13:07 +0100 Dave Martin <Dave.Martin@arm.com> wrote: > If in intermediate step fails, update_headers.sh blindly continues > and may return success status. > > To avoid errors going unnoticed when driving this script, exit and > report failure status as soon as something goes wrong. For good > measure, also fail on expansion of undefined shell variables to aid > future maintainers. > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> Both "u" and "e" seem to be standard and work in dash and ash, so: Reviewed-by: Andre Przywara <andre.przywara@arm.com> Thanks, Andre. > --- > util/update_headers.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/util/update_headers.sh b/util/update_headers.sh > index 4ba1b9f..a7e21b8 100755 > --- a/util/update_headers.sh > +++ b/util/update_headers.sh > @@ -7,6 +7,8 @@ > # using the lib/modules/`uname -r`/source link. > ######################################################################## > > +set -ue > + > if [ "$#" -ge 1 ] > then > LINUX_ROOT="$1"
On Fri, May 31, 2019 at 06:03:10PM +0100, Andre Przywara wrote: > On Thu, 30 May 2019 16:13:07 +0100 > Dave Martin <Dave.Martin@arm.com> wrote: > > > If in intermediate step fails, update_headers.sh blindly continues > > and may return success status. > > > > To avoid errors going unnoticed when driving this script, exit and > > report failure status as soon as something goes wrong. For good > > measure, also fail on expansion of undefined shell variables to aid > > future maintainers. > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > Both "u" and "e" seem to be standard and work in dash and ash, so: > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> Thanks. Those options have been there forever, so I presume they are specified by POSIX... but I confess I didn't check. Cheers ---Dave
diff --git a/util/update_headers.sh b/util/update_headers.sh index 4ba1b9f..a7e21b8 100755 --- a/util/update_headers.sh +++ b/util/update_headers.sh @@ -7,6 +7,8 @@ # using the lib/modules/`uname -r`/source link. ######################################################################## +set -ue + if [ "$#" -ge 1 ] then LINUX_ROOT="$1"
If in intermediate step fails, update_headers.sh blindly continues and may return success status. To avoid errors going unnoticed when driving this script, exit and report failure status as soon as something goes wrong. For good measure, also fail on expansion of undefined shell variables to aid future maintainers. Signed-off-by: Dave Martin <Dave.Martin@arm.com> --- util/update_headers.sh | 2 ++ 1 file changed, 2 insertions(+)