[v1,1/1] vfio-ccw: Destroy kmem cache region on module exit
diff mbox series

Message ID c0f39039d28af39ea2939391bf005e3495d890fd.1559576250.git.alifm@linux.ibm.com
State New
Headers show
Series
  • [v1,1/1] vfio-ccw: Destroy kmem cache region on module exit
Related show

Commit Message

Farhan Ali June 3, 2019, 3:42 p.m. UTC
Free the vfio_ccw_cmd_region on module exit.

Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
---

I guess I missed this earlier while reviewing, but should'nt 
we destroy the vfio_ccw_cmd_region on module exit, as well?

 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Cornelia Huck June 4, 2019, 6:03 a.m. UTC | #1
On Mon,  3 Jun 2019 11:42:47 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> Free the vfio_ccw_cmd_region on module exit.
> 
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> 
> I guess I missed this earlier while reviewing, but should'nt 
> we destroy the vfio_ccw_cmd_region on module exit, as well?
> 
>  drivers/s390/cio/vfio_ccw_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 66a66ac..9cee9f2 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
>  	css_driver_unregister(&vfio_ccw_sch_driver);
>  	isc_unregister(VFIO_CCW_ISC);
>  	kmem_cache_destroy(vfio_ccw_io_region);
> +	kmem_cache_destroy(vfio_ccw_cmd_region);
>  	destroy_workqueue(vfio_ccw_work_q);
>  }
>  module_init(vfio_ccw_sch_init);

Yes, you're right. Will queue when the pull req has been processed.
Cornelia Huck June 4, 2019, 3:44 p.m. UTC | #2
On Mon,  3 Jun 2019 11:42:47 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> Free the vfio_ccw_cmd_region on module exit.

Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")

> 
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> 
> I guess I missed this earlier while reviewing, but should'nt 
> we destroy the vfio_ccw_cmd_region on module exit, as well?
> 
>  drivers/s390/cio/vfio_ccw_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 66a66ac..9cee9f2 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
>  	css_driver_unregister(&vfio_ccw_sch_driver);
>  	isc_unregister(VFIO_CCW_ISC);
>  	kmem_cache_destroy(vfio_ccw_io_region);
> +	kmem_cache_destroy(vfio_ccw_cmd_region);
>  	destroy_workqueue(vfio_ccw_work_q);
>  }
>  module_init(vfio_ccw_sch_init);

Thanks, applied.

Patch
diff mbox series

diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 66a66ac..9cee9f2 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -299,6 +299,7 @@  static void __exit vfio_ccw_sch_exit(void)
 	css_driver_unregister(&vfio_ccw_sch_driver);
 	isc_unregister(VFIO_CCW_ISC);
 	kmem_cache_destroy(vfio_ccw_io_region);
+	kmem_cache_destroy(vfio_ccw_cmd_region);
 	destroy_workqueue(vfio_ccw_work_q);
 }
 module_init(vfio_ccw_sch_init);