| Message ID | 20190604172858.107084-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f7369179ad32000973fc7a0a76603e0b41792b52 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | mwifiex: drop 'set_consistent_dma_mask' log message | expand |
Brian Norris <briannorris@chromium.org> wrote: > This message is pointless. > > While we're at it, include the error code in the error message, which is > not pointless. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-drivers-next.git, thanks. f7369179ad32 mwifiex: drop 'set_consistent_dma_mask' log message
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 3fe81b2a929a..82f58bf0fc43 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -2924,10 +2924,9 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter) pci_set_master(pdev); - pr_notice("try set_consistent_dma_mask(32)\n"); ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); if (ret) { - pr_err("set_dma_mask(32) failed\n"); + pr_err("set_dma_mask(32) failed: %d\n", ret); goto err_set_dma_mask; }
This message is pointless. While we're at it, include the error code in the error message, which is not pointless. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)