From patchwork Wed Jun 5 11:14:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 10976621 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CD0676 for ; Wed, 5 Jun 2019 11:14:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F84228783 for ; Wed, 5 Jun 2019 11:14:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 740742892E; Wed, 5 Jun 2019 11:14:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0F0628880 for ; Wed, 5 Jun 2019 11:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbfFELOT (ORCPT ); Wed, 5 Jun 2019 07:14:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:53798 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727183AbfFELOT (ORCPT ); Wed, 5 Jun 2019 07:14:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7F914ACEE; Wed, 5 Jun 2019 11:14:17 +0000 (UTC) From: Jiri Slaby To: heiko.carstens@de.ibm.com Cc: linux-kernel@vger.kernel.org, Jiri Slaby , Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org, Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org Subject: [PATCH] kbuild: s390, do not remove autogenerated headers on clean Date: Wed, 5 Jun 2019 13:14:16 +0200 Message-Id: <20190605111416.13341-1-jslaby@suse.cz> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 'make clean' does NOT remove autogenerated headers generated from arch/s390/kernel/syscalls/. For example: asm-offsets.h irq_regs.h irq_work.h unistd_nr.h But 'make clean' DOES currently remove dis-defs.h and facility-defs.h generated from arch/s390/tools/. The issue is that facility-defs.h is included from and builds of external modules fail due to missing header. (When cleaned build directory is used.) Fix this by adding these targets to no-clean-files. Signed-off-by: Jiri Slaby Cc: Masahiro Yamada Cc: Michal Marek Cc: linux-kbuild@vger.kernel.org Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: linux-s390@vger.kernel.org --- I would love to see comments from KBuild guys as I am not sure if this fix is correct at all. arch/s390/tools/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile index 2342b84b3386..984b2f43651e 100644 --- a/arch/s390/tools/Makefile +++ b/arch/s390/tools/Makefile @@ -7,6 +7,7 @@ kapi := arch/$(ARCH)/include/generated/asm kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h targets += $(addprefix ../../../,$(kapi-hdrs-y)) +no-clean-files += $(targets) PHONY += kapi kapi: $(kapi-hdrs-y)