| Message ID | 20190606222751.32567-5-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vkms: rework crc worker | expand |
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > No need to have them multiple times. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: Haneen Mohammed <hamohammed.sa@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/vkms/vkms_drv.h | 8 -------- > drivers/gpu/drm/vkms/vkms_plane.c | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 43d3f98289fe..2a35299bfb89 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -20,14 +20,6 @@ > > extern bool enable_cursor; > > -static const u32 vkms_formats[] = { > - DRM_FORMAT_XRGB8888, > -}; > - > -static const u32 vkms_cursor_formats[] = { > - DRM_FORMAT_ARGB8888, > -}; > - > struct vkms_crc_data { > struct drm_framebuffer fb; > struct drm_rect src, dst; > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > index 0e67d2d42f0c..0fceb6258422 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -6,6 +6,14 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > > +static const u32 vkms_formats[] = { > + DRM_FORMAT_XRGB8888, > +}; > + > +static const u32 vkms_cursor_formats[] = { > + DRM_FORMAT_ARGB8888, > +}; > + > static struct drm_plane_state * > vkms_plane_duplicate_state(struct drm_plane *plane) > { > -- > 2.20.1 > Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Tested-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
On 06/07, Daniel Vetter wrote: > No need to have them multiple times. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: Haneen Mohammed <hamohammed.sa@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/vkms/vkms_drv.h | 8 -------- > drivers/gpu/drm/vkms/vkms_plane.c | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 43d3f98289fe..2a35299bfb89 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -20,14 +20,6 @@ > > extern bool enable_cursor; > > -static const u32 vkms_formats[] = { > - DRM_FORMAT_XRGB8888, > -}; > - > -static const u32 vkms_cursor_formats[] = { > - DRM_FORMAT_ARGB8888, > -}; > - > struct vkms_crc_data { > struct drm_framebuffer fb; > struct drm_rect src, dst; > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > index 0e67d2d42f0c..0fceb6258422 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -6,6 +6,14 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > > +static const u32 vkms_formats[] = { > + DRM_FORMAT_XRGB8888, > +}; > + > +static const u32 vkms_cursor_formats[] = { > + DRM_FORMAT_ARGB8888, > +}; > + > static struct drm_plane_state * > vkms_plane_duplicate_state(struct drm_plane *plane) > { > -- > 2.20.1 > Applied to the drm-misc-next branch. Thanks.
diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h index 43d3f98289fe..2a35299bfb89 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -20,14 +20,6 @@ extern bool enable_cursor; -static const u32 vkms_formats[] = { - DRM_FORMAT_XRGB8888, -}; - -static const u32 vkms_cursor_formats[] = { - DRM_FORMAT_ARGB8888, -}; - struct vkms_crc_data { struct drm_framebuffer fb; struct drm_rect src, dst; diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c index 0e67d2d42f0c..0fceb6258422 100644 --- a/drivers/gpu/drm/vkms/vkms_plane.c +++ b/drivers/gpu/drm/vkms/vkms_plane.c @@ -6,6 +6,14 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_gem_framebuffer_helper.h> +static const u32 vkms_formats[] = { + DRM_FORMAT_XRGB8888, +}; + +static const u32 vkms_cursor_formats[] = { + DRM_FORMAT_ARGB8888, +}; + static struct drm_plane_state * vkms_plane_duplicate_state(struct drm_plane *plane) {
No need to have them multiple times. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: Haneen Mohammed <hamohammed.sa@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/vkms/vkms_drv.h | 8 -------- drivers/gpu/drm/vkms/vkms_plane.c | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-)