fstests: btrfs/163: make readahead run on the seed device
diff mbox series

Message ID 20190607023422.28928-1-naohiro.aota@wdc.com
State New
Headers show
Series
  • fstests: btrfs/163: make readahead run on the seed device
Related show

Commit Message

Naohiro Aota June 7, 2019, 2:34 a.m. UTC
There is a long lived bug that btrfs wait for readahead to finish
indefinitely when readahead zone is inserted into seed devices.

Current write size to the file "foobar" is too small to run readahead
before the replacing on seed device. So, increase the write size to
reproduce the issue.

Following patch fixes it:

	"btrfs: start readahead also in seed devices"

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
 tests/btrfs/163 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Naohiro Aota June 7, 2019, 5:19 a.m. UTC | #1
I forgot to update the expected output. Ignore this.

On 2019/06/07 11:34, Naohiro Aota wrote:
> There is a long lived bug that btrfs wait for readahead to finish
> indefinitely when readahead zone is inserted into seed devices.
> 
> Current write size to the file "foobar" is too small to run readahead
> before the replacing on seed device. So, increase the write size to
> reproduce the issue.
> 
> Following patch fixes it:
> 
> 	"btrfs: start readahead also in seed devices"
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
>   tests/btrfs/163 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/163 b/tests/btrfs/163
> index 8c93e83b970a..24c725afb6b9 100755
> --- a/tests/btrfs/163
> +++ b/tests/btrfs/163
> @@ -50,7 +50,7 @@ create_seed()
>   {
>   	_mkfs_dev $dev_seed
>   	run_check _mount $dev_seed $SCRATCH_MNT
> -	$XFS_IO_PROG -f -d -c "pwrite -S 0xab 0 256K" $SCRATCH_MNT/foobar >\
> +	$XFS_IO_PROG -f -d -c "pwrite -S 0xab 0 4M" $SCRATCH_MNT/foobar >\
>   		/dev/null
>   	echo -- gloden --
>   	od -x $SCRATCH_MNT/foobar
>

Patch
diff mbox series

diff --git a/tests/btrfs/163 b/tests/btrfs/163
index 8c93e83b970a..24c725afb6b9 100755
--- a/tests/btrfs/163
+++ b/tests/btrfs/163
@@ -50,7 +50,7 @@  create_seed()
 {
 	_mkfs_dev $dev_seed
 	run_check _mount $dev_seed $SCRATCH_MNT
-	$XFS_IO_PROG -f -d -c "pwrite -S 0xab 0 256K" $SCRATCH_MNT/foobar >\
+	$XFS_IO_PROG -f -d -c "pwrite -S 0xab 0 4M" $SCRATCH_MNT/foobar >\
 		/dev/null
 	echo -- gloden --
 	od -x $SCRATCH_MNT/foobar