ALSA: snd_ice1712: Check correct return value to snd_i2c_sendbytes (EWS/DMX 6Fire)

Commit Message

Rui Nuno Capela June 7, 2019, 2 p.m. UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Check for exact and correct return value to snd_i2c_sendbytes
call for EWS/DMX 6Fire (snd_ice1712).

Fixes a systemic error on every boot to snd_ice1712 driver
("cannot send pca") on Terratec EWS/DMX 6Fire PCI soundcards.

Signed-off-by: Rui Nuno Capela <[e-mail]>

Cheers
- -- 
rncbc aka. Rui Nuno Capela
[e-mail]
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEml2OG8nT8/KXriugSepTUDAa1MgFAlz6beYACgkQSepTUDAa
1MgAggf+LVoDgtUTSU6OsBipvlZ9Ro8ll4qBIPC8JtECk6iHur3C/xEHYqirVRQa
HVBuNxN4RiaJI/upALZ/6n2XY3cjB04qgfCg+lQTQFAY7Or6G3L3vzyg8C/y7q2n
uqkZTgbfNwQ01Xbq7Xa9QQ02eJKFCAmAOscBXwBQTpzzoThwFj0edUqvHleYuWOT
b6qsVUSJJmJQlJe/10zyg+btmQEtLAWtLsIg0pkvJQJCmQgxeCvDspoH8THs/ov3
eCZNVUjnK1qkkl1Z7yFLjp7wx8RV28YZ5kMtDmkiDac66JfEO80qtJvxwbAY/hOm
B/mII9niJLCEGV2cdNwPGpr2n4EdLg==
=g9Fk
-----END PGP SIGNATURE-----

Patch

Check for exact and correct return value to snd_i2c_sendbytes
call for EWS/DMX 6Fire (snd_ice1712).

Fixes a systemic error on every boot to snd_ice1712 driver
("cannot send pca") on Terratec EWS/DMX 6Fire PCI soundcards.

Signed-off-by: Rui Nuno Capela <[e-mail]>


--- a/sound/pci/ice1712/ews.c	2019-06-04 06:59:45.000000000 +0100
+++ b/sound/pci/ice1712/ews.c	2019-06-07 11:04:01.735954865 +0100
@@ -826,7 +826,7 @@ 
 
 	snd_i2c_lock(ice->i2c);
 	byte = reg;
-	if (snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1)) {
+	if (snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1) != 1) {
 		snd_i2c_unlock(ice->i2c);
 		dev_err(ice->card->dev, "cannot send pca\n");
 		return -EIO;