diff mbox series

[RESEND] block: move tag field position in struct request

Message ID 20190608201551.4531-1-minwoo.im.dev@gmail.com (mailing list archive)
State New, archived
Headers show
Series [RESEND] block: move tag field position in struct request | expand

Commit Message

Minwoo Im June 8, 2019, 8:15 p.m. UTC 
__data_len and __sector are internal fields which should not be accessed
directly in driver-level like the comment above it. But, tag field can
be accessed by driver level directly so that we need to make the comment
right by moving it to some other place.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/blkdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig June 20, 2019, 8:54 a.m. UTC | #1 
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe June 20, 2019, 9:17 a.m. UTC | #2 
On 6/8/19 2:15 PM, Minwoo Im wrote:
> __data_len and __sector are internal fields which should not be accessed
> directly in driver-level like the comment above it. But, tag field can
> be accessed by driver level directly so that we need to make the comment
> right by moving it to some other place.

Applied, thanks.
diff mbox series

Patch

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 592669bcc536..90e6914bea0c 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -137,11 +137,11 @@  struct request {
 	unsigned int cmd_flags;		/* op and common flags */
 	req_flags_t rq_flags;
 
+	int tag;
 	int internal_tag;
 
 	/* the following two fields are internal, NEVER access directly */
 	unsigned int __data_len;	/* total data len */
-	int tag;
 	sector_t __sector;		/* sector cursor */
 
 	struct bio *bio;