| Message ID | 20190609102912.9717-1-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: oxfw: allow PCM capture for Stanton SCS.1m | expand |
On Sun, 09 Jun 2019 12:29:12 +0200, Takashi Sakamoto wrote: > > Stanton SCS.1m can transfer isochronous packet with Multi Bit Linear > Audio data channels, therefore it allows software to capture PCM > substream. However, ALSA oxfw driver doesn't. > > This commit changes the driver to add one PCM substream for capture > direction. > > Fixes: de5126cc3c0b ("ALSA: oxfw: add stream format quirk for SCS.1 models") > Cc: <stable@vger.kernel.org> # v4.5+ > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Applied, thanks. Takashi
diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c index 3d27f3378d5d..b4bef574929d 100644 --- a/sound/firewire/oxfw/oxfw.c +++ b/sound/firewire/oxfw/oxfw.c @@ -148,9 +148,6 @@ static int detect_quirks(struct snd_oxfw *oxfw) oxfw->midi_input_ports = 0; oxfw->midi_output_ports = 0; - /* Output stream exists but no data channels are useful. */ - oxfw->has_output = false; - return snd_oxfw_scs1x_add(oxfw); }
Stanton SCS.1m can transfer isochronous packet with Multi Bit Linear Audio data channels, therefore it allows software to capture PCM substream. However, ALSA oxfw driver doesn't. This commit changes the driver to add one PCM substream for capture direction. Fixes: de5126cc3c0b ("ALSA: oxfw: add stream format quirk for SCS.1 models") Cc: <stable@vger.kernel.org> # v4.5+ Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- sound/firewire/oxfw/oxfw.c | 3 --- 1 file changed, 3 deletions(-)