ext4/035: skip this test if DAX is in use
diff mbox series

Message ID 20190610024254.9830-1-tytso@mit.edu
State New
Headers show
Series
  • ext4/035: skip this test if DAX is in use
Related show

Commit Message

Theodore Y. Ts'o June 10, 2019, 2:42 a.m. UTC
This test creates a file system with a 1k block size.  Since there are
no architectures with a 1k page size, test file system can never be
mounted with DAX enabled, causing the test to fail.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 tests/ext4/035 | 1 +
 1 file changed, 1 insertion(+)

Comments

Theodore Y. Ts'o June 10, 2019, 2:53 a.m. UTC | #1
On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote:
> This test creates a file system with a 1k block size.  Since there are
> no architectures with a 1k page size, test file system can never be

s/test file system/the test file system/

> mounted with DAX enabled, causing the test to fail.

Sorry, typo.

						- Ted
Yang Xu June 10, 2019, 5:34 a.m. UTC | #2
on 2019/06/10 10:53, Theodore Ts'o  wrote:
> On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote:
>> This test creates a file system with a 1k block size.  Since there are
>> no architectures with a 1k page size, test file system can never be
> s/test file system/the test file system/
>
>> mounted with DAX enabled, causing the test to fail.
Looks good to me. Feel free to add:
Reviewed-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>

> Sorry, typo.
>
> 						- Ted
>
>
>

Patch
diff mbox series

diff --git a/tests/ext4/035 b/tests/ext4/035
index ac5f38e0..05867402 100755
--- a/tests/ext4/035
+++ b/tests/ext4/035
@@ -36,6 +36,7 @@  _cleanup()
 _supported_fs ext4
 _supported_os Linux
 _require_scratch
+_exclude_scratch_mount_option dax
 _require_command "$RESIZE2FS_PROG" resize2fs
 
 rm -f $seqres.full