| Message ID | 20190610172255.6792-1-vkuznets@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | selftests/kvm: make platform_info_test pass on AMD | expand |
Vitaly Kuznetsov <vkuznets@redhat.com> writes: > test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state > is undefined after that so an attempt to launch this guest again from > test_msr_platform_info_enabled() fails. Reorder the tests to make test > pass. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > --- > tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c > index 40050e44ec0a..f9334bd3cce9 100644 > --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c > +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c > @@ -99,8 +99,8 @@ int main(int argc, char *argv[]) > msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO); > vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, > msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO); > - test_msr_platform_info_disabled(vm); > test_msr_platform_info_enabled(vm); > + test_msr_platform_info_disabled(vm); > vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info); > > kvm_vm_free(vm); Ping!
On 21/08/19 18:10, Vitaly Kuznetsov wrote: > Vitaly Kuznetsov <vkuznets@redhat.com> writes: > >> test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state >> is undefined after that so an attempt to launch this guest again from >> test_msr_platform_info_enabled() fails. Reorder the tests to make test >> pass. >> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> >> --- >> tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c >> index 40050e44ec0a..f9334bd3cce9 100644 >> --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c >> +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c >> @@ -99,8 +99,8 @@ int main(int argc, char *argv[]) >> msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO); >> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, >> msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO); >> - test_msr_platform_info_disabled(vm); >> test_msr_platform_info_enabled(vm); >> + test_msr_platform_info_disabled(vm); >> vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info); >> >> kvm_vm_free(vm); > > Ping! > Queued, thanks. Paolo
diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c index 40050e44ec0a..f9334bd3cce9 100644 --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c @@ -99,8 +99,8 @@ int main(int argc, char *argv[]) msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO); vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO); - test_msr_platform_info_disabled(vm); test_msr_platform_info_enabled(vm); + test_msr_platform_info_disabled(vm); vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info); kvm_vm_free(vm);
test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state is undefined after that so an attempt to launch this guest again from test_msr_platform_info_enabled() fails. Reorder the tests to make test pass. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)