| Message ID | 20190610185354.35310-3-rrangel@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] mmc: sdhci: sdhci-pci-o2micro: Correctly set bus width when tuning | expand |
On 10/06/19 9:53 PM, Raul E Rangel wrote: > The value is referring to SDHCI_HOST_CONTROL, not SDHCI_CTRL_DMA_MASK. > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > > drivers/mmc/host/sdhci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 199712e7adbb3..89fd96596a1f7 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -89,7 +89,7 @@ > #define SDHCI_CTRL_ADMA32 0x10 > #define SDHCI_CTRL_ADMA64 0x18 > #define SDHCI_CTRL_ADMA3 0x18 > -#define SDHCI_CTRL_8BITBUS 0x20 > +#define SDHCI_CTRL_8BITBUS 0x20 > #define SDHCI_CTRL_CDTEST_INS 0x40 > #define SDHCI_CTRL_CDTEST_EN 0x80 > >
On Mon, 10 Jun 2019 at 20:55, Raul E Rangel <rrangel@chromium.org> wrote: > > The value is referring to SDHCI_HOST_CONTROL, not SDHCI_CTRL_DMA_MASK. Perhaps re-phrase this changelog as to mention that you are removing a white-space to fix alignment, as that was not so obvious. Kind regards Uffe > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> > --- > > drivers/mmc/host/sdhci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 199712e7adbb3..89fd96596a1f7 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -89,7 +89,7 @@ > #define SDHCI_CTRL_ADMA32 0x10 > #define SDHCI_CTRL_ADMA64 0x18 > #define SDHCI_CTRL_ADMA3 0x18 > -#define SDHCI_CTRL_8BITBUS 0x20 > +#define SDHCI_CTRL_8BITBUS 0x20 > #define SDHCI_CTRL_CDTEST_INS 0x40 > #define SDHCI_CTRL_CDTEST_EN 0x80 > > -- > 2.22.0.rc2.383.gf4fbbf30c2-goog >
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 199712e7adbb3..89fd96596a1f7 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -89,7 +89,7 @@ #define SDHCI_CTRL_ADMA32 0x10 #define SDHCI_CTRL_ADMA64 0x18 #define SDHCI_CTRL_ADMA3 0x18 -#define SDHCI_CTRL_8BITBUS 0x20 +#define SDHCI_CTRL_8BITBUS 0x20 #define SDHCI_CTRL_CDTEST_INS 0x40 #define SDHCI_CTRL_CDTEST_EN 0x80
The value is referring to SDHCI_HOST_CONTROL, not SDHCI_CTRL_DMA_MASK. Signed-off-by: Raul E Rangel <rrangel@chromium.org> --- drivers/mmc/host/sdhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)