From patchwork Tue Jun 11 11:28:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10986605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 11FCA14DB for ; Tue, 11 Jun 2019 11:29:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02FB4287D1 for ; Tue, 11 Jun 2019 11:29:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAE4728803; Tue, 11 Jun 2019 11:29:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 954FF287D1 for ; Tue, 11 Jun 2019 11:29:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5A72890F7; Tue, 11 Jun 2019 11:29:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C201890F7 for ; Tue, 11 Jun 2019 11:29:06 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k8so4907730eds.7 for ; Tue, 11 Jun 2019 04:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KWiSkWv/DkQjaVk1HaiNhqwbIu727aF1qlGWvhFG594=; b=AMrB9/CTAMmcOR6OmIrpb8XhUN+0rVI2U42LSy+9ViFvqpZ/UO/oWd2XOnvAP0kw9s SXblsEGeVpxwtlTtimILonNVH+MOqNFrQB+fiSuN3RTqzvucH7/EVwjZIVk8KpS9+xch wu4RkQ5CCJitpFnL+x64cPD5sq/rZ4S5PwZfr8GoTc8pvkJxEjeoYXpjikJ/zRPO2ywc eSJJpIPuVAF04Jlq0tT2AsZqq15gUQ4xvoJX1snIumzFPEcdrLo8luQRO6HNNzCSICht /VVJy/wqi4mn00EVcOjUNlLfj4mEO4HIgS3tXcwnlx6VzHJhsgpzy2RwBSpum1T6XFrZ QjbA== X-Gm-Message-State: APjAAAV3ra1K2DouK+UQ9ggGhYn0m83mAVL/efPP7Sbs+YCEED7NOtxQ 0hxdQe57vKzm2psuQWXVZdX/DRYzNy0= X-Google-Smtp-Source: APXvYqyI4/K5WMxqov4d43jeJHlEso7Rt7Mrx8FqYsZI2yoEd2sX6tC0wmDJjWDgWo57RI0oL6edeQ== X-Received: by 2002:a50:8bcc:: with SMTP id n12mr57208517edn.6.1560252544942; Tue, 11 Jun 2019 04:29:04 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id m16sm2209247ejj.57.2019.06.11.04.29.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 04:29:04 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm/fb: document dirty helper better Date: Tue, 11 Jun 2019 13:28:59 +0200 Message-Id: <20190611112859.16375-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KWiSkWv/DkQjaVk1HaiNhqwbIu727aF1qlGWvhFG594=; b=iNxcLzipxnIPrjN+4Jl7kDD1SCdZB35yt3GiA5m8Cjw3oIqdLBjV6AJV8kaUv6kJqt xD2UKwlMroqOuwmLPStTtUfcRFar2RDu9Fj3DjVEY4jWvpdAxqHwynl+dNglvGr0Pvuv wGkGOIRMtxxO+Ai/n1rAa3M06V54YgTJ2sEdk= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Lechner , Maxime Ripard , Daniel Vetter , Sebastian Reichel , Hans de Goede , Tomi Valkeinen , Gerd Hoffmann , Daniel Vetter , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Apparently little none fact that there's no need to hand-roll your own anymore. Cc'ing a bunch of driver people who might want to know this too. Cc: Rob Clark Cc: Sebastian Reichel Cc: Tomi Valkeinen Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Gerd Hoffmann Cc: David Lechner Cc: Noralf Trønnes Cc: Hans de Goede Signed-off-by: Daniel Vetter Reviewed-by: Noralf Trønnes --- include/drm/drm_framebuffer.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index c23016748e3f..c0e0256e3e98 100644 --- a/include/drm/drm_framebuffer.h +++ b/include/drm/drm_framebuffer.h @@ -87,6 +87,9 @@ struct drm_framebuffer_funcs { * for more information as all the semantics and arguments have a one to * one mapping on this function. * + * Atomic drivers should use drm_atomic_helper_dirtyfb() to implement + * this hook. + * * RETURNS: * * 0 on success or a negative error code on failure.