| Message ID | 20190611125315.18736-2-raphael.gault@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Enable access to pmu registers by user-space | expand |
On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote: > In order to subsequently add more tests for the arm64 architecture > we compile the tests target for arm64 systematically. Given prior questions regarding this commit, it's probably worth spelling things out more explicitly, e.g. Currently we only build the arm64/tests directory if CONFIG_DWARF_UNWIND is selected, which is fine as the only test we have is arm64/tests/dwarf-unwind.o. So that we can add more tests to the test directory, let's unconditionally build the directory, but conditionally build dwarf-unwind.o depending on CONFIG_DWARF_UNWIND. There should be no functional change as a result of this patch. > > Signed-off-by: Raphael Gault <raphael.gault@arm.com> Either way, the patch looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > tools/perf/arch/arm64/Build | 2 +- > tools/perf/arch/arm64/tests/Build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/arch/arm64/Build b/tools/perf/arch/arm64/Build > index 36222e64bbf7..a7dd46a5b678 100644 > --- a/tools/perf/arch/arm64/Build > +++ b/tools/perf/arch/arm64/Build > @@ -1,2 +1,2 @@ > perf-y += util/ > -perf-$(CONFIG_DWARF_UNWIND) += tests/ > +perf-y += tests/ > diff --git a/tools/perf/arch/arm64/tests/Build b/tools/perf/arch/arm64/tests/Build > index 41707fea74b3..a61c06bdb757 100644 > --- a/tools/perf/arch/arm64/tests/Build > +++ b/tools/perf/arch/arm64/tests/Build > @@ -1,4 +1,4 @@ > perf-y += regs_load.o > -perf-y += dwarf-unwind.o > +perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o > > perf-y += arch-tests.o > -- > 2.17.1 >
Em Tue, Jun 11, 2019 at 03:09:07PM +0100, Mark Rutland escreveu: > On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote: > > In order to subsequently add more tests for the arm64 architecture > > we compile the tests target for arm64 systematically. > > Given prior questions regarding this commit, it's probably worth > spelling things out more explicitly, e.g. > > Currently we only build the arm64/tests directory if > CONFIG_DWARF_UNWIND is selected, which is fine as the only test we > have is arm64/tests/dwarf-unwind.o. > > So that we can add more tests to the test directory, let's > unconditionally build the directory, but conditionally build > dwarf-unwind.o depending on CONFIG_DWARF_UNWIND. > > There should be no functional change as a result of this patch. > > > > > Signed-off-by: Raphael Gault <raphael.gault@arm.com> > > Either way, the patch looks good to me: > > Acked-by: Mark Rutland <mark.rutland@arm.com> I'll update the comment, collect your Acked-by and apply the patch. - Arnaldo > Mark. > > > --- > > tools/perf/arch/arm64/Build | 2 +- > > tools/perf/arch/arm64/tests/Build | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/arch/arm64/Build b/tools/perf/arch/arm64/Build > > index 36222e64bbf7..a7dd46a5b678 100644 > > --- a/tools/perf/arch/arm64/Build > > +++ b/tools/perf/arch/arm64/Build > > @@ -1,2 +1,2 @@ > > perf-y += util/ > > -perf-$(CONFIG_DWARF_UNWIND) += tests/ > > +perf-y += tests/ > > diff --git a/tools/perf/arch/arm64/tests/Build b/tools/perf/arch/arm64/tests/Build > > index 41707fea74b3..a61c06bdb757 100644 > > --- a/tools/perf/arch/arm64/tests/Build > > +++ b/tools/perf/arch/arm64/tests/Build > > @@ -1,4 +1,4 @@ > > perf-y += regs_load.o > > -perf-y += dwarf-unwind.o > > +perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o > > > > perf-y += arch-tests.o > > -- > > 2.17.1 > >
On Tue, Jun 11, 2019 at 11:23:56AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 11, 2019 at 03:09:07PM +0100, Mark Rutland escreveu: > > On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote: > > > In order to subsequently add more tests for the arm64 architecture > > > we compile the tests target for arm64 systematically. > > > > Given prior questions regarding this commit, it's probably worth > > spelling things out more explicitly, e.g. > > > > Currently we only build the arm64/tests directory if > > CONFIG_DWARF_UNWIND is selected, which is fine as the only test we > > have is arm64/tests/dwarf-unwind.o. > > > > So that we can add more tests to the test directory, let's > > unconditionally build the directory, but conditionally build > > dwarf-unwind.o depending on CONFIG_DWARF_UNWIND. > > > > There should be no functional change as a result of this patch. > > > > > > > > Signed-off-by: Raphael Gault <raphael.gault@arm.com> > > > > Either way, the patch looks good to me: > > > > Acked-by: Mark Rutland <mark.rutland@arm.com> > > I'll update the comment, collect your Acked-by and apply the patch. That's great, thanks! As a heads-up, there are still open ABI discussions to be had on the rest of the series, so while review would be appreciated, it would be best to hold off applying the remaining userspace bits for now. Mark.
diff --git a/tools/perf/arch/arm64/Build b/tools/perf/arch/arm64/Build index 36222e64bbf7..a7dd46a5b678 100644 --- a/tools/perf/arch/arm64/Build +++ b/tools/perf/arch/arm64/Build @@ -1,2 +1,2 @@ perf-y += util/ -perf-$(CONFIG_DWARF_UNWIND) += tests/ +perf-y += tests/ diff --git a/tools/perf/arch/arm64/tests/Build b/tools/perf/arch/arm64/tests/Build index 41707fea74b3..a61c06bdb757 100644 --- a/tools/perf/arch/arm64/tests/Build +++ b/tools/perf/arch/arm64/tests/Build @@ -1,4 +1,4 @@ perf-y += regs_load.o -perf-y += dwarf-unwind.o +perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o perf-y += arch-tests.o
In order to subsequently add more tests for the arm64 architecture we compile the tests target for arm64 systematically. Signed-off-by: Raphael Gault <raphael.gault@arm.com> --- tools/perf/arch/arm64/Build | 2 +- tools/perf/arch/arm64/tests/Build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)