| Message ID | 20190611170913.20913-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret | expand |
On 11/06/2019 at 19:09, Colin King wrote: > External E-Mail > > > From: Colin Ian King <colin.king@canonical.com> > > Currently variable ret is being initialized with -ENOENT however that > value is never read and ret is being re-assigned later on. Hence this > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Indeed: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas > --- > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > index fb117ccbeab3..930cc3f92e01 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -950,7 +950,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) > struct fb_videomode fb_vm; > struct gpio_desc *gpiod; > struct videomode vm; > - int ret = -ENOENT; > + int ret; > int i; > > sinfo->config = (struct atmel_lcdfb_config*) >
On Wed, Jun 12, 2019 at 09:55:30AM +0200, Nicolas Ferre - M43238 wrote: > On 11/06/2019 at 19:09, Colin King wrote: > > External E-Mail > > > > > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently variable ret is being initialized with -ENOENT however that > > value is never read and ret is being re-assigned later on. Hence this > > assignment is redundant and can be removed. > > > > Addresses-Coverity: ("Unused value") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Indeed: > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks > > Thanks, best regards, > Nicolas > > > > --- > > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > > index fb117ccbeab3..930cc3f92e01 100644 > > --- a/drivers/video/fbdev/atmel_lcdfb.c > > +++ b/drivers/video/fbdev/atmel_lcdfb.c > > @@ -950,7 +950,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) > > struct fb_videomode fb_vm; > > struct gpio_desc *gpiod; > > struct videomode vm; > > - int ret = -ENOENT; > > + int ret; > > int i; > > > > sinfo->config = (struct atmel_lcdfb_config*) > > > > > -- > Nicolas Ferre
On 6/12/19 4:13 PM, Ludovic Desroches wrote: > On Wed, Jun 12, 2019 at 09:55:30AM +0200, Nicolas Ferre - M43238 wrote: >> On 11/06/2019 at 19:09, Colin King wrote: >>> External E-Mail >>> >>> >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> Currently variable ret is being initialized with -ENOENT however that >>> value is never read and ret is being re-assigned later on. Hence this >>> assignment is redundant and can be removed. >>> >>> Addresses-Coverity: ("Unused value") >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> >> Indeed: >> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Patch queued for v5.3, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index fb117ccbeab3..930cc3f92e01 100644 --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -950,7 +950,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) struct fb_videomode fb_vm; struct gpio_desc *gpiod; struct videomode vm; - int ret = -ENOENT; + int ret; int i; sinfo->config = (struct atmel_lcdfb_config*)