| Message ID | 20190611180757.32299-1-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/5] clk: ingenic: Add missing header in cgu.h | expand |
Quoting Paul Cercueil (2019-06-11 11:07:53) > The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' > structures (no pointers), so the <linux/clk-provider.h> header should be > included. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > > Notes: > v2: Rebase on v5.2-rc4 You seemed to miss my review comments on patch set #1. https://lkml.kernel.org/r/155726035790.14659.7321778387595703949@swboyd.mtv.corp.google.com
Quoting Stephen Boyd (2019-06-25 15:17:35) > Quoting Paul Cercueil (2019-06-11 11:07:53) > > The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' > > structures (no pointers), so the <linux/clk-provider.h> header should be > > included. > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > --- > > > > Notes: > > v2: Rebase on v5.2-rc4 > > You seemed to miss my review comments on patch set #1. > > https://lkml.kernel.org/r/155726035790.14659.7321778387595703949@swboyd.mtv.corp.google.com > I've just decided to fix it instead of wait. Let me know if that's a problem.
Le mer. 26 juin 2019 à 0:42, Stephen Boyd <sboyd@kernel.org> a écrit : > Quoting Stephen Boyd (2019-06-25 15:17:35) >> Quoting Paul Cercueil (2019-06-11 11:07:53) >> > The cgu.h has structures that contain 'clk_onecell_data' and >> 'clk_hw' >> > structures (no pointers), so the <linux/clk-provider.h> header >> should be >> > included. >> > >> > Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> > --- >> > >> > Notes: >> > v2: Rebase on v5.2-rc4 >> >> You seemed to miss my review comments on patch set #1. >> >> >> https://lkml.kernel.org/r/155726035790.14659.7321778387595703949@swboyd.mtv.corp.google.com Oops. Sorry about that. > I've just decided to fix it instead of wait. Let me know if that's a > problem. Sure, that's no problem. Thanks! -Paul
diff --git a/drivers/clk/ingenic/cgu.h b/drivers/clk/ingenic/cgu.h index bfbcf6db437d..ef2db1e26e58 100644 --- a/drivers/clk/ingenic/cgu.h +++ b/drivers/clk/ingenic/cgu.h @@ -10,6 +10,7 @@ #define __DRIVERS_CLK_INGENIC_CGU_H__ #include <linux/bitops.h> +#include <linux/clk-provider.h> #include <linux/of.h> #include <linux/spinlock.h> diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c index 8901ea0295b7..6e8bbf620c76 100644 --- a/drivers/clk/ingenic/jz4725b-cgu.c +++ b/drivers/clk/ingenic/jz4725b-cgu.c @@ -6,7 +6,6 @@ * Author: Paul Cercueil <paul@crapouillou.net> */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/of.h> #include <dt-bindings/clock/jz4725b-cgu.h> diff --git a/drivers/clk/ingenic/jz4740-cgu.c b/drivers/clk/ingenic/jz4740-cgu.c index c77f4e1506dc..2deac19a8d04 100644 --- a/drivers/clk/ingenic/jz4740-cgu.c +++ b/drivers/clk/ingenic/jz4740-cgu.c @@ -6,7 +6,6 @@ * Author: Paul Burton <paul.burton@mips.com> */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/io.h> #include <linux/of.h> diff --git a/drivers/clk/ingenic/jz4770-cgu.c b/drivers/clk/ingenic/jz4770-cgu.c index dfce740c25a8..42b2ee121642 100644 --- a/drivers/clk/ingenic/jz4770-cgu.c +++ b/drivers/clk/ingenic/jz4770-cgu.c @@ -5,7 +5,6 @@ */ #include <linux/bitops.h> -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/io.h> #include <linux/of.h> diff --git a/drivers/clk/ingenic/jz4780-cgu.c b/drivers/clk/ingenic/jz4780-cgu.c index 2464fc4032af..6d524e760180 100644 --- a/drivers/clk/ingenic/jz4780-cgu.c +++ b/drivers/clk/ingenic/jz4780-cgu.c @@ -6,7 +6,6 @@ * Author: Paul Burton <paul.burton@mips.com> */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/io.h> #include <linux/of.h>
The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' structures (no pointers), so the <linux/clk-provider.h> header should be included. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: Rebase on v5.2-rc4 drivers/clk/ingenic/cgu.h | 1 + drivers/clk/ingenic/jz4725b-cgu.c | 1 - drivers/clk/ingenic/jz4740-cgu.c | 1 - drivers/clk/ingenic/jz4770-cgu.c | 1 - drivers/clk/ingenic/jz4780-cgu.c | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)