[1/2] drm/omapdrm: drop fb_debug_enter/leave
diff mbox series

Message ID 20190612091253.26413-1-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • [1/2] drm/omapdrm: drop fb_debug_enter/leave
Related show

Commit Message

Daniel Vetter June 12, 2019, 9:12 a.m. UTC
This is a no-op on atomic drivers because with atomic it's simply too
complicated to get all the locking and workers and nonblocking
synchronization correct, from essentially an NMI context. Well, too
complicated = impossible. Also, omapdrm never implemented the
mode_set_base_atomic hook, so I kinda wonder why this was ever added.

Drop the hooks.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Tomi Valkeinen June 12, 2019, 9:19 a.m. UTC | #1
On 12/06/2019 12:12, Daniel Vetter wrote:
> This is a no-op on atomic drivers because with atomic it's simply too
> complicated to get all the locking and workers and nonblocking
> synchronization correct, from essentially an NMI context. Well, too
> complicated = impossible. Also, omapdrm never implemented the
> mode_set_base_atomic hook, so I kinda wonder why this was ever added.
> 
> Drop the hooks.

f9b34a0fa4e25d9c0b72f124680c37c0c38f9934

It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of 
"Initializer entry defined twice" warning.

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Or I can pick it up to my branch if this is not part of a bigger series.

  Tomi
Daniel Vetter June 12, 2019, 12:31 p.m. UTC | #2
On Wed, Jun 12, 2019 at 11:19 AM Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> On 12/06/2019 12:12, Daniel Vetter wrote:
> > This is a no-op on atomic drivers because with atomic it's simply too
> > complicated to get all the locking and workers and nonblocking
> > synchronization correct, from essentially an NMI context. Well, too
> > complicated = impossible. Also, omapdrm never implemented the
> > mode_set_base_atomic hook, so I kinda wonder why this was ever added.
> >
> > Drop the hooks.
>
> f9b34a0fa4e25d9c0b72f124680c37c0c38f9934
>
> It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of
> "Initializer entry defined twice" warning.
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Or I can pick it up to my branch if this is not part of a bigger series.

Not part of a bigger series, there's still a bunch of real users of
this in-tree. Although given how absolutely no one seems to care to
make kgdb work on top of atomic drivers I'm hoping I can sunset all
this code soon.
-Daniel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 50aabd854f4d..0dad42e819ba 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -87,8 +87,6 @@  static struct fb_ops omap_fb_ops = {
 	.fb_setcmap	= drm_fb_helper_setcmap,
 	.fb_blank	= drm_fb_helper_blank,
 	.fb_pan_display = omap_fbdev_pan_display,
-	.fb_debug_enter = drm_fb_helper_debug_enter,
-	.fb_debug_leave = drm_fb_helper_debug_leave,
 	.fb_ioctl	= drm_fb_helper_ioctl,
 
 	.fb_read = drm_fb_helper_sys_read,